Received: by 2002:a05:7412:8d09:b0:fa:4c10:6cad with SMTP id bj9csp246015rdb; Mon, 15 Jan 2024 21:05:22 -0800 (PST) X-Google-Smtp-Source: AGHT+IFV3sfSdL2Sz6gEgeQuv/UK6WKmLpdahAxqTuJ6z8s9UZdC1xREOJpd191o2PR3SILjLlhg X-Received: by 2002:a17:902:e882:b0:1d4:910f:f85c with SMTP id w2-20020a170902e88200b001d4910ff85cmr8662425plg.5.1705381522490; Mon, 15 Jan 2024 21:05:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1705381522; cv=none; d=google.com; s=arc-20160816; b=lfqpmcKSv63wcabjoe2MORnq2l0Z+m5zFRnjuIEH0IlimSh9U916IGhTTscUIIJFLC EDatpXoaZZLLJ8l0gyw18/O3vHg2pLOGyWCdDiRkffEULLW60rax2fs1EDYNiuNBmZO/ Y+yocb0aIQhrzB5pKnOoq4X1sGkjbRMMNU8PV9W1Zkr2zMCdjI20Pg4xy+h/xMDpaRNa +casmjZb2rac7lNgln1TKxkL3pEgdMmz2zqyFonxDTK5NAHMOMC25VaNUHrxGX6Np+ta YeIgYJrlFiuSnt4bjKsZYx9qoYfsKZ+VZ6rOAEILFSUHMF3HcVqINlW1kiGrl486rHAJ itZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=U/ryvFXl0g/E2W/SGXd0vXktMOsk5tL/M09B88SuJmk=; fh=GxhqyS83Lb/VLL8pOwwCAMyVcf8vAShTSczp71aKq94=; b=WgNFDkxJ/OUlh9s8UTeK5kRKHv3qWDhjjU7K4DPJMtuLAQ6zkIAeJRmJwVIKIlI6Yq YMeR3vcxd/ydDml5ngTD53xYUmEdO/n+UPqcQbWZuwFov2PKfAsnZ8ydLs0FC15rhuXw zX8m8PQ9nGy6ti5XZgnIopCR544+oA1VTOi9/1oNXqnxFb/bQKZu6+yoGYG2levbRxJG yN7xeaoDfJozcWM0PusMxn0g1PHhcYuw0j+ePMAItWHpBHWknpp3uuA4mw6pikNnWqvV RtUELUB1ilfZIyS4dovunGfyqUh+/+cz8xDIqoc53PKD70XOW2xrYBIKtIGRXumvx50L gAWA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-27001-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-27001-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=fujitsu.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id ju4-20020a170903428400b001d5e9a0ea1asi362704plb.22.2024.01.15.21.05.22 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jan 2024 21:05:22 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-27001-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-27001-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-27001-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=fujitsu.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 2C2FE284DC3 for ; Tue, 16 Jan 2024 05:05:22 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7E6F41E882; Tue, 16 Jan 2024 04:53:37 +0000 (UTC) Received: from esa10.hc1455-7.c3s2.iphmx.com (esa10.hc1455-7.c3s2.iphmx.com [139.138.36.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 01C38125B8; Tue, 16 Jan 2024 04:53:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=fujitsu.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fujitsu.com X-IronPort-AV: E=McAfee;i="6600,9927,10954"; a="133883823" X-IronPort-AV: E=Sophos;i="6.04,198,1695654000"; d="scan'208";a="133883823" Received: from unknown (HELO oym-r4.gw.nic.fujitsu.com) ([210.162.30.92]) by esa10.hc1455-7.c3s2.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jan 2024 13:52:26 +0900 Received: from oym-m2.gw.nic.fujitsu.com (oym-nat-oym-m2.gw.nic.fujitsu.com [192.168.87.59]) by oym-r4.gw.nic.fujitsu.com (Postfix) with ESMTP id ADC21D9D96; Tue, 16 Jan 2024 13:52:23 +0900 (JST) Received: from kws-ab3.gw.nic.fujitsu.com (kws-ab3.gw.nic.fujitsu.com [192.51.206.21]) by oym-m2.gw.nic.fujitsu.com (Postfix) with ESMTP id D9229BF498; Tue, 16 Jan 2024 13:52:22 +0900 (JST) Received: from edo.cn.fujitsu.com (edo.cn.fujitsu.com [10.167.33.5]) by kws-ab3.gw.nic.fujitsu.com (Postfix) with ESMTP id 65968200A571F; Tue, 16 Jan 2024 13:52:22 +0900 (JST) Received: from localhost.localdomain (unknown [10.167.226.45]) by edo.cn.fujitsu.com (Postfix) with ESMTP id DF70F1A0070; Tue, 16 Jan 2024 12:52:21 +0800 (CST) From: Li Zhijian To: linux-kernel@vger.kernel.org Cc: Li Zhijian , Artur Paszkiewicz , "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org Subject: [PATCH 27/42] drivers/scsi/isci: Convert snprintf to sysfs_emit Date: Tue, 16 Jan 2024 12:51:36 +0800 Message-Id: <20240116045151.3940401-25-lizhijian@fujitsu.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20240116045151.3940401-1-lizhijian@fujitsu.com> References: <20240116041129.3937800-1-lizhijian@fujitsu.com> <20240116045151.3940401-1-lizhijian@fujitsu.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-TM-AS-Product-Ver: IMSS-9.1.0.1417-9.0.0.1002-28122.004 X-TM-AS-User-Approved-Sender: Yes X-TMASE-Version: IMSS-9.1.0.1417-9.0.1002-28122.004 X-TMASE-Result: 10--8.691000-10.000000 X-TMASE-MatchedRID: 6SYb29c3rTQ4ibokZ3+Q0CoiRKlBVkYIBXngI6jFvpfvd49YGReckE1N J2MN+nPkgxCMf8A0YpR5sRK06wHV4YuJ+QzKcxqTLdBFrfY9r2n0swHSFcVJ6MC5DTEMxpeQfiq 1gj2xET8vYRhsicUjm84WYLmQfXYmpoPHQXywp1dKzjuZtPtIBH0tCKdnhB58I/9UW5M5dRNp7q EhmmPgy46HM5rqDwqtIoT1kA8A17I5ZLFwfHbExp8OJA/0wv/axoNjqIW+oL/stU4J8kSlZQ== X-TMASE-SNAP-Result: 1.821001.0001-0-1-22:0,33:0,34:0-0 Per filesystems/sysfs.rst, show() should only use sysfs_emit() or sysfs_emit_at() when formatting the value to be returned to user space. coccinelle complains that there are still a couple of functions that use snprintf(). Convert them to sysfs_emit(). > ./drivers/scsi/isci/init.c:140:8-16: WARNING: please use sysfs_emit No functional change intended CC: Artur Paszkiewicz CC: "James E.J. Bottomley" CC: "Martin K. Petersen" CC: linux-scsi@vger.kernel.org Signed-off-by: Li Zhijian --- drivers/scsi/isci/init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/isci/init.c b/drivers/scsi/isci/init.c index 6277162a028b..c582a3932cea 100644 --- a/drivers/scsi/isci/init.c +++ b/drivers/scsi/isci/init.c @@ -137,7 +137,7 @@ static ssize_t isci_show_id(struct device *dev, struct device_attribute *attr, c struct sas_ha_struct *sas_ha = SHOST_TO_SAS_HA(shost); struct isci_host *ihost = container_of(sas_ha, typeof(*ihost), sas_ha); - return snprintf(buf, PAGE_SIZE, "%d\n", ihost->id); + return sysfs_emit(buf, "%d\n", ihost->id); } static DEVICE_ATTR(isci_id, S_IRUGO, isci_show_id, NULL); -- 2.29.2