Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935063AbXLNAH5 (ORCPT ); Thu, 13 Dec 2007 19:07:57 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S934809AbXLNAHT (ORCPT ); Thu, 13 Dec 2007 19:07:19 -0500 Received: from ms-smtp-05.nyroc.rr.com ([24.24.2.59]:36858 "EHLO ms-smtp-05.nyroc.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934974AbXLNAHQ (ORCPT ); Thu, 13 Dec 2007 19:07:16 -0500 Date: Thu, 13 Dec 2007 19:06:35 -0500 (EST) From: Steven Rostedt X-X-Sender: rostedt@gandalf.stny.rr.com To: Remy Bohmer cc: LKML , RT , Ingo Molnar , Thomas Gleixner , Gregory Haskins Subject: Re: 2.6.23.9-rt13 In-Reply-To: <3efb10970712130243t2172907cm31c5d3af29383c8b@mail.gmail.com> Message-ID: References: <1197524036.15001.15.camel@localhost.localdomain> <3efb10970712130243t2172907cm31c5d3af29383c8b@mail.gmail.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1339 Lines: 44 Hi Remy, This would have been better to send this as two separate patches. They are two different issues. On Thu, 13 Dec 2007, Remy Bohmer wrote: > If I compile -rt13 I get some compile warnings on ARM (AT91): > 1) This one did not exist in rt1: > In file included from kernel/sched.c:911: > kernel/sched_rt.c: In function 'dec_rt_tasks': > kernel/sched_rt.c:88: warning: unused variable 'highest_prio' This is from Gregory Haskins' patch. He forgot to compile check for warnings on UP again ;-) > 2) This one is there already for a much longer time: > CC kernel/rcupreempt.o > kernel/rcupreempt.c:1001: warning: 'per_cpu__rcu_dyntick_snapshot' > defined but not used This was a merge conflict being solved incorrectly. > > Both warnings are fixed by the attached patch, but warning 2 needs some review. > This var is defined twice in this file, 1 in the NO_HZ ifdef, and 1 > which seems to be not used. Yeah, I'll look into it since I wrote that usage ;-) Greg, Can you merge the first part into your patch and resend it to me. I'll look at the second one. Thanks, -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/