Received-SPF: pass (google.com: domain of linux-kernel+bounces-27007-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
References: <20240116041129.3937800-1-lizhijian@fujitsu.com>
 <20240116045151.3940401-1-lizhijian@fujitsu.com>
 <20240116045151.3940401-13-lizhijian@fujitsu.com>
User-agent: mu4e 1.10.8; emacs 28.2
From: Rahul Rameshbabu <rrameshbabu@nvidia.com>
To: Li Zhijian <lizhijian@fujitsu.com>
Cc: linux-kernel@vger.kernel.org, Richard Cochran
 <richardcochran@gmail.com>, netdev@vger.kernel.org
Subject: Re: [PATCH 15/42] drivers/ptp: Convert snprintf to sysfs_emit
Date: Mon, 15 Jan 2024 21:01:22 -0800
In-reply-to: <20240116045151.3940401-13-lizhijian@fujitsu.com>
Message-ID: <875xztzx3e.fsf@nvidia.com>
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?jgZl8tONTROflBM3Z0q59QPtdi0Clqn1mOuSzS8/WP6vKboxfU/UR8oCZyXS?=
 =?us-ascii?Q?J5AwBGIt0g2KxT5XRRdyf9QUFrC/ekRru9Cda9DNalprdGSGw0jYUmhQJd1q?=
 =?us-ascii?Q?IH8AdG/LY3VvC2Leal8QSks3esfNKkEi5OWm2VfshXRmpgkI6709DVJOdy8y?=
 =?us-ascii?Q?eO+Lf+994p/rIEMyH3iMvT7X6g+5vIlFICQT6KTbHfgig+Hux5ae146Lfos6?=
 =?us-ascii?Q?AcvZQDs8rrCHMDlYfAYbyc42Q/Uytia/atEUGMoraOB8lYA/nKFd7IsLv8hK?=
 =?us-ascii?Q?bMsjKAumnCv/kkOt97buy4sdgzCdKMOgr2I/5nlNOgpfnhQ2Bo3zCvriMli5?=
 =?us-ascii?Q?mjO2m50xrGnM9FoLbeuVkDZe8MkukmAtwj36U/EuGT4X/wljjb9QASuLNC1D?=
 =?us-ascii?Q?F2kjR1dWUeFmCBSTBEG8k0ziBN4lNzVnfvC/CCIMGjf5I2ipN+ukMivvRkK8?=
 =?us-ascii?Q?ddVplQFgAMgIgkCSS1tEgXFmr7zPPL2MBkF7K0SUps1Erg03Qe8enFI8eUfG?=
 =?us-ascii?Q?Ti9hlamGpK/+djaUapQL1pGgqa9QHHoYUbiP3ZMQH1aNfuI7n2bKG09FCUl8?=
 =?us-ascii?Q?a9addTGFCFQwB3imCZcXyVr/+LQcmZ+G7zOyzLuK+MvAR7sMWbnzOpVL7WPG?=
 =?us-ascii?Q?FSVtE43taLg6HaEV7wMHxDJV0yEAR/Y/agQqa7w4Pyi3kRNuUZDIjje66Ihp?=
 =?us-ascii?Q?uXqC3GghC/hh+Szx3soNLSLDed/S8M02VgO9uXGI29dbuphq0zyS4FWEy3ZO?=
 =?us-ascii?Q?Im0Jn7070Z+3fHRMhI51NVbb6IEqIRRUeluM8EqdrsK1/MqM6l77tccXkTOG?=
 =?us-ascii?Q?LpG3K7ZSpdTkyIufutmsAZFbne+E2k/gzCYt+5urZAC/lkPS7UmSbYY+bxfQ?=
 =?us-ascii?Q?rdZSxUN6pF6s037TFDdPuNINwB8nYdPnLkQIBC9jA7FCyOIMIzxYjkc/GeIT?=
 =?us-ascii?Q?ewHsk78orxwE+HgmGcefmSmW/vlyYMOpt/pZbxkTezWfnt0iP9pFw/PFU7YA?=
 =?us-ascii?Q?9lPrEKgf/1XzGfIqA96TIPrEvOvcW3THAHxz+s1qhwKOA1asBzOMaczy31qD?=
 =?us-ascii?Q?Dz3+01w+IyP1VCGUOribsllMnI3GkZbUkzw8VJRIcSdi35c5Mn+c5BS3gZ7S?=
 =?us-ascii?Q?wNesaG/qyxh5gpGgKgf61kzbHfTp9nE6vaNCSQYDOCaIuRjHevDBQhnqB2TQ?=
 =?us-ascii?Q?/Fh9QYzdxysQ8L+mSW74zpIuSdXgtIydb/if04748vaP8kMXKcvbRS4TU0w2?=
 =?us-ascii?Q?zYN8Fnkj2FV5nP490nkv6+cRrp6Gw+l4PowcYqXSIgIhKK22NmAMlbk+5PB5?=
 =?us-ascii?Q?iPJXXjFT0Pj2rfGUk9V13NruxbZd7JvJxl3cjv9Qz3RIp7EtStO9lAG4ax55?=
 =?us-ascii?Q?+5ACGNO6hDm44aVqw977WBuEyfGXfAbHzUhafI86+tW2haSuV3BsE5+1PfSx?=
 =?us-ascii?Q?1qyzRjxpK93sT6XyPbBhpoDC+eHAuWJSLAoXeQ7DtDv9bjxE7dz7AhahqhA7?=
 =?us-ascii?Q?UJzBMIqlngPZwdcF8tVSL33HZScqo11/JSh+BqXCfzsgp9ZQ3qNrbL28qDjU?=
 =?us-ascii?Q?p6NIK95eUvH5FrTPhzXE9LatuCHszL1f9FfyUoX+?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5ad8df28-3c41-4b45-7543-08dc1650d6b1
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB2743.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jan 2024 05:06:03.6132
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: en1aVbH3vYRD8B+EADjw4USpNOTIkPs7s0xcll7odAguL2hOpqfzdAP8gecPUk1pLNfSmNBn3qIY/Uqj2rfVnw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB8215

On Tue, 16 Jan, 2024 12:51:24 +0800 Li Zhijian <lizhijian@fujitsu.com> wrote:
> Per filesystems/sysfs.rst, show() should only use sysfs_emit()
> or sysfs_emit_at() when formatting the value to be returned to user space.
>
> coccinelle complains that there are still a couple of functions that use
> snprintf(). Convert them to sysfs_emit().
>
>> ./drivers/ptp/ptp_sysfs.c:27:8-16: WARNING: please use sysfs_emit
>
> No functional change intended
>
> CC: Richard Cochran <richardcochran@gmail.com>
> CC: netdev@vger.kernel.org
> Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
> ---
>  drivers/ptp/ptp_sysfs.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/ptp/ptp_sysfs.c b/drivers/ptp/ptp_sysfs.c
> index f7a499a1bd39..49737ed6ef5f 100644
> --- a/drivers/ptp/ptp_sysfs.c
> +++ b/drivers/ptp/ptp_sysfs.c
> @@ -24,8 +24,7 @@ static ssize_t max_phase_adjustment_show(struct device *dev,
>  {
>  	struct ptp_clock *ptp = dev_get_drvdata(dev);
>  
> -	return snprintf(page, PAGE_SIZE - 1, "%d\n",
> -			ptp->info->getmaxphase(ptp->info));
> +	return sysfs_emit(page, "%d\n", ptp->info->getmaxphase(ptp->info));
>  }
>  static DEVICE_ATTR_RO(max_phase_adjustment);

I authored the lines that are being changed here, so figured I should
provide my review. Doesn't PTP_SHOW_INT in the same file also use
snprintf in the same manner and should be changed to sysfs_emit?

--
Thanks,

Rahul Rameshbabu