Received-SPF: pass (google.com: domain of linux-kernel+bounces-27016-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
References: <20240115211516.635852-1-ankita@nvidia.com>
 <20240115211516.635852-3-ankita@nvidia.com>
User-agent: mu4e 1.10.8; emacs 28.2
From: Rahul Rameshbabu <rrameshbabu@nvidia.com>
To: ankita@nvidia.com
Cc: jgg@nvidia.com, alex.williamson@redhat.com, yishaih@nvidia.com,
 shameerali.kolothum.thodi@huawei.com, kevin.tian@intel.com,
 eric.auger@redhat.com, brett.creeley@amd.com, horms@kernel.org,
 aniketa@nvidia.com, cjia@nvidia.com, kwankhede@nvidia.com,
 targupta@nvidia.com, vsethi@nvidia.com, acurrid@nvidia.com,
 apopple@nvidia.com, jhubbard@nvidia.com, danw@nvidia.com,
 anuaggarwal@nvidia.com, mochs@nvidia.com, kvm@vger.kernel.org,
 linux-kernel@vger.kernel.org
Subject: Re: [PATCH v16 2/3] vfio/pci: implement range_intesect_range to
 determine range overlap
Date: Mon, 15 Jan 2024 21:19:33 -0800
In-reply-to: <20240115211516.635852-3-ankita@nvidia.com>
Message-ID: <871qahzw8m.fsf@nvidia.com>
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?BVnx1AgIfiTB322/rrcKXU9ayM1TFrqCW9Sv2vhGvx4awrTwBSoCdc2AtvyF?=
 =?us-ascii?Q?BsKi7HDNFLQIjAEbakrbZ28edB0ICv7Iq/vnWgpZCYFLhCOSovr5CXFtyum3?=
 =?us-ascii?Q?m+576LN6x8pIx2mhdwbIi+l0h+6T4Y9AKG0ZU+eeWYuATHxT5vCeGUu9UBd5?=
 =?us-ascii?Q?JDGp7KQg/87pDW3rJozb8uOIQvXJmYBvlDC2E1E56AS/cUjHM8hjOSD2osxW?=
 =?us-ascii?Q?zUi3parpCB+ec7mJte4cXBdXwUpBCGgTz6/xYrs8QXg5Wx6NxEoAfjnkrJ0z?=
 =?us-ascii?Q?Ddr+Ck3BlR0WnjE6B8iDwqQbsSGkMl1+IkBZAzd3G+1VyVG2SZGY/5ShYRkg?=
 =?us-ascii?Q?oZp140rSb3lliykCcOHVJRoxiy3+fb9ILaKxx4buJzCznI+yg1NP6LkuaMfX?=
 =?us-ascii?Q?hRsftzQSZeRSXHXbKLIWEYVtQjbBEn6g3LvCl/X4uxtUMuSObTWzCp+8ZieP?=
 =?us-ascii?Q?Qwy08ZXUqD9XI8oxBAPHPZXYjI+pwXkUBc99ck4su5dW+e9K0mZemXZj0peA?=
 =?us-ascii?Q?ntWEKmvoEDJV/kh8jvDB6vHcDSSgm1dnwXLHf1RMoyq4xTlI/fQgMk4flE2J?=
 =?us-ascii?Q?ki4mm0pZwfeSud/RbJs9hdaLvZYIcZW/MDbghr2akzOZ38i+ikt1XEn4Jq2a?=
 =?us-ascii?Q?BpcsdH5ga77GfnxkGU4GTHgDZKWib6TXVOJrZo2LMZdsm3l7phGGl5v1vgO+?=
 =?us-ascii?Q?RE+gdKFFIC6FUVxj8YVgLO6hsZ3FGSDNjNHhhIz2++kC1zeGlJjAeRhzGIMx?=
 =?us-ascii?Q?1wRzJJ9i3otQvcT82kKamSaWzxr8lRXG4FH+kNWONYw5tbOhb+0lJIWS0nDK?=
 =?us-ascii?Q?h4lHZ4KjdKVVWEv1BdnhGiDSp2x6pS06xG+OpeF/+esOhvLWl3KtpJ6/aC8L?=
 =?us-ascii?Q?e/F4D6RZ7nhLSgD+yY+n5qrgFNKSW4VuIrGCXhfiZVtTY/CP1lwdrVxhSgpD?=
 =?us-ascii?Q?agw50RhzbgGJn65Wyqz1HJJ3nIpWHsS5CgBctdbJHxK2S5KylYVtf7KOP4jO?=
 =?us-ascii?Q?bkR0QlReqESS3VgC3nNsFz96F/i88yq9VdW4mcDRpCERiUfmc1QHDQnpvpp8?=
 =?us-ascii?Q?PVYQfxJdyBd3AER7x2SmcH3q5a6crq/gB8s1og/B4HTGFlpT6a3zkldYVozf?=
 =?us-ascii?Q?52mCE84dTeNwJZ2Dhk3HW/9MysrgDtTMKGlhH83w3eOOHs1I6CNBEezxduMe?=
 =?us-ascii?Q?m+86cQCnPgFSnUCUQpuvbCS2m4lzyTRGWiL3OBwdaZqga+LJPXhSpFdrCFsh?=
 =?us-ascii?Q?6ODq1z8h+IANMTsUEHJN3eekOOeqrMqmWcf2kCwclSVTLAvzNMIrpmqkY8I+?=
 =?us-ascii?Q?o10m5z9dtG+/ytIPMqj0WIkk4kKB8+979B3X76gWlJiuRESWQZeECkb5t7wD?=
 =?us-ascii?Q?5V0EiMJk0Eq0bMXyD5rhPGb/1e37v61YJ6ZOH4smAyW0o7gf/fGfXL3kTdhy?=
 =?us-ascii?Q?og3/NUWjXotYcvAsiBy2VZAYfYeLC6UtaTmh2Aui20jNffkRv1whspfKDitD?=
 =?us-ascii?Q?TsoNKbJg273mBWJSndg2BPwK4dG1+m1t7gVimG3xrodsieL24aC58UeyIDDE?=
 =?us-ascii?Q?pcq4AdkEKbfcw5XPCLffpr3rk91Z70CFbWQl5cVT?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ac5933cd-492c-40b8-0750-08dc165367f4
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB2743.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jan 2024 05:24:26.3505
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: sSYm8nAcy4SIZ5ywD5aKEJHUH4a4+wufWseGUZX79xhX8GEZf+fMdLh3hvRzr93YXSjLi90r5bBDQnVZCqYpjQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB8054

On Mon, 15 Jan, 2024 21:15:15 +0000 <ankita@nvidia.com> wrote:
> From: Ankit Agrawal <ankita@nvidia.com>
>
> Add a helper function to determine an overlap between two ranges.
> If an overlap, the function returns the overlapping offset and size.
>
> The VFIO PCI variant driver emulates the PCI config space BAR offset
> registers. These offset may be accessed for read/write with a variety
> of lengths including sub-word sizes from sub-word offsets. The driver
> makes use of this helper function to read/write the targeted part of
> the emulated register.
>
> This is replicated from Yishai's work in
> https://lore.kernel.org/all/20231207102820.74820-10-yishaih@nvidia.com
>
> Signed-off-by: Ankit Agrawal <ankita@nvidia.com>
> Tested-by: Ankit Agrawal <ankita@nvidia.com>
> ---
>  drivers/vfio/pci/vfio_pci_config.c | 28 ++++++++++++++++++++++++++++
>  include/linux/vfio_pci_core.h      |  6 ++++++
>  2 files changed, 34 insertions(+)
>
> diff --git a/drivers/vfio/pci/vfio_pci_config.c b/drivers/vfio/pci/vfio_pci_config.c
> index 7e2e62ab0869..b77c96fbc4b2 100644
> --- a/drivers/vfio/pci/vfio_pci_config.c
> +++ b/drivers/vfio/pci/vfio_pci_config.c
> @@ -1966,3 +1966,31 @@ ssize_t vfio_pci_config_rw(struct vfio_pci_core_device *vdev, char __user *buf,
>  
>  	return done;
>  }
> +
> +bool range_intersect_range(loff_t range1_start, size_t count1,
> +			   loff_t range2_start, size_t count2,
> +			   loff_t *start_offset,
> +			   size_t *intersect_count,
> +			   size_t *register_offset)
> +{
> +	if (range1_start <= range2_start &&
> +	    range1_start + count1 > range2_start) {
> +		*start_offset = range2_start - range1_start;
> +		*intersect_count = min_t(size_t, count2,
> +					 range1_start + count1 - range2_start);
> +		*register_offset = 0;
> +		return true;
> +	}
> +
> +	if (range1_start > range2_start &&
> +	    range1_start < range2_start + count2) {
> +		*start_offset = 0;
> +		*intersect_count = min_t(size_t, count1,
> +					 range2_start + count2 - range1_start);
> +		*register_offset = range1_start - range2_start;
> +		return true;
> +	}
> +
> +	return false;
> +}
> +EXPORT_SYMBOL_GPL(range_intersect_range);

If this function is being exported, shouldn't the function name follow
the pattern of having the vfio_pci_core_* prefix like the rest of the
symbols exported in this file. Something like
vfio_pci_core_range_intersect_range?

--
Thanks,

Rahul Rameshbabu