DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:to:subject:mime-version:content-type:content-transfer-encoding:content-disposition;
        b=AH/ADN9TNyjiTrbts39NHUTDEhrUxbbW5pxz5eq1t4MQfPkSC3+aEpU3zk7Z1eb98BkH7OCLTXTEH9Dwjfrqarch2hqimLCZml4Gq8TtAFcQMYYXXOjiwGuv2NfXlarfuf1+GpmNVILxRzA+dJhrq6g6aS8RSMGp1XNhrluD0Ug=
Message-ID: <b70f2f960712131614u7515f0fcxf17d9791eb33c5eb@mail.gmail.com>
Date: Fri, 14 Dec 2007 03:14:14 +0300
From: "Mikhail Kshevetskiy" <mikhail.kshevetskiy@gmail.com>
To: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Option to disable AMD C1E (allows dynticks to work)
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 941
Lines: 24

Hello Eduard-Gabriel,

You write:

> +	  dynamic ticks to work. It's safe to enable this option even if
> +	  your system doesn't have an AMD CPU (there are no side-effects if
> +	  such a CPU isn't detected).

It's definitely not safe. There are the computers with totally broken
BIOSes, they setup C1e flags  for one core only. If you try to disable
C1e on such machine, you most likely kill the kernel.

>From my point of view, you patch should work in both directions, i.e.
1) user should be allowed to force disable C1e for all cores.
2) user should be allowed to force enable C1e for both cores.

and if the user don't use this flag, the C1e state should be untouched.

Mikhail Kshevetskiy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/