Received-SPF: pass (google.com: domain of linux-kernel+bounces-27068-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <cbdc15a7-f0f8-472c-ae24-178037b99da6@intel.com>
Date: Tue, 16 Jan 2024 08:24:10 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 27/42] drivers/scsi/isci: Convert snprintf to sysfs_emit
Content-Language: en-US
To: Li Zhijian <lizhijian@fujitsu.com>, <linux-kernel@vger.kernel.org>
CC: "James E.J. Bottomley" <jejb@linux.ibm.com>, "Martin K. Petersen"
	<martin.petersen@oracle.com>, <linux-scsi@vger.kernel.org>
References: <20240116041129.3937800-1-lizhijian@fujitsu.com>
 <20240116045151.3940401-1-lizhijian@fujitsu.com>
 <20240116045151.3940401-25-lizhijian@fujitsu.com>
From: Artur Paszkiewicz <artur.paszkiewicz@intel.com>
In-Reply-To: <20240116045151.3940401-25-lizhijian@fujitsu.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q3RFYTBjWmR3SlhEdjdxL3l3V21sTW9aaVFXN3pLM3BWbmVWY0l4RnE4RENC?=
 =?utf-8?B?QTkzbTVtSnhkQUdONTdYTlNjWlRoL0pHRkkxV1djV08vQ2NOUXNleU5Oc0sy?=
 =?utf-8?B?SnVITVNLaUZ4aS9oTFRYVnNUVjB1RGFCRU1QU1grZGMvZi8wODRxMnNaa2lO?=
 =?utf-8?B?dFBnZjFsb3U2NUZiKzI2K3VhenVCSk1UZDh6VlQ2R1VjTExtWFZ2cTdHczUy?=
 =?utf-8?B?UGZPR1g1V1NsbXBpK1NVYVhvNkNkcHdFb1lwazlvTm03SmN4RkppUkplbXFM?=
 =?utf-8?B?SzBuU0NwK0ZkYmUyQ2laZFVzdzIxaGpvWGdKR0hpUHkvVy94UTMwRDU3MjRv?=
 =?utf-8?B?S0UyWlRwdG5SejR2K0V5RURSaVF1UFo5cVYvaS9uNVBzcHBFb2JmdEVZQVVN?=
 =?utf-8?B?MU9RaW4rYUxWd3FxekQ4MGU5cDEvRDQ1RFdySUsvM3JWdVIzUXh6MThuaUVD?=
 =?utf-8?B?bWxacGpkTndFV1lTQlhFdUQxVGE0aWlwWEM0dXNkOUU2NWFhOXE4NHl6SVV0?=
 =?utf-8?B?SHZmMFJRR2JWNXhBTkN3L1Z6MFJ6SllxQklIZ2xMV21PWUN4bGJHN1VlcURU?=
 =?utf-8?B?ZU96TkRvOWl6QjY4YWd6cGVCY2kxWUlwOEZaRm1ieW9RcWs1amt3Zm9SQUlB?=
 =?utf-8?B?SW5zbGYyY3ZlQ2VPK3pheUhTSWtHTzA1cGZhSUcwbGFQd2liYWhpeC9pREp6?=
 =?utf-8?B?eEgyNkpDUkRxZVpuZFRsNkZmSW9hTGpaVGFXbnRmRnd3czFRN1hvRUlmeVd3?=
 =?utf-8?B?L0N4K0NQR1JHWHRzdTRnblo3WTI0YUJEaDNqK3EvN0ZicFJQTFBzWmdoRmpN?=
 =?utf-8?B?MEJKWExDc1JmWW4xT2dlNVJzMHlaVW1FWEtjZWNzdmpQaWJhUXVyNkNBME9L?=
 =?utf-8?B?eExFdE9rTEhhRkxuQmNmb0JaSFBZTGVFYWxkeTd6bWJSZ3FGZDd1ZFRJREd0?=
 =?utf-8?B?ZkY3b2V4NVl2Z2U0aE5yT0V2Zi9sVVFkN2JPZmZLbUY1c3JxT0o1eXpwNFRL?=
 =?utf-8?B?MlBNdnc2OFpQT3dFVHJqV3RubkpPdmtwa0JYZkNtdkNjOHBHNS92VU00dFZa?=
 =?utf-8?B?WlV4bXg2bjJFTUZQTjBnaCs0a292b0xMelRxVmRsaUFuY05IVmNOR0VmVVBI?=
 =?utf-8?B?K0RjMytadjB4QkcrMy8yUEJHVmhUdVpVUXFwSkNZR3d5VjM3TkZWRkRMWERu?=
 =?utf-8?B?eTZ0SEMzUW5iWGs2TnJMWEQ2aitUSFhERkZTRXBZbXBieWp2em84bjVTUDJ6?=
 =?utf-8?B?T1hpRnhkd3E0NGZGdStleVp6OE9wNmV0R3Z4M1ZUdGV1eHhCdkRGZ2FvT1JE?=
 =?utf-8?B?b1lFZC9TZFJ6cUQxZHdOQVVEdFlBNWZma3BPVWt5U2p2RkR2dGRDWk5hbFhK?=
 =?utf-8?B?Z0Y5dGlMUW1kdCtlV1BXSkZiZzROOVVmci9BVjJWRHE1Y29iYUR3Z0hpay9N?=
 =?utf-8?B?M3dVaXVETzBiQzZuRGgzQlNDUmJqOHpJdUMveG01M2M3Uk5HUHhwWFo3WE9p?=
 =?utf-8?B?MTZvaUU2emhOcy8wcFFRMS9iLzMyN084TFZJTUk4WkpCY2VWdGJFK2NMa3hF?=
 =?utf-8?B?NXdMdUIwNTMxM3VJZ3RUd2Rndk5DUzE5Q2w0K3dYOTNEU2d4ZVVwNVZaTTlK?=
 =?utf-8?B?YmR2MEhSL3BIdlNYZ3p6ZitBVUVJRHpURDcreHNMYS8wUGdMeEZ6SXB5TDN5?=
 =?utf-8?B?Z1oyV1JDMndLWklPU2JmRlNnNzV1TVpUV2JLNXJqRlB1YUw3TVRJRXBUakRL?=
 =?utf-8?B?bHBEL2lpTHhaZFg0dlM3a3Z2TWU4U0xueWpnelJGR2RzTFFpZUdkZ2RFOUpH?=
 =?utf-8?B?eG5ZV2RROWc4K0Q4TEpJZ1N2bXBvNmVMODdoZDhkVTcwOHAyMzNqT0hjU0NW?=
 =?utf-8?B?QlJQZjRIV0NPckRzZmRvMmRVMEd6V3VwRFRPTzBnb2ZhUTFrWW5KM21DVlJ5?=
 =?utf-8?B?UGdJZ0FGL21nTWtXdnVLbVE2bHkrdmRrY2l0YzFzVHJuTS8rQlBYUFdLUnNG?=
 =?utf-8?B?YkFGVis4Y1JYUTQra0JGRjBuNzBrUjlncHlGQ0dQRFRWdWFzOGVKMTlvUGhs?=
 =?utf-8?B?SU9jNmd5aXJsbk8xdU9Fa0VqRnVDcTNiZVJ0NW1NcVQyZVh4ck1pODJVVzdU?=
 =?utf-8?B?djkyZERSd0lTUHV4QlQ0WmYwTUVWbUlQeFRxdFVLa0NaZmU1MVhkZUZ0TkhE?=
 =?utf-8?B?K0E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: c97870fd-7408-4898-9cf7-08dc16642434
X-MS-Exchange-CrossTenant-AuthSource: LV8PR11MB8724.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jan 2024 07:24:14.1409
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: RUEfCHz+khhXGRyJCQ1/4s721Fhmy+nv3958B/BnUsXz+M/zX4F3blNofd8uDE+S93qhJ3E5Zsnbbs9pRflirwjVbay67SCNMnudbllPJQ8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5382
X-OriginatorOrg: intel.com

On 1/16/24 05:51, Li Zhijian wrote:
> Per filesystems/sysfs.rst, show() should only use sysfs_emit()
> or sysfs_emit_at() when formatting the value to be returned to user space.
> 
> coccinelle complains that there are still a couple of functions that use
> snprintf(). Convert them to sysfs_emit().
> 
>> ./drivers/scsi/isci/init.c:140:8-16: WARNING: please use sysfs_emit
> 
> No functional change intended
> 
> CC: Artur Paszkiewicz <artur.paszkiewicz@intel.com>
> CC: "James E.J. Bottomley" <jejb@linux.ibm.com>
> CC: "Martin K. Petersen" <martin.petersen@oracle.com>
> CC: linux-scsi@vger.kernel.org
> Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>

Reviewed-by: Artur Paszkiewicz <artur.paszkiewicz@intel.com>