Received: by 2002:a05:7412:8d09:b0:fa:4c10:6cad with SMTP id bj9csp296808rdb; Mon, 15 Jan 2024 23:44:58 -0800 (PST) X-Google-Smtp-Source: AGHT+IHD6BnjUCHm7K2+eHIXWt3tmbqZyarUHvPK+23qDUY7Gi8r263euAihwOJIwkHBO9Si963F X-Received: by 2002:a17:907:3ea5:b0:a2e:70b4:28b0 with SMTP id hs37-20020a1709073ea500b00a2e70b428b0mr294028ejc.3.1705391098160; Mon, 15 Jan 2024 23:44:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1705391098; cv=none; d=google.com; s=arc-20160816; b=H+J1U4ASIoIJQcWs5FVJq9yp/aOFMT/irMkqNryOWJzsQWK9MjcXz1096ewOACda2A oNQWELw7JJ3UMXfxBq+ifSllZHtGFWIEt4I/Pk5DIRFXVEffFO4FlDwPHCBuxrUKOABX 2ODYvp/Jpp5HVCfEj2QypXGrNLvGMl37cuJewEE7TvdjtMrdavvUf44nLfIBM0jIfQ4P goVzJf1qtm8txvaj03oigmNlNgJjTuDjWNfwYtmTlVoI3B7TczHdYhT4bQbTTA6ocngA IWa0fhMP3VPxNDL/QzUiYNMjs3GPDnFmkWh//2oUhxUW141iojXCprQm52GCmVg2Ior/ N/GA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=GfQbjgBoY0QdWnRrKxS0+HroJWexKyse0pFiOAQkAL4=; fh=nVSpsuRg816vKfLSpwEZjyr5z/nhdVVXTUuXBpCqxp0=; b=m8040EVdPDIkk2+UqXwF95Cwtob5AdFEX8CgwdJcgyTS/lcLCvhb8OQW3KVdDTS0Xo GISJHOCFQAn5XJU7jYYHwRHuBAqdpqlU4YOgg4nxaqDbUE0ssJQ0mX/4c1zI5yaHrD9/ VH0P7lT0iO7A3sJeCKb2W2Qy7zoTgWXJhf5LhUCN8I1JM/m/INB8IXi0hhJcVSy35hWv LNXbPAK0PG8u5aIlgXPX0MVSnodiTWpWhJx8516FZkdkygF9+S4MKx2SUUGwXuD/BBJp WptLeASBweklOsFmnz4wceHiB/vmwJMGX7xczFpgy/xV9oA1Uzi4AiOT8M2+ukd5uSwR 5qVg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@atomide.com header.s=25mailst header.b=p6KPwtwI; spf=pass (google.com: domain of linux-kernel+bounces-27095-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-27095-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id kh11-20020a170906f80b00b00a2ac23652e0si4340412ejb.227.2024.01.15.23.44.58 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jan 2024 23:44:58 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-27095-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@atomide.com header.s=25mailst header.b=p6KPwtwI; spf=pass (google.com: domain of linux-kernel+bounces-27095-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-27095-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id E147C1F24059 for ; Tue, 16 Jan 2024 07:44:57 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A381A111AB; Tue, 16 Jan 2024 07:44:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=atomide.com header.i=@atomide.com header.b="p6KPwtwI" Received: from mail5.25mail.st (mail5.25mail.st [74.50.62.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 576711118B; Tue, 16 Jan 2024 07:44:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=atomide.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=atomide.com Received: from localhost (91-158-86-216.elisa-laajakaista.fi [91.158.86.216]) by mail5.25mail.st (Postfix) with ESMTPSA id 4646160498; Tue, 16 Jan 2024 07:43:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=atomide.com; s=25mailst; t=1705391075; bh=GfQbjgBoY0QdWnRrKxS0+HroJWexKyse0pFiOAQkAL4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=p6KPwtwIvbaX5s0vn8ArVMCEI2mX1yV7niI1V76r3KDv1XHzzaRLkOoZxX/AEs2hL SWghoXb2CCy8YD38pzz+wbgJJxZjJBv2ayud8mCKGtT4Qc04UkCxV+cSDgiOC0vaiZ 5VNkcgebX4GTOWxV71AJj5TtxQEEfsQhUAZF2Hyb4AC4w3CAMdeiQ7bNYg+3wy9EuC wxwbLk7wc+/2Wq2RIuo+zjXLpqom8EArKJjQBL+JXq5G+aaMVJsgOg5OW0UT+tToPn WIy/V6DptJrQcUo3MgSOGGZVOcNrBUxwfeWercSbPQoQytAOpKsmYw/tR19TmuSm3r AB0BfaWOW+XXA== Date: Tue, 16 Jan 2024 09:43:33 +0200 From: Tony Lindgren To: Thomas Richard Cc: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Haojian Zhuang , Vignesh R , Aaro Koskinen , Janusz Krzysztofik , Andi Shyti , Peter Rosin , Vinod Koul , Kishon Vijay Abraham I , Philipp Zabel , Tom Joseph , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-i2c@vger.kernel.org, linux-phy@lists.infradead.org, linux-pci@vger.kernel.org, gregory.clement@bootlin.com, theo.lebrun@bootlin.com, thomas.petazzoni@bootlin.com, u-kumar1@ti.com Subject: Re: [PATCH 01/14] gpio: pca953x: move suspend/resume to suspend_noirq/resume_noirq Message-ID: <20240116074333.GO5185@atomide.com> References: <20240102-j7200-pcie-s2r-v1-0-84e55da52400@bootlin.com> <20240102-j7200-pcie-s2r-v1-1-84e55da52400@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240102-j7200-pcie-s2r-v1-1-84e55da52400@bootlin.com> * Thomas Richard [240115 16:16]: > Some IOs can be needed during suspend_noirq/resume_noirq. > So move suspend/resume callbacks to noirq. So have you checked that the pca953x_save_context() and restore works this way? There's i2c traffic and regulators may sleep.. I wonder if you instead just need to leave gpio-pca953x enabled in some cases instead? Regards, Tony