Received: by 2002:a05:7412:8d09:b0:fa:4c10:6cad with SMTP id bj9csp299364rdb; Mon, 15 Jan 2024 23:53:45 -0800 (PST) X-Google-Smtp-Source: AGHT+IGEED+0ephnOy+wum8VWo9dsbuXR2j7EPxDj1OMJHjeowmru9GS4zHylCTjyoOaaPBRhjFh X-Received: by 2002:a17:903:1104:b0:1d5:63c5:e107 with SMTP id n4-20020a170903110400b001d563c5e107mr9973356plh.3.1705391623715; Mon, 15 Jan 2024 23:53:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1705391623; cv=none; d=google.com; s=arc-20160816; b=ucfxEUisCEoOuMmsU6ZcGXfa6NpRVdUZwwUho/j5xswGNCDdrjxX7W+bSVavJALrSY ZIucJfto5Pa8385B2h1mMDGfrkb/nWnH1gkRFig24I06mj8FC+XxnNNQI+T6SeXKZhrk bSPZa+DlI70UIEDjnIv7w+V4EBKo7lv9k1mSNe4jxL06mC7mxaeHrpT/ypcWUfgN7pSu xSsKj53k14Ops5O+eGhrpxVBrJnS5DZVdd5FOK+2U5RZJwwHvZFFwimwlC/y+l0wO1RZ rY59tKaDEpTB3Jnv7bIYW6UDWmCPs/iYyu1jbI9Kf3aF5BLA0nHm6JTb0PeoViLKkQXA Gs6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:user-agent:date :message-id:organization:from:references:cc:to:subject; bh=fDzaKHo32OnxYD+KQPvhRdY+D94rUXKuZYFGYNUicBA=; fh=zgI5CeaM0jePUiOfnIMDlnhiNpegkFPl+EGZSaCvp0o=; b=Q8vvYPQ3ew89eiPWZxWDKz2W/2ZYhkN6qBgq+BX2jU8ZxwtF5YPeK4xdnnhQmj2mDo NBxhQB/H9Dooi6FnOHrhWK3bLyO4UA0LXqmqWl+ayNRC9jxxmobrxj6R+Tv5Ip4b0P0+ C4L7e1O7CtcoKDZdne6UN0/tGFduDNm86wKYLhyguEY7GDhLv6fdh7krh5EH1O+QtgdP quR75OSzBl0fqhl2p/hOsFDZoIJC1Q3ZP9p3h/L9mEyB8GNn0XxiHy+ZG+RJgnZz/lAr gJcJxTNivKRScV5mdSiCVjet6TwU+HnqjurH0RbeadGduG0m9Yd795gxmwRaz1QkGt1M NLxw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-27100-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-27100-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id k66-20020a633d45000000b005cec9fcfff8si11240217pga.62.2024.01.15.23.53.43 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jan 2024 23:53:43 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-27100-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-27100-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-27100-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id DE6D72851FB for ; Tue, 16 Jan 2024 07:53:42 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id BE858111BE; Tue, 16 Jan 2024 07:53:33 +0000 (UTC) Received: from mx01.omp.ru (mx01.omp.ru [90.154.21.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C2C1E7483; Tue, 16 Jan 2024 07:53:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=omp.ru Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=omp.ru Received: from [192.168.1.105] (31.173.86.62) by msexch01.omp.ru (10.188.4.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.1258.12; Tue, 16 Jan 2024 10:53:12 +0300 Subject: Re: [PATCH v3 2/2] usb: host: xhci-plat: Add support for XHCI_SG_TRB_CACHE_SIZE_QUIRK To: Prashanth K , Greg Kroah-Hartman , Thinh Nguyen , Mathias Nyman CC: Hans de Goede , , , References: <20240116055816.1169821-1-quic_prashk@quicinc.com> <20240116055816.1169821-3-quic_prashk@quicinc.com> From: Sergey Shtylyov Organization: Open Mobile Platform Message-ID: Date: Tue, 16 Jan 2024 10:53:11 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: <20240116055816.1169821-3-quic_prashk@quicinc.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: msexch01.omp.ru (10.188.4.12) To msexch01.omp.ru (10.188.4.12) X-KSE-ServerInfo: msexch01.omp.ru, 9 X-KSE-AntiSpam-Interceptor-Info: scan successful X-KSE-AntiSpam-Version: 6.1.0, Database issued on: 01/16/2024 07:33:55 X-KSE-AntiSpam-Status: KAS_STATUS_NOT_DETECTED X-KSE-AntiSpam-Method: none X-KSE-AntiSpam-Rate: 59 X-KSE-AntiSpam-Info: Lua profiles 182664 [Jan 16 2024] X-KSE-AntiSpam-Info: Version: 6.1.0.3 X-KSE-AntiSpam-Info: Envelope from: s.shtylyov@omp.ru X-KSE-AntiSpam-Info: LuaCore: 7 0.3.7 6d6bf5bd8eea7373134f756a2fd73e9456bb7d1a X-KSE-AntiSpam-Info: {rep_avail} X-KSE-AntiSpam-Info: {Tracking_from_domain_doesnt_match_to} X-KSE-AntiSpam-Info: {relay has no DNS name} X-KSE-AntiSpam-Info: {SMTP from is not routable} X-KSE-AntiSpam-Info: {Found in DNSBL: 31.173.86.62 in (user) b.barracudacentral.org} X-KSE-AntiSpam-Info: 127.0.0.199:7.1.2;d41d8cd98f00b204e9800998ecf8427e.com:7.1.1;omp.ru:7.1.1 X-KSE-AntiSpam-Info: ApMailHostAddress: 31.173.86.62 X-KSE-AntiSpam-Info: {DNS response errors} X-KSE-AntiSpam-Info: Rate: 59 X-KSE-AntiSpam-Info: Status: not_detected X-KSE-AntiSpam-Info: Method: none X-KSE-AntiSpam-Info: Auth:dmarc=temperror header.from=omp.ru;spf=temperror smtp.mailfrom=omp.ru;dkim=none X-KSE-Antiphishing-Info: Clean X-KSE-Antiphishing-ScanningType: Heuristic X-KSE-Antiphishing-Method: None X-KSE-Antiphishing-Bases: 01/16/2024 07:39:00 X-KSE-Antivirus-Interceptor-Info: scan successful X-KSE-Antivirus-Info: Clean, bases: 1/16/2024 5:28:00 AM X-KSE-Attachment-Filter-Triggered-Rules: Clean X-KSE-Attachment-Filter-Triggered-Filters: Clean X-KSE-BulkMessagesFiltering-Scan-Result: InTheLimit On 1/16/24 8:58 AM, Prashanth K wrote: > Upstream commit bac1ec551434 ("usb: xhci: Set quirk for > XHCI_SG_TRB_CACHE_SIZE_QUIRK") introduced a new quirk in XHCI It's xHCI. :-) > which fixes XHC timeout, which was seen on synopsys XHCs while xHC. > using SG buffers. Currently this quirk can only be set using > xhci private data. But there are some drivers like dwc3/host.c > which adds adds quirks using software node for xhci device. Double "adds". > Hence set this xhci quirk by iterating over device properties. > > Cc: # 5.11 > Fixes: bac1ec551434 ("usb: xhci: Set quirk for XHCI_SG_TRB_CACHE_SIZE_QUIRK") > Signed-off-by: Prashanth K [...] MBR, Sergey