Received: by 2002:a05:7412:8d09:b0:fa:4c10:6cad with SMTP id bj9csp302704rdb; Tue, 16 Jan 2024 00:02:34 -0800 (PST) X-Google-Smtp-Source: AGHT+IEe5y1anRvYOotjxkR+8RiEQblS5y5AvN6uJtktWDiB+QEP6tvu9o/2Ldmb9Keiww2Stczs X-Received: by 2002:a17:90a:70cc:b0:28e:785c:f5d8 with SMTP id a12-20020a17090a70cc00b0028e785cf5d8mr347073pjm.91.1705392153781; Tue, 16 Jan 2024 00:02:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1705392153; cv=none; d=google.com; s=arc-20160816; b=g7KKXFd5qJDRpv4GbukrqITRKh2IzmpiHYdZvnk7gdEby1glkE5XLru/ywiuE/xs4b JUrZjsAXQ0F3t7LSBZLwzm/Vvf0ND7HgrmL+qa07IjIVmtDPW81hzHjP5DIqPUicSPF5 3/a5tUt3CPEgfRII8Hk47VRfH1vcmm0bpHQqekT+k0SccjbBxwRpN65C13hMK/Z48mfI wmFJcbjJyaOFC8PQctNJ4p6EX8jDobXHXxGb3iqgYJgrTk6IbmceauVFwKjKVok8+GiP 9Kt8PAygMTyKpOH208N1XeSmpF8FK9pXj1hL9H9lbuQ5x6ZoipWxg+y2ajHSzG3XE137 rmJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=NL23Q2dzCrL2FMxHkdzZLfHW4z9DaWE9nArGIw2YM7k=; fh=fokfHV8Ru7fra8ObDBfdQgIgOGSVAYRNpKvw9xio4Ac=; b=LqpE6WTFruHa43HZyzZxN8XhM2LWU8Qd18zdRJ4WJwUX0Fkp4PV2ylmIikZjk9WRPv K4YRvZYoac4qp2doAeFLJb1kj7v+LSeV7XOGEWaDQifQZ9JhjvQ8cVMEVgHHsEoZByXd xpyEWfZl5tFOMPESEFbyhGqncceJ18FV6i3NzOU4hhnH0LEhjiVLzhycbI4nOSpJW2S6 xkWYEHcTPknyIb8Mns/pwmUo6RjNQPb7tAwZ/n0hUuEvei7geu1I6GlFlFT0PJ2KafWH Doy3cbYezy0fuUyJ9pkq5vPCIV3cVEoLIvxkP0o50Iq7GFvKJg0mgtxdnpUAr28MivV0 IRjw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=eMOKEMUi; spf=pass (google.com: domain of linux-kernel+bounces-27109-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-27109-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id bk23-20020a17090b081700b0028c0bd5a278si13089859pjb.163.2024.01.16.00.02.33 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jan 2024 00:02:33 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-27109-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=eMOKEMUi; spf=pass (google.com: domain of linux-kernel+bounces-27109-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-27109-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 4619EB229A7 for ; Tue, 16 Jan 2024 08:02:32 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 92C3B11724; Tue, 16 Jan 2024 08:02:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="eMOKEMUi" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 995ED11C8B; Tue, 16 Jan 2024 08:02:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B3284C433F1; Tue, 16 Jan 2024 08:02:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1705392139; bh=tqwbL1wZkG3eopT8VYrtB5JmEZOy13U2Fa2XVhrTzMI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=eMOKEMUi3jOrrd/RBoQXAkwTU0BKtsRJZoCSu0nhf/bbvq8+nhkZbr38HgA7sXhQU 5Dy2ghEEtpeO5dzLb2mNIG4Z+ECEfL2AMt3URPulliNgRwVjHwBj91IBzHCcunU/ny rjs95bHVkhzm0feiL+Y4BjbB4a2kX+sW5MoTJIdE= Date: Tue, 16 Jan 2024 09:02:15 +0100 From: Greg Kroah-Hartman To: Sergey Shtylyov Cc: Prashanth K , Thinh Nguyen , Mathias Nyman , Hans de Goede , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v3 2/2] usb: host: xhci-plat: Add support for XHCI_SG_TRB_CACHE_SIZE_QUIRK Message-ID: <2024011619-equate-polar-aa2a@gregkh> References: <20240116055816.1169821-1-quic_prashk@quicinc.com> <20240116055816.1169821-3-quic_prashk@quicinc.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Jan 16, 2024 at 10:53:11AM +0300, Sergey Shtylyov wrote: > On 1/16/24 8:58 AM, Prashanth K wrote: > > > Upstream commit bac1ec551434 ("usb: xhci: Set quirk for > > XHCI_SG_TRB_CACHE_SIZE_QUIRK") introduced a new quirk in XHCI > > It's xHCI. :-) > > > which fixes XHC timeout, which was seen on synopsys XHCs while > > xHC. > > > using SG buffers. Currently this quirk can only be set using > > xhci private data. But there are some drivers like dwc3/host.c > > which adds adds quirks using software node for xhci device. > > Double "adds". I know I have said this before, but please don't be so pedantic at times, it's just not helpful at all. All of these are just fine to ignore. thanks, greg k-h