Received-SPF: pass (google.com: domain of linux-kernel+bounces-27115-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <ba5a88d7-0cd3-4f9c-aae9-beeb7d64dbaa@linux.dev>
Date: Tue, 16 Jan 2024 16:09:42 +0800
Precedence: bulk
MIME-Version: 1.0
Subject: Re: [PATCH v3 2/7] hugetlb: split hugetlb_hstate_alloc_pages
Content-Language: en-US
To: Muchun Song <muchun.song@linux.dev>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
 David Hildenbrand <david@redhat.com>, David Rientjes <rientjes@google.com>,
 Mike Kravetz <mike.kravetz@oracle.com>,
 Andrew Morton <akpm@linux-foundation.org>,
 Tim Chen <tim.c.chen@linux.intel.com>, ligang.bdlg@bytedance.com,
 Gang Li <gang.li@linux.dev>
References: <20240102131249.76622-1-gang.li@linux.dev>
 <20240102131249.76622-3-gang.li@linux.dev>
 <2ae5ec3f-4a96-4819-af65-5f04df0c2ebd@linux.dev>
From: Gang Li <gang.li@linux.dev>
In-Reply-To: <2ae5ec3f-4a96-4819-af65-5f04df0c2ebd@linux.dev>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 2024/1/16 15:02, Muchun Song wrote:
> On 2024/1/2 21:12, Gang Li wrote:
>> hugetlb_hstate_alloc_pages_gigantic(struct hstate *h)
> 
> The name is so long, how about hugetlb_gigantic_pages_alloc_boot?
> 
>> hugetlb_hstate_alloc_pages_non_gigantic(struct hstate *h)
> 
> hugetlb_pages_alloc_boot?
LGTM.

> It it unnecessary to reverse the condition. A little sime like following:
> 
> if (hstate_is_gigantic(h))
>     /* gigantic pages */
> else
>     /* normal pages */

Will take it in next version.