Received-SPF: pass (google.com: domain of linux-kernel+bounces-27199-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <2b715134-9d63-4de1-94e5-37e180aeefd2@amd.com>
Date: Tue, 16 Jan 2024 10:45:46 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] drm/ttm: only use DMA32 if needed for dummy_read_page
Content-Language: en-US
To: Yangyu Chen <cyy@cyyself.name>, dri-devel@lists.freedesktop.org,
 linux-kernel@vger.kernel.org
Cc: Huang Rui <ray.huang@amd.com>,
 Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
 Maxime Ripard <mripard@kernel.org>, Thomas Zimmermann <tzimmermann@suse.de>,
 David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
 Jiuyang Liu <liu@jiuyang.me>, Yichuan Gao <i@gycis.me>
References: <tencent_0B319B215E8D487CC082C0DA5E8E46B86B08@qq.com>
From: =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>
In-Reply-To: <tencent_0B319B215E8D487CC082C0DA5E8E46B86B08@qq.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?S0dtWEdtc2FsOWRUUVlpQW1LNU15b3NhUW52c1lMVy9GOGhZT3hXRGFSQ2E2?=
 =?utf-8?B?RkFZRDd1NVhvWlBoQmZqRWYvRHpBVnVNUXBlV2oyWmRvNkw4NllvY21pbmVE?=
 =?utf-8?B?NVozOUtmQnUxZnJJcGFja0xEeEdjYzFXWjh4ME5NU1ZLeExTNFZYcmJnMkY5?=
 =?utf-8?B?Vm5jT2tRamZaWXBtUVhwU3NrWjRzRUhXMVk0eXl5NktYNTZLcG1LeTZYeTZC?=
 =?utf-8?B?SzlFRFFJaGU2aUY1NzVaSkdoTE1OV3g2eU9oMktkY1kvQXBUU1VxUlplV2Ja?=
 =?utf-8?B?SUVPVlRGWG14OFA3NWpORE9INnZlaytVc1hqU01YMGIxZG1xL0xnTGJicGNW?=
 =?utf-8?B?V0o5Lzk2VVg2R2RscG9tN0dNM3dNYnc1dFAwR0c5OXhyb1E3TCtiTk45blgw?=
 =?utf-8?B?ZTJnSnZqb0dzWW0vZG9qanl0bWY1WGpqelkreDU1ay9RSHhPMGFwMUdZSnNZ?=
 =?utf-8?B?Wkp4MUtTQXExZ1BVVFlBMjhud2UvNFYybzl4eDhhUEpWbEtxdHFMM0h3RlVr?=
 =?utf-8?B?MU04QkNjcVI3c1c4M3ZEdXFCdldscVNQQlJQalFjcEdRbE1Wby9ESUhZVDJL?=
 =?utf-8?B?WFNyS1pwaHBxMzI0SThYWDlONnd0bnRFbWFMSllhK1lVZGh1VkhaV2ZiUFZH?=
 =?utf-8?B?SlFid2tnYk5CYmRyYmNvL2h5UmlGY0RmaFU0cmRFLy9HblQwNTNOeUJFQTJk?=
 =?utf-8?B?NlZTM0JNL29tTWFqTStoNjc0OGFaSkNKV1FJUjR2c2RSb1JsRlpqK0RkZVdZ?=
 =?utf-8?B?K2VEVjJVclJXdHB0UGlzUkRXaWFLcFRZSWt0WVRERFhkNmIrUE1YTUNZM0Zi?=
 =?utf-8?B?allVU1paVlFQQW1JSEFVeks1RmVjbnpMaDBSdFp0R0dGRjBPbEtHYUNPNmRo?=
 =?utf-8?B?SlZIYWRCUmpCbTl4NlFYTVZTMWNadGNwNlZFdkxTNC8rc2dLSi9NL3hlTk5z?=
 =?utf-8?B?c2hXM0JqNXExbmc0SHRNKzZEamJZZkFyOTNudDJJQWEwazZEeUlYTXIyK04w?=
 =?utf-8?B?bStDSmhQdThFSDlENzZRSC9lTDkxbTBFeW5hckE1VnFrNFFDYllhWTNPT3JZ?=
 =?utf-8?B?K3RQZWs5b2hyTklBU2VsR2wvRFdyb1ducHlIbWJPcEg2NGVhbkhlN1k1MStj?=
 =?utf-8?B?TEdZR2YzSzYxbUl1ZStXVUNXNy9OL2NnUmplS2YwMXhtajZNbld2VzhadW10?=
 =?utf-8?B?aWMrZHBaZk9vdm1qUXh4S0hWT2R1c1NVLzVCeXZKQ2VHQmVmMy9OZlZqcngx?=
 =?utf-8?B?c1EwbTl5RUlSb1Qvak5UcWtqUUlJazExNGYrdTlQY0NhQ0puOFp6TWpmTFR3?=
 =?utf-8?B?WTh0LzF5RkRyYnU2SnoxckllaGd0cnExYlNNekpoYmM2VzBuemtjNmVTL1RG?=
 =?utf-8?B?WVRtWWZtMFRqektzbWdub1l2SmJ2Wm1TWHVRNmM2a3ZBYitQSTB3UnhBUkVW?=
 =?utf-8?B?MzBMZEo0aWIzSHVXV1hJZkNSL2dMbEdFcDVSankzbW9IWUlQTlBsNzByTkZt?=
 =?utf-8?B?SGdIYThGWmk2MzFSZmRjcFVrNmlSb1Y3eks4a1htSWR3TytIbWQ0UmgzVTFG?=
 =?utf-8?B?dGNkWE42dSszamt4aDJvRFNLM1hPS2hZMUZRK3pncFVESzU4UVhiazh6L3Zm?=
 =?utf-8?B?eW9oQ2pCb2lubXZvVWRoTlNnR3djZ2lpQ0JmaXpiNEt3MlpDNGtNR2FCdDMv?=
 =?utf-8?B?ZG9TUldrSlRPNTNuc3orckdIY21RNHZRN2FmY1dIbXUyQ1RoV2hwRjhCN3N2?=
 =?utf-8?B?TWRJV1BFSVRmZGdxc0hybzdXLzEyS2lFdUZpN1hQZ3BuM3NGSEFYTE9hWnFH?=
 =?utf-8?B?c0hJUklydjlPbXhoTVArWDgyY2ZsN3pUT0l4WWZONzZGSFE0ZnVhZzAwTXhr?=
 =?utf-8?B?VVkvVDFWT01IRmpPRkZiZi9VSWFmalovMnpLVDFFNU1SR1ZabnFzSy93amY3?=
 =?utf-8?B?ZDRJczZ4OHZobnJ5ckUvT0Z4VWhiSDNrSmpYL1llQXdOWmdVQ3NBTnZWUGRq?=
 =?utf-8?B?ZU1DM2JlVzVuTDZwczZXMnJ3aC9IcTkxUi9XZ2o2VTE2akdJcjNKZ0NXNmV5?=
 =?utf-8?B?S3hNbTdkalppNE5haExCUEVpNnJIMWp3Vy9nbzVaUEJxVm5pU0RQdG1UODVy?=
 =?utf-8?Q?skAYzO6oZZVoe09hx6U7hikH2?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6a29006f-f3f3-4076-fa0c-08dc1677ee5f
X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB5685.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jan 2024 09:45:53.6875
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: GMYgsOa2FXtmK5F/m6mOuf1R27qr9tH0DSonyj19EHPyWTh7BK5tTSZ4XB5WFWs9
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6181

Am 16.01.24 um 08:24 schrieb Yangyu Chen:
> Some platforms may not have any memory in ZONE_DMA32 and use IOMMU to allow
> 32-bit-DMA-only device to work. Forcing GFP_DMA32 on dummy_read_page will
> fail in such platforms. Only use DMA32 when it must to get the bug
> resolved.

Well that makes no sense.

If a platform doesn't have a ZONE_DMA32 then GFP_DMA32 is just ignored 
as far as I know.

This patch here won't work since the use_dma32 flag is a per device flag 
which can't be used for the global initialization.

Otherwise this can randomly fail depending on if a DMA32 device 
initializes first or after some device with larger addressing 
capabilities. This configuration is quite common on older motherboards 
with both integrated and dedicated graphics.

Regards,
Christian.

>
> Signed-off-by: Yangyu Chen <cyy@cyyself.name>
> ---
>   drivers/gpu/drm/ttm/ttm_device.c | 7 ++++---
>   1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/ttm/ttm_device.c b/drivers/gpu/drm/ttm/ttm_device.c
> index d48b39132b32..62f16fb72428 100644
> --- a/drivers/gpu/drm/ttm/ttm_device.c
> +++ b/drivers/gpu/drm/ttm/ttm_device.c
> @@ -63,7 +63,7 @@ static void ttm_global_release(void)
>   	mutex_unlock(&ttm_global_mutex);
>   }
>   
> -static int ttm_global_init(void)
> +static int ttm_global_init(bool use_dma32)
>   {
>   	struct ttm_global *glob = &ttm_glob;
>   	unsigned long num_pages, num_dma32;
> @@ -95,7 +95,8 @@ static int ttm_global_init(void)
>   	ttm_pool_mgr_init(num_pages);
>   	ttm_tt_mgr_init(num_pages, num_dma32);
>   
> -	glob->dummy_read_page = alloc_page(__GFP_ZERO | GFP_DMA32);
> +	glob->dummy_read_page = use_dma32 ? alloc_page(__GFP_ZERO | GFP_DMA32) :
> +					    alloc_page(__GFP_ZERO);
>   
>   	if (unlikely(glob->dummy_read_page == NULL)) {
>   		ret = -ENOMEM;
> @@ -200,7 +201,7 @@ int ttm_device_init(struct ttm_device *bdev, const struct ttm_device_funcs *func
>   	if (WARN_ON(vma_manager == NULL))
>   		return -EINVAL;
>   
> -	ret = ttm_global_init();
> +	ret = ttm_global_init(use_dma32);
>   	if (ret)
>   		return ret;
>