Received-SPF: pass (google.com: domain of linux-kernel+bounces-27257-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Tue, 16 Jan 2024 11:38:42 +0100
From: Jan Kara <jack@suse.cz>
To: Kunwu Chan <chentao@kylinos.cn>
Cc: viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] buffer: Use KMEM_CACHE instead of kmem_cache_create()
Message-ID: <20240116103842.g2dxbqno2owkuaqt@quack3>
References: <20240116091137.92375-1-chentao@kylinos.cn>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240116091137.92375-1-chentao@kylinos.cn>

On Tue 16-01-24 17:11:37, Kunwu Chan wrote:
> Use the new KMEM_CACHE() macro instead of direct kmem_cache_create
> to simplify the creation of SLAB caches.
> 
> Signed-off-by: Kunwu Chan <chentao@kylinos.cn>

Sure. Feel free to add:

Reviewed-by: Jan Kara <jack@suse.cz>

								Honza

> ---
>  fs/buffer.c | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/fs/buffer.c b/fs/buffer.c
> index d3bcf601d3e5..9c8156cce9b7 100644
> --- a/fs/buffer.c
> +++ b/fs/buffer.c
> @@ -3121,12 +3121,8 @@ void __init buffer_init(void)
>  	unsigned long nrpages;
>  	int ret;
>  
> -	bh_cachep = kmem_cache_create("buffer_head",
> -			sizeof(struct buffer_head), 0,
> -				(SLAB_RECLAIM_ACCOUNT|SLAB_PANIC|
> -				SLAB_MEM_SPREAD),
> -				NULL);
> -
> +	bh_cachep = KMEM_CACHE(buffer_head,
> +				SLAB_RECLAIM_ACCOUNT|SLAB_PANIC|SLAB_MEM_SPREAD);
>  	/*
>  	 * Limit the bh occupancy to 10% of ZONE_NORMAL
>  	 */
> -- 
> 2.39.2
> 
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR