Received-SPF: pass (google.com: domain of linux-kernel+bounces-27268-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: "Miclaus, Antoniu" <Antoniu.Miclaus@analog.com>
To: "alexandre.belloni@bootlin.com" <alexandre.belloni@bootlin.com>
CC: "linux-rtc@vger.kernel.org" <linux-rtc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 1/2] rtc: max31335: remove unecessary locking
Thread-Topic: [PATCH 1/2] rtc: max31335: remove unecessary locking
Thread-Index: AQHaSAm3Idf2yZ58R06bqymzr3MH47DcQiHg
Date: Tue, 16 Jan 2024 10:47:04 +0000
Message-ID: 
 <CY4PR03MB3399960604BF0CAAA108231F9B732@CY4PR03MB3399.namprd03.prod.outlook.com>
References: <20240115232215.273374-1-alexandre.belloni@bootlin.com>
In-Reply-To: <20240115232215.273374-1-alexandre.belloni@bootlin.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?Rhm57EQiACyuFgakwnLZLg2fZ+LHILAIG4GdsRXSBmRYyjOE81BoZBWKIsHW?=
 =?us-ascii?Q?O7J5h9gQ7af2OPj3lyGXFZXaPrMZscfWtZ8WbPh8HJq3lExMu8j9zO3In2OE?=
 =?us-ascii?Q?kz2veaN2SEOStTTZb3N6QUWGI/9cRIo7X2zD9lncA5Cy+Z5GUpFzxo+sOHKf?=
 =?us-ascii?Q?FJJLBmWYyzQvTWG+2r5rhY/UTyEEIIndcfObeMjSVYQN5uyOreSDc+Yxt911?=
 =?us-ascii?Q?JbK6mEnj406y44cp3CnFxLkv2pydUWRnU4ORtFXKR9D6uokGuxHgqSIoPvnd?=
 =?us-ascii?Q?1H0QZLZaDMzSOhOFU4oi0Hl3b3GozseVjlEPnuaQe1gAPeddtSCQmVTgdPGn?=
 =?us-ascii?Q?3AtziPcn+1+cQTzce2sL0CYXFmpDsb4/rc1yct7Z0jjyGeA6LCEC/b876hhp?=
 =?us-ascii?Q?zOyxx6DVKHE9zmTKUXMYRLupw+6ButVq9xiJYzJTfBt6fkRpn6rhZVINQyvQ?=
 =?us-ascii?Q?kvoGXtapWo/NtfLwbkcCGiVJo90VCtw1Pq/rRM1utFCBIcbHxIm1pLtSROjg?=
 =?us-ascii?Q?L0OT2XUDl16iPtpGEnWqnqvJYoADZn2lfoZoFGwH8qcseCYfZjAZ13fWwkkv?=
 =?us-ascii?Q?6/DmJgMNancoMXGGpLB6+qe6iekYNGsaTByI0ZLvckrbJ3+gzBchzqLGyQqj?=
 =?us-ascii?Q?sSQo9Jjc1L4hTy8O04j73OK+ZAvV8RpNG6x1bGA3Q3UrPtevRUIPO3yX5M3h?=
 =?us-ascii?Q?PfV9vRL1Bbo9kWbVPOsbBMuLO6bvZzCgQKo3QNR9vgdBOcDzmUVyjDtB+3Hh?=
 =?us-ascii?Q?RUY4pSzy4jV3b9c22uC5zs5M8solo3NTIDvXZbWHyTa1rD1xg9e7gEklTbUo?=
 =?us-ascii?Q?M3mBgIT9Z+FXVjQlGevgdusgThqvBxmuQpIMCU7LzeORTcsgD+lWAtPlMqcG?=
 =?us-ascii?Q?pQ7angKKxnaH8dTmevsmFMAI9mce+HGpodYo6l6v9wA37JXPoverOO46vJwn?=
 =?us-ascii?Q?JGQwK4SBN1QegkF5c/oLSoKYyjcmTuCQDzZQSHHmU9eV85ZzHUsvUI7ihNmY?=
 =?us-ascii?Q?3ZfRd+dseIkqCpR+1GbcfbEaWb7kDu6Dc3GesvuFSdO2M7plOUnZPciHmMo0?=
 =?us-ascii?Q?cCh790OCK99Wu3FyNiGYGdeIAFk2PxTSppWIdzhpZIhFn0Qha07Tg5j4Hcwr?=
 =?us-ascii?Q?IyOnF6meShkfpFRraICIURIVAmmc+FmYTQicreCF1gzJxcSIMNhaE5MqzYsM?=
 =?us-ascii?Q?RqvD9+aCpI1oc3r3XZfq6h06r1PETBNw+aI8XlLC37FVTJG0xyn+LcVgNx2i?=
 =?us-ascii?Q?H73/Jqx/7PThDdYf5Y6M9dp4zPcY/BtDwATSFZ9MTKm8FVHmhPLjz6BcdxsK?=
 =?us-ascii?Q?LSptYTOTb3VHMtSJsCaQKmVrPPM7c4wMRymiLWrvffFOhXx9CBH1pP3ANQ9H?=
 =?us-ascii?Q?qnVQVAiscCvztBy3NtUTFKEcpjFbf7UnUJiHLTTj64uKxJhKJqq0U1pXHpTk?=
 =?us-ascii?Q?+ZGglB+BZFjsf0i6dRS9olxjTlU/CsvtFxubPY6BO1R42wK9g+B1RYxS/Xdz?=
 =?us-ascii?Q?lbUNIz0jZUu2+NPcUkzfaOc0GXGKV2paZ5WcTHPn6UVf8Av+s0H9px7VinXc?=
 =?us-ascii?Q?RK3b3fcVV/PHLC8mJrrNbip95AwGtB/q9Sf7683diToSONGPYsTGrEHPJXDC?=
 =?us-ascii?Q?L3ldC14yhQLxF18Xspu17OITrEeS5YhoWgzudgwz73HrepZ6nVh6CogYNEQz?=
 =?us-ascii?Q?3Y4bbw=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: analog.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CY4PR03MB3399.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ccba8462-8cd4-4b21-1470-08dc16807a7d
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Jan 2024 10:47:04.5955
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: eaa689b4-8f87-40e0-9c6f-7228de4d754a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: vFYQY2LZKVcrsBLnvDxODuPjuDUPuRPjs53fWuOGE8CETnwFpZQWwyY3ZhHGgH1EyhDqdkHZkO+dKBJbEZkwAviO/X2PaQ+YX9CAho6ZpjU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR03MB6596
X-Proofpoint-GUID: rjZdafs7QZJJUXcrBRyvDlXubLOD4a9i
X-Proofpoint-ORIG-GUID: rjZdafs7QZJJUXcrBRyvDlXubLOD4a9i
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-12-02_01,2023-11-30_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 mlxscore=0
 clxscore=1011 priorityscore=1501 mlxlogscore=942 spamscore=0 adultscore=0
 lowpriorityscore=0 suspectscore=0 impostorscore=0 malwarescore=0
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.19.0-2311290000 definitions=main-2401160085

> From: Alexandre Belloni <alexandre.belloni@bootlin.com>
>=20
> There is no race condition when accessing MAX31335_STATUS1 because it is
> always about clearing the alarm interrupt bit.
>=20
> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Reviewed-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
> ---
>  drivers/rtc/rtc-max31335.c | 14 +++-----------
>  1 file changed, 3 insertions(+), 11 deletions(-)
>=20
> diff --git a/drivers/rtc/rtc-max31335.c b/drivers/rtc/rtc-max31335.c
> index 3ddfe71bbb56..2ce23f60a7f3 100644
> --- a/drivers/rtc/rtc-max31335.c
> +++ b/drivers/rtc/rtc-max31335.c
> @@ -348,27 +348,19 @@ static int max31335_alarm_irq_enable(struct device
> *dev, unsigned int enabled)
>  static irqreturn_t max31335_handle_irq(int irq, void *dev_id)
>  {
>  	struct max31335_data *max31335 =3D dev_id;
> -	struct mutex *lock =3D &max31335->rtc->ops_lock;
>  	int ret, status;
>=20
> -	mutex_lock(lock);
> -
>  	ret =3D regmap_read(max31335->regmap, MAX31335_STATUS1,
> &status);
>  	if (ret)
> -		goto exit;
> +		return IRQ_HANDLED;
>=20
>  	if (FIELD_GET(MAX31335_STATUS1_A1F, status)) {
> -		ret =3D regmap_update_bits(max31335->regmap,
> MAX31335_STATUS1,
> -					 MAX31335_STATUS1_A1F, 0);
> -		if (ret)
> -			goto exit;
> +		regmap_update_bits(max31335->regmap,
> MAX31335_STATUS1,
> +				   MAX31335_STATUS1_A1F, 0);
>=20
>  		rtc_update_irq(max31335->rtc, 1, RTC_AF | RTC_IRQF);
>  	}
>=20
> -exit:
> -	mutex_unlock(lock);
> -
>  	return IRQ_HANDLED;
>  }
>=20
> --
> 2.43.0