Received-SPF: pass (google.com: domain of linux-kernel+bounces-27270-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: "Miclaus, Antoniu" <Antoniu.Miclaus@analog.com>
To: "alexandre.belloni@bootlin.com" <alexandre.belloni@bootlin.com>
CC: "linux-rtc@vger.kernel.org" <linux-rtc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 2/2] rtc: max31335: use regmap_update_bits_check
Thread-Topic: [PATCH 2/2] rtc: max31335: use regmap_update_bits_check
Thread-Index: AQHaSAm2cgwBs+8IIUakAt0fxwHZXLDcQrWQ
Date: Tue, 16 Jan 2024 10:48:06 +0000
Message-ID: 
 <CY4PR03MB33993A5FF5F4B8C27E3DA2939B732@CY4PR03MB3399.namprd03.prod.outlook.com>
References: <20240115232215.273374-1-alexandre.belloni@bootlin.com>
 <20240115232215.273374-2-alexandre.belloni@bootlin.com>
In-Reply-To: <20240115232215.273374-2-alexandre.belloni@bootlin.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?JzCbbdIHDZe3Nw+A/YBChaGw6qLvDEO2xPK+AOp9I0ZezhpY62jLkiRLmgPH?=
 =?us-ascii?Q?uu9PygGRci0ebkyZ1CBzk9Rr2O6rR2RwxzX5l+QboS6Gfhert/t6mWRZ+Brf?=
 =?us-ascii?Q?dJjZYOzRBwEW3OEJEWWmAe2iwbGIOG8rJ7kF0Uln5GnUH+I+3bRCvEfbb3FI?=
 =?us-ascii?Q?FKvdz2pYFgbz9T8gZaxrolzBl4fu352DypuOw9DPALmhgkKUZqmY5TsVK0z/?=
 =?us-ascii?Q?Tve8tN55XXyYO1FkLWOlaW7MgFDCr1EQpKKD6eiNi/xmezBlHzatuTI+HxGO?=
 =?us-ascii?Q?2DeGYf8OFC5zU4rc6YBjw16McA4jbrgkOabmpa26WZ/XDmpNBDMMvlaHcq1A?=
 =?us-ascii?Q?JJ9aYRcxBwx+tyXYkvF/9CVLPt+yJSl/1UnLP4zP9WKZTSEpbM+b6a1dAiG8?=
 =?us-ascii?Q?O0eukLJW97WWNAmucsiPsWNu66TsUx6wkD5mkglHMExZyJBx/mO3RKyUmicP?=
 =?us-ascii?Q?RtY8XhppGG/VK6KL2afjZgJtGNeUg7izfLk2nzLZzfgI9/kLp4Fi+n9yCJ2Q?=
 =?us-ascii?Q?1t7qIx6twPUBewLgvY1pD/xKKGlBIShDcayyqPfFNaHuVxNTj1ET3tG/Bcx5?=
 =?us-ascii?Q?UAvcT4Qgb+7bMrLbgCqliETTLsYDfzb5E8zPs4rBvZD4gxDfFUretorqPFAc?=
 =?us-ascii?Q?8zvyJq4THbeWhHGX9ULZTh523B3rgQLV5NUKlvUDA+k46XmJ1wKHq65pPy//?=
 =?us-ascii?Q?2Mg79T/dmQ4jHTLmLFldMdf2xGJQjCP4Ij2EJcqBQhtTuoCsanQ4QEXIg9uj?=
 =?us-ascii?Q?fEbGkwOpBDTNk2pL8qyuZ54ai3SlqaiCOKNL8C38ImLucwzi0P3Ai/dh1/D7?=
 =?us-ascii?Q?M36730ywQzmIePdWuwHzdLz/UA9lXk/IStdUOZEgfkKTDCKI4QlOwIkbF2JC?=
 =?us-ascii?Q?ADThxXPrnGfnNO1ssJ+IbnaGBSByPdD2x4GlMyvSWzIbP5PPJvmst1SMKE5f?=
 =?us-ascii?Q?Ss8AIWTIU7CRxbymrrauT/4UNpsarQwsch5ODPRZ9J2ixbNSQw5PFJyrTAS2?=
 =?us-ascii?Q?SqESouUS89IpZ6y23poIuiCUHrrx8ZGtC8hlNEwPLawfVGkjYCpuy9JSBD6V?=
 =?us-ascii?Q?iWGuOQicRXJuCK0BElqyXYNQaCvkQCIJxngnHACl/sAxVA394Io82EWy8HsS?=
 =?us-ascii?Q?X5dN/UZrRim1lx0YC/6wangKRoX53CDGCPfMLCW/IidixPVFeuOw1a+4HXXY?=
 =?us-ascii?Q?xDgyWn4nV6NxLCf6yfHQbHPn45RX1NMCohhMWcpFaX43GrjRDpbiw9OPtfde?=
 =?us-ascii?Q?3GWLDU2xWBoMX2HiUDSSgKXx/WcrqJ96Bo7AC5+sxJGDE1yrvYDVmLqgLIhu?=
 =?us-ascii?Q?vgq7N3zhFZPNdP/zv8CCBr/mMZCLGqCmRyxkjYP+rqeTyzdMzrntOdmEoFcZ?=
 =?us-ascii?Q?6paw61KbXUCtj6dBtmEfaDnmLNqtq07cCr7e1SDh9M8G8sTMY2KikaBYLEd3?=
 =?us-ascii?Q?aCunmm6ONV2j2qyo6m7WkG0gxdK2ZfsEM3l0vDHJo37MqvZWWFX5wOS6S/uj?=
 =?us-ascii?Q?Em1kEzwirQZxtR/p71wt+u2sIyiumLQxHiWrNExua727m4Q7rS2jcCYO5+ER?=
 =?us-ascii?Q?hMrU4yJ2Ms12c1qI8GqkQopZJK0Mz+OifW31JFuEVj1E3lc03nyzVQuJZ5Qj?=
 =?us-ascii?Q?NiFsb3aQlLv17J9V5ZREjzgaBY09eL2AyBiU5RBxK9A1KrpTgN8IN0NwhvDM?=
 =?us-ascii?Q?LLWjRA=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: analog.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CY4PR03MB3399.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 95b18d4f-7d42-41cb-fdfa-08dc16809f80
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Jan 2024 10:48:06.7177
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: eaa689b4-8f87-40e0-9c6f-7228de4d754a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ejslgQCDCWHgUEkqZNCpNYgC1IsqAKSkG0TBICLvzwSx3osjM3NVUEVo6rmVxQxdm+ynZgDchvuhSsAqEnYgD9G1t3GMtQYg/BfZm7L2vhU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR03MB7385
X-Proofpoint-GUID: F6f6x4R50REifHqFCXOCjiLRdQoGNEq7
X-Proofpoint-ORIG-GUID: F6f6x4R50REifHqFCXOCjiLRdQoGNEq7
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-12-02_01,2023-11-30_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 mlxscore=0
 clxscore=1015 priorityscore=1501 mlxlogscore=895 spamscore=0 adultscore=0
 lowpriorityscore=0 suspectscore=0 impostorscore=0 malwarescore=0
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.19.0-2311290000 definitions=main-2401160085

> From: Alexandre Belloni <alexandre.belloni@bootlin.com>
>=20
> Simplify the IRQ handler by using regmap_update_bits_check.
>=20
> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Reviewed-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
> ---
>  drivers/rtc/rtc-max31335.c | 12 +++++-------
>  1 file changed, 5 insertions(+), 7 deletions(-)
>=20
> diff --git a/drivers/rtc/rtc-max31335.c b/drivers/rtc/rtc-max31335.c
> index 2ce23f60a7f3..a38d303d9df4 100644
> --- a/drivers/rtc/rtc-max31335.c
> +++ b/drivers/rtc/rtc-max31335.c
> @@ -348,18 +348,16 @@ static int max31335_alarm_irq_enable(struct device
> *dev, unsigned int enabled)
>  static irqreturn_t max31335_handle_irq(int irq, void *dev_id)
>  {
>  	struct max31335_data *max31335 =3D dev_id;
> -	int ret, status;
> +	bool status;
> +	int ret;
>=20
> -	ret =3D regmap_read(max31335->regmap, MAX31335_STATUS1,
> &status);
> +	ret =3D regmap_update_bits_check(max31335->regmap,
> MAX31335_STATUS1,
> +				       MAX31335_STATUS1_A1F, 0, &status);
>  	if (ret)
>  		return IRQ_HANDLED;
>=20
> -	if (FIELD_GET(MAX31335_STATUS1_A1F, status)) {
> -		regmap_update_bits(max31335->regmap,
> MAX31335_STATUS1,
> -				   MAX31335_STATUS1_A1F, 0);
> -
> +	if (status)
>  		rtc_update_irq(max31335->rtc, 1, RTC_AF | RTC_IRQF);
> -	}
>=20
>  	return IRQ_HANDLED;
>  }
> --
> 2.43.0