Received-SPF: pass (google.com: domain of linux-kernel+bounces-27285-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Precedence: bulk
MIME-Version: 1.0
References: <20240115001606.15477-1-richard.weiyang@gmail.com>
In-Reply-To: <20240115001606.15477-1-richard.weiyang@gmail.com>
From: Masahiro Yamada <masahiroy@kernel.org>
Date: Tue, 16 Jan 2024 20:00:28 +0900
Message-ID: <CAK7LNATtqFOOdG0niydTecrf2u9TZG7wFhM7Mq6jy0nOfhVwAg@mail.gmail.com>
Subject: Re: [PATCH] kbuild: take vmlinux.[ao] out of single-targets
To: Wei Yang <richard.weiyang@gmail.com>
Cc: nathan@kernel.org, nicolas@fjasle.eu, linux-kbuild@vger.kernel.org, 
	linux-kernel@vger.kernel.org, Miguel Ojeda <ojeda@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, Jan 15, 2024 at 9:17=E2=80=AFAM Wei Yang <richard.weiyang@gmail.com=
> wrote:
>
> For current kernel, when we make vmlinux.a or vmlinux.o, following
> message would display.
>
> $make vmlinux.o
> /dir/to/kernel/Makefile:1887: warning: overriding recipe for target 'vmli=
nux.o'
> /dir/to/kernel/Makefile:1138: warning: ignoring old recipe for target 'vm=
linux.o'
>   CALL    scripts/checksyscalls.sh
>   DESCEND objtool
>   INSTALL libsubcmd_headers
> make[2]: Nothing to be done for 'vmlinux.o'.
>
> The reason is vmlinux.[ao] is treated as single target, while the rule
> is written in root Makefile.
>
> This patch fixes this by take them out of single-targets.
>
> Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
> CC: Masahiro Yamada <masahiroy@kernel.org>
> CC: Miguel Ojeda <ojeda@kernel.org>
> CC: Nathan Chancellor <nathan@kernel.org>
> ---


Not all targets can be built by the single-target.

Just do not do "make vmlinux.o".


>  Makefile | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index f1b2fd977275..66fb08f6d971 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -280,6 +280,7 @@ no-dot-config-targets :=3D $(clean-targets) \
>  no-sync-config-targets :=3D $(no-dot-config-targets) %install modules_si=
gn kernelrelease \
>                           image_name
>  single-targets :=3D %.a %.i %.ko %.lds %.ll %.lst %.mod %.o %.rsi %.s %.=
symtypes %/
> +no-single-targets :=3D vmlinux.o vmlinux.a
>
>  config-build   :=3D
>  mixed-build    :=3D
> @@ -315,11 +316,14 @@ ifeq ($(KBUILD_EXTMOD),)
>  endif
>
>  # We cannot build single targets and the others at the same time
> -ifneq ($(filter $(single-targets), $(MAKECMDGOALS)),)
> +ifneq ($(filter-out $(no-single-targets), $(filter $(single-targets), $(=
MAKECMDGOALS))),)
>         single-build :=3D 1
>         ifneq ($(filter-out $(single-targets), $(MAKECMDGOALS)),)
>                 mixed-build :=3D 1
>         endif
> +       ifneq ($(filter $(no-single-targets), $(MAKECMDGOALS)),)
> +               mixed-build :=3D 1
> +       endif
>  endif
>
>  # For "make -j clean all", "make -j mrproper defconfig all", etc.
> --
> 2.34.1
>


--=20
Best Regards
Masahiro Yamada