Received: by 2002:a05:7412:8d09:b0:fa:4c10:6cad with SMTP id bj9csp374434rdb; Tue, 16 Jan 2024 03:09:26 -0800 (PST) X-Google-Smtp-Source: AGHT+IFlWr/UrgeI4jbeqV/8VoGeGPMqQ8vdOODeykS/e1dWzKNaIAAoJjiNmT+NQYJGOy+slDH9 X-Received: by 2002:a05:622a:1716:b0:427:905f:94dc with SMTP id h22-20020a05622a171600b00427905f94dcmr8324006qtk.131.1705403366467; Tue, 16 Jan 2024 03:09:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1705403366; cv=none; d=google.com; s=arc-20160816; b=AxZqMK6PSZ4PqtN3XUkf8+eC8Kb+vPa0grD4yHuPEq6XzB4iDX+NW6bHwLqiGbvmlB ksjDbR0oHCgL92oUFbB45qrZDLc9ShXsBumNNHM6bDHRYKzTUSG5NNxV/EEBroFlMT/Y Q0Ga//glwR6U2DmaZbIWVdAW+3J5PzEpi3E0MMzeq9Cb+kHcLHq37qw/tOzPv+jBrxfW kx7m0HF1gdE8VkSUL/QzyDc+FL8bcqBHfAUVHmg/OBaRISs0k9pYoK01sPn0hZWjIIoh P/ORhMY7UNfOV2TkAz1LDRqQkuyy8Bvoby7O6pqx/vjGAS83bBEkzrxl2yGxIN1SZNpb e2lg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=NWhCUS105Mab9pG6Aa/RiKe1xKMtAu0zBQKBqBgFZKM=; fh=T5Qy85KLaypVtzPWbsVBEvNEqQOyAn9gVQI2wr3wknA=; b=LHDPFnRylFRNshKUjuhDFkZzlEXlDjEGR9Dgl8Z1nkNShGxGdzqEitVxlH/dNrp3R8 zd/TIrGMC57QLBdAeTQdtGMRX35NXLd3xjicvgfB26esULl9xz61plAOcEUBYK/VZBA7 h3cufuY6QVUrlJ05yTQyKcn8+ofKl5XtfdZAKjglsy2MuEnQXut3gAkYzyKM3/DepUs9 b68tHvWSNkpu0JJQvU16suri3bUS4Vwu7etrwHT//oAjGE4r0tjZtkSoGpY7CzlkqU9q 35rAw8R1BbvBDEk1+PxyobzK542EemFEqhzlnlCRH+nOdpJ+FtnXYqDTsppAbCUHE/26 Cglw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=iAwZYrwk; spf=pass (google.com: domain of linux-kernel+bounces-27292-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-27292-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id l19-20020a05622a051300b00429f4f61668si2770258qtx.130.2024.01.16.03.09.26 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jan 2024 03:09:26 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-27292-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=iAwZYrwk; spf=pass (google.com: domain of linux-kernel+bounces-27292-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-27292-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id B99E61C231B4 for ; Tue, 16 Jan 2024 11:09:25 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A94321B7EC; Tue, 16 Jan 2024 11:09:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="iAwZYrwk" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D0A1C1AAC3; Tue, 16 Jan 2024 11:09:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5384DC433C7; Tue, 16 Jan 2024 11:09:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1705403355; bh=YbACdFqvmVRJpaWfnCDjyhC2A6BqnS3dIuKLeFyqFGw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=iAwZYrwkYY9ZmHPTVRAAO/qmsAurhNdVcibidmDes1LNuZBm9UZk3PLTTXxSV0+LF ggHbPTfgPuns4lytOy1shJLvxGBqqfD4azihxSlYWBy25NP+eMJsve9R52eMrbL70H tpY5KCulQgdQDgk4WuC7TM+esP5VYgQzoh68x+UaS2ZjfBheRpn5OqO6gFxoOZ8jdk mPZ4uSCFz4ZfxRQtVW/ypRelkGWZhePtMaTbUMCMhU9p2jkIIwUcLJ1KvwWGl0/cuD s43KfgSMJAGjwHbGzyZK/HExeYurJf3peG8baBhDJjsnDEgxxHpQ0+yHumwqGsR69N YOB025WN0Rk2A== Received: from johan by xi.lan with local (Exim 4.96.2) (envelope-from ) id 1rPhJm-0005dt-1F; Tue, 16 Jan 2024 12:09:18 +0100 Date: Tue, 16 Jan 2024 12:09:18 +0100 From: Johan Hovold To: Konrad Dybcio Cc: Bjorn Andersson , Andy Gross , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Marijn Suijten , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v6 03/12] clk: qcom: gcc-sm6375: Unregister critical clocks Message-ID: References: <20230717-topic-branch_aon_cleanup-v6-0-46d136a4e8d0@linaro.org> <20230717-topic-branch_aon_cleanup-v6-3-46d136a4e8d0@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230717-topic-branch_aon_cleanup-v6-3-46d136a4e8d0@linaro.org> On Sat, Jan 13, 2024 at 03:50:52PM +0100, Konrad Dybcio wrote: > /* Keep some clocks always-on */ > + qcom_branch_set_clk_en(regmap, 0x17008); /* GCC_CAMERA_AHB_CLK */ > + qcom_branch_set_clk_en(regmap, 0x17004); /* GCC_VIDEO_AHB_CLK */ These two are not in sort order (haven't checked the rest of the patches). > + qcom_branch_set_clk_en(regmap, 0x1700c); /* GCC_DISP_AHB_CLK */ > qcom_branch_set_clk_en(regmap, 0x17028); /* GCC_CAMERA_XO_CLK */ > - qcom_branch_set_clk_en(regmap, 0x2b004); /* GCC_CPUSS_GNOC_CLK */ > qcom_branch_set_clk_en(regmap, 0x1702c); /* GCC_DISP_XO_CLK */ > + qcom_branch_set_clk_en(regmap, 0x2b004); /* GCC_CPUSS_GNOC_CLK */ > + qcom_branch_set_clk_en(regmap, 0x36004); /* GCC_GPU_CFG_AHB_CLK */ > + qcom_branch_set_clk_en(regmap, 0x79004); /* GCC_SYS_NOC_CPUSS_AHB_CLK */ Johan