Received-SPF: pass (google.com: domain of linux-kernel+bounces-27340-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: "Jenishkumar Patel [C]" <jpatel2@marvell.com>
To: 'Russell King' <linux@armlinux.org.uk>
CC: "marcin.s.wojtas@gmail.com" <marcin.s.wojtas@gmail.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "edumazet@google.com"
	<edumazet@google.com>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "netdev@vger.kernel.org"
	<netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>
Subject: RE: [EXT] Re: [PATCH 1/1] net: mvpp2: clear BM pool before
 initialization
Thread-Topic: [EXT] Re: [PATCH 1/1] net: mvpp2: clear BM pool before
 initialization
Thread-Index: AQHaSED3tkBbnIbaJEakXSpW8Z3u47DcK5oAgAAlRCA=
Date: Tue, 16 Jan 2024 11:42:04 +0000
Message-ID: 
 <PH0PR18MB4543D1F967616763C27EBB2EEC732@PH0PR18MB4543.namprd18.prod.outlook.com>
References: <20240116055754.279560-1-jpatel2@marvell.com>
 <ZaZLuPyRa5QhRrmH@shell.armlinux.org.uk>
In-Reply-To: <ZaZLuPyRa5QhRrmH@shell.armlinux.org.uk>
Accept-Language: en-GB, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?KdwBH/oDI2sWyTfKsNbe0Sf5dWUK065X0zgxI/IB71Kdtoi9vN5F24Vruea6?=
 =?us-ascii?Q?Q/lYQEkY5i7KKjlxMhCXrRMVstzcWLonXOrRawaX37UArxpt9UNlM5ZeFfY3?=
 =?us-ascii?Q?nyfKlh4/z1sozw/U0CQMpQPt95mEGy/yOZtyXcDrEjE0Ad1HksECmStcn1U2?=
 =?us-ascii?Q?loF5TZP1sQ1UDbE5TElOSIpDFNC5hov8qM1+6jtQZSE4w1scEB7RyFl8W8t6?=
 =?us-ascii?Q?5q6nWJAfeYZnytsOgR35JQEaheS1bqFOvpxjUW7/RkM6u9O+/VtlbUCTkafX?=
 =?us-ascii?Q?9B83MKqSoiW+GMdqOZsgbb1jj2dDAgmF++kf85MXVUlJ5i8VsF1NsPtUQpS6?=
 =?us-ascii?Q?Qf3bX32AJbwznpyxJGNfB/ZbpNM4wTla0S1KXNrUuxRGcXIitWzJ9sMgroKW?=
 =?us-ascii?Q?lTi7ue/0ZHHj4r6ii/n2NU62WOy9g4Ppp4GU1NsgcnKV0HG7eeVuhD5/9MT0?=
 =?us-ascii?Q?sUTVCynKCCm9v9QTt1z+Jov1eBs4j2snEuxI81M2mMwGtCM7DPbOxakLpFZj?=
 =?us-ascii?Q?KHkAbVHTXj/QNYl0eSsB7hpktyy8DyY+UNN8qpb6zM7vQaueXB7UpTQOGhR0?=
 =?us-ascii?Q?mFphw0g0QxDkkIoikCI1na2VdZyNaoi2IImCbvfbxxY6M1w+0vU4K+briViu?=
 =?us-ascii?Q?8rR5N5CjVzWtCa+9fw4gyn7FY61fkhdrwwZX75W3pJ9yyc39ebTjfjdkeIad?=
 =?us-ascii?Q?9SBfu5+MYVzcXOIAnNf/mKaOkB6L55x9n9zzrX+Yv30Rf6/DLduosYCYGzH4?=
 =?us-ascii?Q?kA9QIzR/liN+uu3jdlqar87Klbv9WHACqahN1MmMRTPcoh2ReA5kquCJTkTO?=
 =?us-ascii?Q?fGdQrRY1rc3cPgpcUcuYzfPyHcbCG5QHXXiOjJ+AQzpxdTdrxHcbhhPxH0UP?=
 =?us-ascii?Q?8YpbMySxw5Pg0trAkLberv23BO8pmV32uIh/Mmjk39LPCflUFU3oMPiXcGWK?=
 =?us-ascii?Q?PIWdA9kuCAhP/djjMi6/lTkRoDDkLqxtFG2i0QFYPYojxP+bA70Xui4GlK29?=
 =?us-ascii?Q?LDkTkdrALWynwiFUaYx3FdhvibI1tVSwOU3AgVKrHsdlxtVAkdc8GXgDJer5?=
 =?us-ascii?Q?vJbs/RZ+Q5zBLQJr2P1SlJliHER1tbcQM4MsdUd2KE49rsCnk7km3qlC1zkm?=
 =?us-ascii?Q?T8nlBQqaIRW3Tfydpv+7ghaQ6QNCSGkZacluJd9O+91mpGKyRFnGcb07dWTf?=
 =?us-ascii?Q?mNHzghx7aPGTSmQAEjVOKh1gJXXMxkI+qmILdl09FgNvaBOXk36jLijzrOMz?=
 =?us-ascii?Q?+XnAg2AO6Lp9TJmaFyFB1N7iiLHsLJlWWXVnhy2siDTldJaBZa/Np/o69rrX?=
 =?us-ascii?Q?4eAbgUy6bqVt5Fm2oKlosl56PhkvfsK2KxD2akNYEuPnRJX6nvqJ7BBtcBP6?=
 =?us-ascii?Q?jBwNSJ2z3C3VC/8RQHm7hWUpkRUVMH/7ICVzVSlC2Z8i4JHDUd484GK55gA8?=
 =?us-ascii?Q?yx2AeG7YoXphqCGov1zg7+VzQkUSPQFDXf7h56RVK3NjZSuYG6VnfzPy4tO/?=
 =?us-ascii?Q?ixwlDwpsz+UaV2FaTMFGjgf2QfEL/yyTb8GTqTpLvlSK6EcOl34HKuuQWgZn?=
 =?us-ascii?Q?yQK58MHb0/gotZlNLiI=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR18MB4543.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7926a54e-bed1-4e4d-ab9f-08dc16882990
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Jan 2024 11:42:04.7981
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: uBPfpEU+g/fe31/kbf0nSbgEer7meJmhHWgQoegpXvLZ+8R47iWqeCKJvRGIUrdWLVwZm9NM/zmBYF0Nr0KBIA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR18MB4031
X-Proofpoint-ORIG-GUID: Ze_tEQE3jd-gUxZQAvakRhmP9gTojz2j
X-Proofpoint-GUID: Ze_tEQE3jd-gUxZQAvakRhmP9gTojz2j
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-12-09_02,2023-12-07_01,2023-05-22_02


-----Original Message-----
From: Russell King <linux@armlinux.org.uk>=20
Sent: Tuesday, January 16, 2024 2:56 PM
To: Jenishkumar Patel [C] <jpatel2@marvell.com>
Cc: marcin.s.wojtas@gmail.com; davem@davemloft.net; edumazet@google.com; ku=
ba@kernel.org; pabeni@redhat.com; netdev@vger.kernel.org; linux-kernel@vger=
kernel.org
Subject: [EXT] Re: [PATCH 1/1] net: mvpp2: clear BM pool before initializat=
ion

External Email

----------------------------------------------------------------------
On Mon, Jan 15, 2024 at 09:57:54PM -0800, Jenishkumar Maheshbhai Patel wrot=
e:
>  static int mvpp2_bm_init(struct device *dev, struct mvpp2 *priv)  {
>  	enum dma_data_direction dma_dir =3D DMA_FROM_DEVICE;
>  	int i, err, poolnum =3D MVPP2_BM_POOLS_NUM;
>  	struct mvpp2_port *port;
> =20
> +	if (priv->percpu_pools)
> +		poolnum =3D mvpp2_get_nrxqs(priv) * 2;
> +
> +	for (i =3D 0; i < poolnum; i++) {
> +		/* Make sure about the pool state in case it was
> +		 * used by firmware.
> +		 */
> +		mvpp2_bm_pool_cleanup(priv, i);
> +	}

	/* Clean up the pool state in case it contains stale state */
	for (i =3D 0; i < poolnum; i++)
		mvpp2_bm_pool_cleanup(priv, i);

Doesn't need quite as many lines!

I will address the comments in v2

--
RMK's Patch system: https://urldefense.proofpoint.com/v2/url?u=3Dhttps-3A__=
www.armlinux.org.uk_developer_patches_&d=3DDwIBAg&c=3DnKjWec2b6R0mOyPaz7xtf=
Q&r=3DweFk2fYEO0yNIZAlSXwm82u5QM08YlNJaQ39RhfTtUo&m=3D2U4cWAQSanajVfFvpZbZd=
hHMcQ4rsCILgPZ1Nk_k-CE3HMuIv3y5IPWQ4KgdJgAG&s=3DIbrApY-e2TWgCw8YQJc7W48jpUG=
y29BTy_MfcTkwQ8I&e=3D
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!