Received-SPF: pass (google.com: domain of linux-kernel+bounces-27363-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Tue, 16 Jan 2024 13:01:01 +0100
From: Nicolas Schier <n.schier@avm.de>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: Tomasz Figa <tfiga@chromium.org>, linux-kbuild@vger.kernel.org,
	linux-kernel@vger.kernel.org, Jesse Taube <Mr.Bossman075@gmail.com>
Subject: Re: [PATCH] kconfig: menuconfig: Make hidden options show as dim
Message-ID: <ZaZv_TNR5_1zOCji@reykjavik.ads.avm.de>
References: <20231228054630.3595093-1-tfiga@chromium.org>
 <CAK7LNATBipJtprjvvRVYg8JcYOFXQdpLEyEc+4+8j1PtBQ+PUg@mail.gmail.com>
 <CAAFQd5C3vAUJhKiQ1LPkZv3dJxNvK4QinRezV9Q8rz_Ov6FSUQ@mail.gmail.com>
 <CAK7LNAQcaDneE4rnjvV+GTSBBMozm5deu_q9+STTn60ervZJbA@mail.gmail.com>
 <CAAFQd5DcxL80cb8w9OZs0mpD=Y3K=LmM7exG7U_DaSsMkfni7Q@mail.gmail.com>
 <CAK7LNASyiYasGa2_Ppp54nEq2m08q_Z_keViZDCavmNN0rBAzQ@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAK7LNASyiYasGa2_Ppp54nEq2m08q_Z_keViZDCavmNN0rBAzQ@mail.gmail.com>

On Tue, Jan 16, 2024 at 07:58:05PM +0900, Masahiro Yamada wrote:
> On Mon, Jan 15, 2024 at 2:04 PM Tomasz Figa <tfiga@chromium.org> wrote:
> >
> > On Sat, Jan 13, 2024 at 8:23 PM Masahiro Yamada <masahiroy@kernel.org> wrote:
> > >
> > > On Wed, Jan 10, 2024 at 10:05 PM Tomasz Figa <tfiga@chromium.org> wrote:
> > > >
> > > > On Fri, Dec 29, 2023 at 1:10 AM Masahiro Yamada <masahiroy@kernel.org> wrote:
> > > > >
> > > > > On Thu, Dec 28, 2023 at 2:46 PM Tomasz Figa <tfiga@chromium.org> wrote:
> > > > > >
> > > > > > When hidden options are toggled on (using 'z'), the number of options
> > > > > > on the screen can be overwhelming and may make it hard to distinguish
> > > > > > between available and hidden ones. Make them easier to distinguish by
> > > > > > displaying the hidden one as dim (using the A_DIM curses attribute).
> > > > > >
> > > > > > Signed-off-by: Tomasz Figa <tfiga@chromium.org>
> > > > >
> > > > >
> > > > >
> > > > > Do you think this is useful?
> > > > >
> > > > > This changes the color only when you select a hidden item.
> > > > >
> > > > >
> > > > > For unselected items, you cannot distinguish hidden ones,
> > > > > as A_DIM has no effect to black text.
> > > > >
> > > > >
> > > >
> > > > Hmm, are you sure about that? For me it seems to dim the text. it
> > > > seems to be also used in the existing code for dlg.button_inactive.atr
> > > > of the mono theme:
> > > >
> > > > https://elixir.bootlin.com/linux/latest/source/scripts/kconfig/lxdialog/util.c#L26
> > >
> > >
> > >
> > > Then, your code works only on the mono theme.
> > > (when your terminal does not support color, or
> > > "MENUCONFIG_COLOR=mono make menuconfig")
> > >
> >
> > No, that's not what I meant. It works for me for all themes, see the
> > screenshot at https://postimg.cc/sBsM0twT . The terminal is tmux
> > inside hterm (which in turn is supposed to be compatible with xterm).
> > I guess I can test a couple of different terminals.
> >
> > In which terminal is it not working for you?
> 
> 
> I use gnome-terminal.
> The disto is Ubuntu 23.10

I see the same behaviour as Masahiro described with foot 1.13.1 on
Debian 12.

Kind regards,
Nicolas