Received-SPF: pass (google.com: domain of linux-kernel+bounces-27435-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Tue, 16 Jan 2024 15:51:48 +0200
From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: "David S. Miller" <davem@davemloft.net>, Andrew Lunn <andrew@lunn.ch>,
	Eric Dumazet <edumazet@google.com>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Woojung Huh <woojung.huh@microchip.com>,
	Arun Ramadoss <arun.ramadoss@microchip.com>, kernel@pengutronix.de,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	UNGLinuxDriver@microchip.com
Subject: Re: [RFC net-next v3 3/3] net: dsa: microchip: implement PHY
 loopback configuration for KSZ8794 and KSZ8873
Message-ID: <20240116135148.hleo3v5lztg4k6nd@skbuf>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240112140716.2715664-4-o.rempel@pengutronix.de>
 <20240112140716.2715664-4-o.rempel@pengutronix.de>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?JMEB8tsrivXJseuqbzpgKI6xOoK9QUBSK6qQ/Gsp23Gr6S7m7PGeYBHcc5Qp?=
 =?us-ascii?Q?5n3HNeO/E2GE5gJnvdLQRNhSt70XZKgUVevc41LraNG/9qnDb8uiwsTnNUad?=
 =?us-ascii?Q?bGzUCOKVSLcae9CHI8+Cy4Al/1yUdlwBD1jTs2JUu6AbDQ6UU+68vWGwqb8C?=
 =?us-ascii?Q?giRJhk0ieDPRuQ5+bqwmjkY6eAhGJxtANhxdY3ZYsTExYrz4p2gw4aRclIF5?=
 =?us-ascii?Q?XVTLDnftTDGQ+3wzTDm3SxBE+Xzf7yFfApDnfJUlbBhZOi9/bEnEXFIFzWYs?=
 =?us-ascii?Q?fKEZXBeHdJWbZiynOqLL2N9ZbcW80wc4thFL7BhiiY/IZLVDnlJTxRC4GpYK?=
 =?us-ascii?Q?vLmVPSyG9ZaC1usvAzR9YyVhkAY9nOslOEdDgq1rAQWJPSElSSPXpgVsYg8/?=
 =?us-ascii?Q?Bqm+Rx4e8EOGcoFlJVcROsu2AV11E9ydoDH4ztWNuEq+nNp5O49dmUUqiYJw?=
 =?us-ascii?Q?NhZQZuYBzZ0cKoxVt3BOHrAEtnMU89pcFCthu4/YAV3rhX4wOFy0kXEgMUvT?=
 =?us-ascii?Q?/PBVyFvMZyHahV1xVe0NfQIZz4Jus1hwoAjo1oe5O6Rf628GscAt/ANwKR8r?=
 =?us-ascii?Q?Fc6UDbTi0Vz2p+AWVRTtY6biaaMelxPvA/sPX56N5w/7eYZhlDpnI7aV+M0J?=
 =?us-ascii?Q?HYXD+t+ZxUKAGhvEGqvU+A0lrkK2+bwIPIFpkSzfSdLDFEiYwHlvWkjtFM7N?=
 =?us-ascii?Q?rgkRnB1lxTIfrbYvpt0YQ0PJYu5DqI/VXPScHRcWEq5ufVcruxOOZYtRBbcH?=
 =?us-ascii?Q?ZCnWwofsgxd7Nv3NwHfehEV3lQOoVsWbT+c1SkY76UmfH2Ty4ViD+OvqgIJG?=
 =?us-ascii?Q?hM35UCDXNvlvYdO/Q7HqUnFnXLwniDHfkGPog8f4zvlFuV9afPdaH4ciSeOa?=
 =?us-ascii?Q?VvxaDWrMa8Kah3x4qlDbytTyCBa0UtVijo+V6nJHKSUop9GcvlqzMI6Gnrfg?=
 =?us-ascii?Q?+ZLVMHdiWGpsOcp+8mJAFL/UHKdsqYAB2UOuCUdfcNNtmhZMTHjcu3820UbK?=
 =?us-ascii?Q?30UHlLmhGPDn79lSmV+6MgGBcjHtfq3rhhUU7NuZ6kz5xmpd1VYMbsMPGckh?=
 =?us-ascii?Q?JHfVnmH8c2w+Zv/yfk+AHB69JjGkb+bcmWgEYUCXAGcOptI2yvCrNPpTrghc?=
 =?us-ascii?Q?7h1vmR4eCG7EkdsKn1vUcMcLpkeyey4ebDTiAe60KFxYSHyFAnrH2F25Lpnn?=
 =?us-ascii?Q?K0ySpCj6xHXXTkMTGsJqj7QRi580sRKShRqzsmAeYLySrEOLgMBYn/N51N6w?=
 =?us-ascii?Q?82KT0PDTT7jwwrySyCclqjfuIyEhO9pLi8h5BaB3za7maQLfSBgRXDkBpQjg?=
 =?us-ascii?Q?jUphH8gDMjiKJuMRZU+UGUCgCIk4sMEE01Km8dw7VfQoCjD3PoeGvoHzlRov?=
 =?us-ascii?Q?YKbUMwlcGGbF4LD1gKRTwRCJNKBPN0zBK14mTX0VCJOISTptQ32iH+OUwd+4?=
 =?us-ascii?Q?NQOI3gUY/sA0FNuZPzReUMQw3uO/FIqekm9uGqlt6ZoROx9v3g1Ar6zKzg0E?=
 =?us-ascii?Q?a7kovv6uqonL4gRNNGannhooIkPoTFDoNI4A8RKCZt5pC8WS+kYKsmLPKj4B?=
 =?us-ascii?Q?vZ4HarWlEZfbaJxIGtAOvx0bmxZ3Jas+NvDk/afwpPvt1XqSUR9Cgu8+BQ2D?=
 =?us-ascii?Q?tw=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 87053bc1-f04b-49b5-e2ce-08dc169a4b00
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB7374.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jan 2024 13:51:52.3010
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: uapgrm9Pd7Pof3bw24CgxsrC9IFPaF66W0FjX57sonm5VAkDBIm0ZLWzFUKV850/kCxF251Ft+wrtgF1aHpo3g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8082

On Fri, Jan 12, 2024 at 03:07:16PM +0100, Oleksij Rempel wrote:
> Correct the PHY loopback bit handling in the ksz8_w_phy_bmcr and
> ksz8_r_phy_bmcr functions for KSZ8794 and KSZ8873 variants in the ksz8795
> driver. Previously, the code erroneously used Bit 7 of port register 0xD
> for both chip variants, which is actually for LED configuration. This
> update ensures the correct registers and bits are used for the PHY
> loopback feature:
> 
> - For KSZ8794: Use 0xF / Bit 7.
> - For KSZ8873: Use 0xD / Bit 0.
> 
> The lack of loopback support was seen on KSZ8873 system by using
> "ethtool -t lanX". After this patch, the ethtool selftest will work,
> but only if port is not part of a bridge.
> 
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> ---

Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>