Received-SPF: pass (google.com: domain of linux-kernel+bounces-27436-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: Andi Kleen <ak@linux.intel.com>
To: Changbin Du <changbin.du@huawei.com>
Cc: Peter Zijlstra <peterz@infradead.org>,  Ingo Molnar <mingo@redhat.com>,
  Arnaldo Carvalho de Melo <acme@kernel.org>,  Mark Rutland
 <mark.rutland@arm.com>,  Alexander Shishkin
 <alexander.shishkin@linux.intel.com>,  Jiri Olsa <jolsa@kernel.org>,
  Namhyung Kim <namhyung@kernel.org>,  Ian Rogers <irogers@google.com>,
  Adrian Hunter <adrian.hunter@intel.com>,  <linux-kernel@vger.kernel.org>,
  <linux-perf-users@vger.kernel.org>
Subject: Re: [PATCH 0/3] perf: script: Intro capstone disasm engine to show
 instruction trace
In-Reply-To: <20240116113437.1507537-1-changbin.du@huawei.com> (Changbin Du's
	message of "Tue, 16 Jan 2024 19:34:34 +0800")
References: <20240116113437.1507537-1-changbin.du@huawei.com>
Date: Tue, 16 Jan 2024 05:53:40 -0800
Message-ID: <87il3tl6zf.fsf@linux.intel.com>
User-Agent: Gnus/5.13 (Gnus v5.13)
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain

Changbin Du <changbin.du@huawei.com> writes:

> This series introduces capstone disassembler engine to print instructions of
> Intel PT trace, which was printed via the XED tool.

FWIW at least on x86 in my experience capstone isn't that great an
disassembler. I used it in another project and ran into many decoding bugs.
They're mostly in obscure corners, but can be fairly annoying.

My other concern with your patchkit is that you change the default
output formats. Since perf script is often used with scripts
(as the name implies) there is a certain expectation that the output
remains stable and parse-able. There are actually use cases where
the raw bytes "insn" output is needed.

I would rather define new perf script output types for the new decoded output,
but keep the old alone.

-Andi