Received-SPF: pass (google.com: domain of linux-kernel+bounces-27579-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Subject: Re: [PATCH v4 2/2] selftests/bpf: Add test for alu on
 PTR_TO_FLOW_KEYS
To: Hao Sun <sunhao.th@gmail.com>, bpf@vger.kernel.org
Cc: willemb@google.com, ast@kernel.org, andrii@kernel.org, eddyz87@gmail.com,
 yonghong.song@linux.dev, linux-kernel@vger.kernel.org
References: <20240115082028.9992-1-sunhao.th@gmail.com>
 <20240115082028.9992-2-sunhao.th@gmail.com>
From: Daniel Borkmann <daniel@iogearbox.net>
Message-ID: <3c69823d-1e46-60f4-5a41-d6a2983af532@iogearbox.net>
Date: Tue, 16 Jan 2024 17:20:04 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.7.2
Precedence: bulk
MIME-Version: 1.0
In-Reply-To: <20240115082028.9992-2-sunhao.th@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 1/15/24 9:20 AM, Hao Sun wrote:
> Add a test case for PTR_TO_FLOW_KEYS alu. Testing if alu with
> variable offset on flow_keys is rejected.
> 
> Signed-off-by: Hao Sun <sunhao.th@gmail.com>

Thanks applied, I've also added a note that we already have coverage
on the success case. Do you plan to follow up with checking the
remaining pointer types as Eduard suggested earlier?

Thanks,
Daniel