Received-SPF: pass (google.com: domain of linux-kernel+bounces-27594-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: David Laight <David.Laight@ACULAB.COM>
To: 'Muhammad Usama Anjum' <usama.anjum@collabora.com>, Andrew Morton
	<akpm@linux-foundation.org>, Shuah Khan <shuah@kernel.org>
CC: "kernel@collabora.com" <kernel@collabora.com>, "linux-mm@kvack.org"
	<linux-mm@kvack.org>, "linux-kselftest@vger.kernel.org"
	<linux-kselftest@vger.kernel.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] selftests/mm: switch to bash from sh
Thread-Topic: [PATCH] selftests/mm: switch to bash from sh
Thread-Index: AQHaSFsmDX3I4Kn9G0+MfyGy1cAOzbDcpaTg
Date: Tue, 16 Jan 2024 16:52:25 +0000
Message-ID: <0d5811eafd00496d98e88afe847fb8be@AcuMS.aculab.com>
References: <20240116090455.3407378-1-usama.anjum@collabora.com>
In-Reply-To: <20240116090455.3407378-1-usama.anjum@collabora.com>
Accept-Language: en-GB, en-US
Precedence: bulk
MIME-Version: 1.0
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

From: Muhammad Usama Anjum
> Sent: 16 January 2024 09:05
>=20
> Running charge_reserved_hugetlb.sh generates errors if sh is set to
> dash:
>=20
> /charge_reserved_hugetlb.sh: 9: [[: not found
> /charge_reserved_hugetlb.sh: 19: [[: not found
> /charge_reserved_hugetlb.sh: 27: [[: not found
> /charge_reserved_hugetlb.sh: 37: [[: not found
> /charge_reserved_hugetlb.sh: 45: Syntax error: "(" unexpected
>=20
> Switch to using /bin/bash instead of /bin/sh. Make the switch for
> write_hugetlb_memory.sh as well which is called from
> charge_reserved_hugetlb.sh.

Why not just fix the script?
Looks like most of the [[ ... ]] could be [ ... ]
although some might need to be [ -n "$cgroup2" ].
The delete the 'function' keyword another bash-ism.

It's not as though you are trying to run on a system
when /bin/sh is a traditional (aka non-posix) bourne shell.

=09David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1=
PT, UK
Registration No: 1397386 (Wales)