Received-SPF: pass (google.com: domain of linux-kernel+bounces-27605-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <ad55e4845edfd052538b5e80ae7ff2a67820424c.camel@linux.intel.com>
Subject: Re: [PATCH v4 1/3] x86/hyperv: Use slow_virt_to_phys() in page
 transition hypervisor callback
From: "rick.p.edgecombe@linux.intel.com" <rick.p.edgecombe@linux.intel.com>
To: mhklinux@outlook.com, tglx@linutronix.de, mingo@redhat.com,
 bp@alien8.de,  dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, 
 kirill.shutemov@linux.intel.com, haiyangz@microsoft.com,
 wei.liu@kernel.org,  decui@microsoft.com, luto@kernel.org,
 peterz@infradead.org,  akpm@linux-foundation.org, urezki@gmail.com,
 hch@infradead.org, lstoakes@gmail.com,  thomas.lendacky@amd.com,
 ardb@kernel.org, jroedel@suse.de, seanjc@google.com, 
 sathyanarayanan.kuppuswamy@linux.intel.com, linux-kernel@vger.kernel.org, 
 linux-coco@lists.linux.dev, linux-hyperv@vger.kernel.org, linux-mm@kvack.org
Date: Tue, 16 Jan 2024 09:02:29 -0800
In-Reply-To: <20240116022008.1023398-2-mhklinux@outlook.com>
References: <20240116022008.1023398-1-mhklinux@outlook.com>
	 <20240116022008.1023398-2-mhklinux@outlook.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4-0ubuntu2 
Precedence: bulk
MIME-Version: 1.0

On Mon, 2024-01-15 at 18:20 -0800, mhkelley58@gmail.com wrote:
> From: Michael Kelley <mhklinux@outlook.com>
>=20
> In preparation for temporarily marking pages not present during a
> transition between encrypted and decrypted, use slow_virt_to_phys()
> in the hypervisor callback. As long as the PFN is correct,
> slow_virt_to_phys() works even if the leaf PTE is not present.
> The existing functions that depend on vmalloc_to_page() all
> require that the leaf PTE be marked present, so they don't work.
>=20
> Update the comments for slow_virt_to_phys() to note this broader
> usage
> and the requirement to work even if the PTE is not marked present.
>=20
> Signed-off-by: Michael Kelley <mhklinux@outlook.com>

Reviewed-by: Rick Edgecombe <rick.p.edgecombe@intel.com>