Received-SPF: pass (google.com: domain of linux-kernel+bounces-27612-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Tue, 16 Jan 2024 17:09:23 +0000
From: Conor Dooley <conor@kernel.org>
To: Tim Lunn <tim@feathertop.org>
Cc: linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Chris Zhong <zyw@rock-chips.com>,
	Conor Dooley <conor+dt@kernel.org>,
	Heiko Stuebner <heiko@sntech.de>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Lee Jones <lee@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	Zhang Qing <zhangqing@rock-chips.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/3] dt-bindings: rockchip: Update rk809 example with
 audio codec properties
Message-ID: <20240116-muppet-buggy-4caf9620b660@spud>
References: <20240116132102.3272682-1-tim@feathertop.org>
 <20240116132102.3272682-4-tim@feathertop.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="ZK3izpEatKf2F2cp"
Content-Disposition: inline
In-Reply-To: <20240116132102.3272682-4-tim@feathertop.org>


--ZK3izpEatKf2F2cp
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Jan 17, 2024 at 12:21:02AM +1100, Tim Lunn wrote:
> Update the example provided to include the properties for using
> rk817 audio codec.
>=20
> Signed-off-by: Tim Lunn <tim@feathertop.org>
>=20
> ---
>=20
> Changes in v2:
> - Fix missing include and pinctrl for codec example
>=20
>  .../devicetree/bindings/mfd/rockchip,rk809.yaml          | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
>=20
> diff --git a/Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml b/=
Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml
> index 9b9d670708ce..fee8338b230b 100644
> --- a/Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml
> +++ b/Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml
> @@ -147,6 +147,7 @@ additionalProperties: false
> =20
>  examples:
>    - |
> +    #include <dt-bindings/clock/px30-cru.h>
>      #include <dt-bindings/pinctrl/rockchip.h>
>      #include <dt-bindings/interrupt-controller/irq.h>
>      #include <dt-bindings/gpio/gpio.h>
> @@ -161,10 +162,13 @@ examples:
>              clock-output-names =3D "xin32k", "rk808-clkout2";
>              interrupt-parent =3D <&gpio3>;
>              interrupts =3D <10 IRQ_TYPE_LEVEL_LOW>;
> +            clock-names =3D "mclk";
> +            clocks =3D <&cru SCLK_I2S1_OUT>;
>              pinctrl-names =3D "default";
> -            pinctrl-0 =3D <&pmic_int_l_pin>;
> +            pinctrl-0 =3D <&pmic_int_l_pin>, <&i2s1_2ch_mclk>;
>              rockchip,system-power-controller;
>              wakeup-source;
> +            #sound-dai-cells =3D <0>;
> =20
>              vcc1-supply =3D <&vcc_sysin>;
>              vcc2-supply =3D <&vcc_sysin>;
> @@ -309,5 +313,8 @@ examples:
>                      };
>                  };
>              };

Blank line here please.
I'd squash this with the patch adding the codec as an allowed property
though.

Thanks,
Conor.

> +            rk817_codec: codec {
> +                rockchip,mic-in-differential;
> +            };
>          };
>      };
> --=20
> 2.40.1
>=20

--ZK3izpEatKf2F2cp
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZaa4QwAKCRB4tDGHoIJi
0jP3AQDI8jR4sG+u+6VZmJWVJya/eoRO5vJx5Hcoe2PPsDpwHgEAw9URuB4Gt7Mn
vxyyA5dzuCVrr+mT1oK+Rq7RbtxA7gQ=
=CDvt
-----END PGP SIGNATURE-----

--ZK3izpEatKf2F2cp--