Received-SPF: pass (google.com: domain of linux-kernel+bounces-27732-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <20240108135421.684263-1-tmaimon77@gmail.com> <20240108135421.684263-6-tmaimon77@gmail.com>
 <4e9cc473-dbab-4e7c-ac7f-871a4025ef5b@linaro.org>
In-Reply-To: <4e9cc473-dbab-4e7c-ac7f-871a4025ef5b@linaro.org>
From: Tomer Maimon <tmaimon77@gmail.com>
Date: Tue, 16 Jan 2024 21:03:57 +0200
Message-ID: <CAP6Zq1ii49BFPAg_erhiu6qMj7zC7iLg=C-N1c3UKy7iEe9CXQ@mail.gmail.com>
Subject: Re: [PATCH v22 5/8] arm64: dts: nuvoton: npcm8xx: add clock reset
 syscon node
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: mturquette@baylibre.com, sboyd@kernel.org, robh+dt@kernel.org, 
	krzysztof.kozlowski+dt@linaro.org, tali.perry1@gmail.com, joel@jms.id.au, 
	venture@google.com, yuenn@google.com, benjaminfair@google.com, 
	openbmc@lists.ozlabs.org, linux-clk@vger.kernel.org, 
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"

Hi Krzysztof,

Thanks for your comments.

On Wed, 10 Jan 2024 at 23:01, Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 08/01/2024 14:54, Tomer Maimon wrote:
> > Add clock reset syscon node to handle reset and clock registers
> > controllers.
> >
> > Signed-off-by: Tomer Maimon <tmaimon77@gmail.com>
> > ---
> >  arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi | 5 +++++
> >  1 file changed, 5 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi b/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi
> > index 9c4df91031e7..7d5956e2c9f3 100644
> > --- a/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi
> > +++ b/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi
> > @@ -22,6 +22,11 @@ gcr: system-controller@f0800000 {
> >                       reg = <0x0 0xf0800000 0x0 0x1000>;
> >               };
> >
> > +             clk_rst: syscon@f0801000 {
> > +                     compatible = "nuvoton,npcm845-clk-rst", "syscon", "simple-mfd";
>
> This is not a simple-mfd. No children,
>
> > +                     reg = <0x0 0xf0801000 0x0 0xC4>;
>
> Use lowercase hex. Please store this feedback in your checklist and do
> not repeat the same mistakes in further submissions.
>
> Best regards,
> Krzysztof
>
will be fixed in the next version.

Best regards,

Tomer