Received-SPF: pass (google.com: domain of linux-kernel+bounces-27814-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <e89278a8-cd40-4e73-ae39-800c29dae385@intel.com>
Date: Tue, 16 Jan 2024 11:44:12 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v5 2/2] x86/resctrl: Read supported bandwidth sources
 using CPUID command
Content-Language: en-US
To: Babu Moger <babu.moger@amd.com>, <corbet@lwn.net>, <fenghua.yu@intel.com>,
	<tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>,
	<dave.hansen@linux.intel.com>
CC: <x86@kernel.org>, <hpa@zytor.com>, <paulmck@kernel.org>,
	<rdunlap@infradead.org>, <tj@kernel.org>, <peterz@infradead.org>,
	<seanjc@google.com>, <kim.phillips@amd.com>, <jmattson@google.com>,
	<ilpo.jarvinen@linux.intel.com>, <jithu.joseph@intel.com>,
	<kan.liang@linux.intel.com>, <nikunj@amd.com>,
	<daniel.sneddon@linux.intel.com>, <pbonzini@redhat.com>,
	<rick.p.edgecombe@intel.com>, <rppt@kernel.org>,
	<maciej.wieczor-retman@intel.com>, <linux-doc@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <eranian@google.com>,
	<peternewman@google.com>, <dhagiani@amd.com>
References: <20231201005720.235639-1-babu.moger@amd.com>
 <669896fa512c7451319fa5ca2fdb6f7e015b5635.1705359148.git.babu.moger@amd.com>
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <669896fa512c7451319fa5ca2fdb6f7e015b5635.1705359148.git.babu.moger@amd.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eXZDOXBKVDNVQnAwWWRSamkxSC9HMU5RV1E0UEhodEZiNjVxY0VTSDVWZWJh?=
 =?utf-8?B?V3pvV0F4QnhCQlY1M1BWakpKNGVnb1FEYjdZRzkwK0kzeXZFdkFYUGRLYjNQ?=
 =?utf-8?B?RFFYRjA1TW96UFR1SWtwditab2ZmMTdBVWhIYTZQazRSOU00MExZeXNiODMy?=
 =?utf-8?B?MEhPMTRBY0ttZHM5TVR0dHhFaHExczRsNmxYaWpkU2lTZXJtdjNOMnpTRmN6?=
 =?utf-8?B?dnprYjlmRjR1UGhGdE1zek1rNGthbkZKbjYyWWRQRFlUdkNEQjQwMkhDcSt4?=
 =?utf-8?B?aHRjbnh6bXRyd3hRY0dHRUhRV0c2cERaelhjaWFZbzVDYVNnU28rSnQ1ZUky?=
 =?utf-8?B?QTRudC81V1BUS3ZMWDEyeDd2K28xVzFOckJNSTc5ajQwQjFtRkUvakpCZVNM?=
 =?utf-8?B?Z1Z2dDFFKzhpSE5Cdk9FOEpkUjMzNWd3TWk0aENYdFJ0R2pVOW11TS9xRHhl?=
 =?utf-8?B?aHRURTVlcjR4dW5TTjZjMlFxQmZwZ0xZRVpnMFRPWk9QRmkwZWo2K2lLSU85?=
 =?utf-8?B?Z3RyWXJLSUJKSHFBTkg4SE1vYnUyeUs4LzVWWUtSMkZGa1k0aEd6TjJERzdi?=
 =?utf-8?B?ZmRqNzQxU1FFZDZseGFqYU9MeGVLVndibE52WDVwOGQwbFdOMktadnZXM1Mv?=
 =?utf-8?B?RXN2S0ZMZVlodTc4aUR2YnBvTy8xL21wZWMvRmQ5dVdpcE9CU05sdVpNdVhL?=
 =?utf-8?B?MElQV2k3VlV4Um9rR2lMUWlwQk9acGFuYkJod1NTSkpSVFBVZWpuYmhORm9u?=
 =?utf-8?B?cE01RDk1d3AwMFFzL2M1a1hZL2VVWVk1WVQ2cFgzVGJMeHBLRTE2SmM2Kzk0?=
 =?utf-8?B?YmRVTDc4M3VRd1JoRE1qT2R0Y1M5YWxqYWQ0cUF6RXRnRm1tRFRXekpJdUdR?=
 =?utf-8?B?eWRDTXlPTWdOYjh3cC9Ka09aUjB2bC9lT1RkN0NMU3FIYkZpcjVwelNGbFVU?=
 =?utf-8?B?ak1DV0lJWDhVelZ3ZTBJMmVNVklpbTA3Y0xrNlBvRkdoMEZPZGFpbFhGaUx1?=
 =?utf-8?B?UzcwcjYxU3ZWQmlodXlEelNIQll4TkJVcHpHa0lKQmRvRzRCR2E4VXFIWVBC?=
 =?utf-8?B?Y2lSV2kzOUtJSGFFQ0lrdDhJZnpxQmI2N09vWjdyRkRUQXRBUS9BTm50RFFl?=
 =?utf-8?B?UkZQOFhobC9YMFY2M2laNXFic2p0ams0Z3pPMlVhYzYxcXQzdFk1c1I3cGVK?=
 =?utf-8?B?U0VRbzdEMVR2VllPWmZpNkNYNThBcWRUbEduVzM3eW1ocXRENjRtREIyZjNG?=
 =?utf-8?B?RGtMUk1NS1JXWWdZelRoMjFsSkppU3pVWnRsMHc5bjR6ejJCd3pzclNYa2Zy?=
 =?utf-8?B?bmtMSkQ5Qm94WitrbHQvNFhBb1BrZnFKMHcrSWFEdHFDNHJYOU8xWCtqVEZw?=
 =?utf-8?B?UnNJRHFKRlFnalg0VGJCd0lTSXJGV3FBREZZY0ZrUlE4S2h2ZUhSbk11b2dV?=
 =?utf-8?B?WEJDRnkydjRSVjRaZnJaQVFrUkMzUVg3VWp6amIvUHpIejdGbWpDN2JCS0tj?=
 =?utf-8?B?MzF5WkN2blZEL1JTWk82cnJyUWNzTGlkZUtPSFZFNnFqc3RWZkU5NFpMakUv?=
 =?utf-8?B?OEMvVEZ2eEZac3VLV01nMmdKUGRRM3lzUC9Xb1BoeVFNeCtNZDZYdFpvYXBh?=
 =?utf-8?B?dkRNeWxvellZd2NSSlFjakJQQWprRlk1WDJ4ZDZleFE2VWs2U0JBM3RVQ2ow?=
 =?utf-8?B?UFhXMmN0S055blYvLzRaSnMxcytqb0pYcXE0cmk0Ymg3Yy9KdVhNOTB1YjBI?=
 =?utf-8?B?eTdHOEdZT3kvZmJXYkxnZHhMSlpUTU9yc1JoSjN4K2k1K0REU01OcFVCbGFW?=
 =?utf-8?B?YWRGTVZ1alFEK29NeHp5ZWRlWkFHeG0yUHY3a1Z5VGd1S2RVbnB1b2FCTHJw?=
 =?utf-8?B?VDM3b0s0cy9sZkZhOXdOMmVVcmZPSXl2VTBZejU4VGxNSXFSZ2Y0a3hqdE5u?=
 =?utf-8?B?czhXSWpTMGQ3TkY1TFh0Y2RVWHpMSUVxbUcvT1JYa0FabzV4QWFsUXgzUFJs?=
 =?utf-8?B?MVU0clhWNWdKMGtVMGN5Z2g0TzlCK0NnazNaRjVmSndJb2ZSV1VCSnhGSlg5?=
 =?utf-8?B?N2dvaTBNMnRQSjl4MWJ4TzMrQzVaMjBjcDJaOG5vS1lxczdPZGxROHIzMXNv?=
 =?utf-8?B?cktyRTBuMngreXk3RmJCZTlGTndYYytwZGJmK1RhUllPOW9vZ3QzdmlONklK?=
 =?utf-8?B?RUE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: e2bf2eea-bbc3-4be5-a7e4-08dc16cb8554
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jan 2024 19:44:15.2850
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WcSQySJZEjiQWrnKLlTyX06MUhKmy/7tzaWP91r00Oq2kMGrJb5glX7yyiFSYHPcqjBfIo7hG2BYYCJ3XaN4UPBozWAzqPWLUvmqb6Kwikk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5281
X-OriginatorOrg: intel.com

Hi Babu,

On 1/15/2024 2:52 PM, Babu Moger wrote:
> If the BMEC (Bandwidth Monitoring Event Configuration) feature is
> supported, the bandwidth events can be configured. The maximum supported
> bandwidth bitmask can be determined by following CPUID command.
> 
> CPUID_Fn80000020_ECX_x03 [Platform QoS Monitoring Bandwidth Event
> Configuration] Read-only. Reset: 0000_007Fh.
> Bits    Description
> 31:7    Reserved
>  6:0    Identifies the bandwidth sources that can be tracked.
> 
> The bandwidth sources can change with the processor generations.
> Read the supported bandwidth sources using the CPUID command.
> 
> While at it, move the mask checking to mon_config_write() before
> iterating over all the domains. Also, print the valid bitmask when
> the user tries to configure invalid event configuration value.
> 
> The CPUID details are documented in the PPR listed below [1].
> [1] Processor Programming Reference (PPR) Vol 1.1 for AMD Family 19h Model
> 11h B1 - 55901 Rev 0.25.
> 
> Fixes: dc2a3e857981 ("x86/resctrl: Add interface to read mbm_total_bytes_config")
> Signed-off-by: Babu Moger <babu.moger@amd.com>
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=206537
> ---

Thank you.

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette