Received-SPF: pass (google.com: domain of linux-kernel+bounces-28043-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
From: Heiko =?ISO-8859-1?Q?St=FCbner?= <heiko@sntech.de>
To: Rob Herring <robh@kernel.org>
Cc: Tim Lunn <tim@feathertop.org>, KyuHyuk Lee <lee@kyuhyuk.kr>,
 Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
 Conor Dooley <conor+dt@kernel.org>, Chris Morgan <macromorgan@hotmail.com>,
 Tianling Shen <cnsztl@gmail.com>, Jagan Teki <jagan@edgeble.ai>,
 Ondrej Jirman <megi@xff.cz>, Andy Yan <andyshrk@163.com>,
 devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
 linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject:
 Re: [PATCH] dt-bindings: rockchip: Fix Hardkernel ODROID-M1 board bindings
Date: Tue, 16 Jan 2024 20:55:35 +0100
Message-ID: <47795047.XUcTiDjVJD@diego>
In-Reply-To: <20240116192605.GA274661-robh@kernel.org>
References:
 <20240115145142.6292-1-lee@kyuhyuk.kr> <2421144.zToM8qfIzz@diego>
 <20240116192605.GA274661-robh@kernel.org>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"

Am Dienstag, 16. Januar 2024, 20:26:05 CET schrieb Rob Herring:
> On Tue, Jan 16, 2024 at 09:31:35AM +0100, Heiko St=FCbner wrote:
> > Am Dienstag, 16. Januar 2024, 08:24:44 CET schrieb Krzysztof Kozlowski:
> > > On 16/01/2024 03:00, Tim Lunn wrote:
> > > >=20
> > > > On 1/16/24 01:58, Krzysztof Kozlowski wrote:
> > > >> On 15/01/2024 15:51, KyuHyuk Lee wrote:
> > > >>> The vendor in ODROID-M1 is hardkernel, but it was incorrectly wri=
tten
> > > >>> as rockchip. Fixed the vendor prefix correctly.
> > > >>>
> > > >>> Signed-off-by: KyuHyuk Lee <lee@kyuhyuk.kr>
> > > >>> ---
> > > >>>   Documentation/devicetree/bindings/arm/rockchip.yaml | 2 +-
> > > >>>   1 file changed, 1 insertion(+), 1 deletion(-)
> > > >> You need to start testing your patches. Your last M1 fails as well=
 in
> > > >> multiple places.
> > > >>
> > > >> It does not look like you tested the DTS against bindings. Please =
run
> > > >> `make dtbs_check W=3D1` (see
> > > >> Documentation/devicetree/bindings/writing-schema.rst or
> > > >> https://www.linaro.org/blog/tips-and-tricks-for-validating-devicet=
ree-sources-with-the-devicetree-schema/
> > > >> for instructions).
> > > >>
> > > >> The DTS change will break the users, so would be nice to mention t=
his in
> > > >> its commit msg.
> > > >=20
> > > > I notice there are a couple of other boards that incorrectly use=20
> > > > rockchip as the vendor also:
> > > >=20
> > > >            - const: rockchip,rk3399-orangepi
> > > >            - const: rockchip,rk3568-bpi-r2pro
> > > >=20
> > > > Perhaps these should also be fixed at the same time?
> > >=20
> > > What is happening with rockchip boards?
> >=20
> > Copy-paste stuff ... boards using rockchip,boardname instead of
> > vendor,boardname for their compatible.
> >=20
> > I do remember us noticing this a number of times on some boards
> > and requesting fixes, but looks like some slipped through.
> >=20
> > So I guess Tim is suggesting changing the compatible, but with boards
> > being merged a while ago, this would break backwards compatibility.
> > So I guess both the Orange and Banana Pies will need to live with that.
>=20
> You may get away with it because we generally don't use the names...
>=20
> Though there are some discussions to start using them to select dtbs by=20
> bootloaders.

Ah, that's good to know (both points) ... so essentially right now would be
a good time to do what Tim suggested, before the names get actual usage.

@Tim: is that something you'd want to do?


Thanks
Heiko