Received-SPF: pass (google.com: domain of linux-kernel+bounces-28262-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Tue, 16 Jan 2024 21:43:09 +0100
From: Pavel Machek <pavel@denx.de>
To: Sasha Levin <sashal@kernel.org>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
	Dmitry Antipov <dmantipov@yandex.ru>,
	Christian Brauner <brauner@kernel.org>, zack.rusin@broadcom.com,
	mcgrof@kernel.org, pstanner@redhat.com, nick.alcock@oracle.com,
	code@siddh.me, ddiss@suse.de
Subject: Re: [PATCH AUTOSEL 5.10 01/10] watch_queue: fix kcalloc() arguments
 order
Message-ID: <ZabqXRf4X7wUgeqL@duo.ucw.cz>
References: <20240115232818.210010-1-sashal@kernel.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="ynXok9RdLEYysjzt"
Content-Disposition: inline
In-Reply-To: <20240115232818.210010-1-sashal@kernel.org>


--ynXok9RdLEYysjzt
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi!

> From: Dmitry Antipov <dmantipov@yandex.ru>
>=20
> [ Upstream commit 1bfc466b13cf6652ba227c282c27a30ffede69a5 ]
>=20
> When compiling with gcc version 14.0.0 20231220 (experimental)
> and W=3D1, I've noticed the following warning:
>=20
> kernel/watch_queue.c: In function 'watch_queue_set_size':
> kernel/watch_queue.c:273:32: warning: 'kcalloc' sizes specified with 'siz=
eof'
> in the earlier argument and not in the later argument [-Wcalloc-transpose=
d-args]
>   273 |         pages =3D kcalloc(sizeof(struct page *), nr_pages, GFP_KE=
RNEL);
>       |                                ^~~~~~
>=20
> Since 'n' and 'size' arguments of 'kcalloc()' are multiplied to
> calculate the final size, their actual order doesn't affect the
> result and so this is not a bug. But it's still worth to fix it.

Not a bugfix, please drop.

BR,
									Pavel
									--=20
DENX Software Engineering GmbH,        Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

--ynXok9RdLEYysjzt
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCZabqXQAKCRAw5/Bqldv6
8sy4AJ48W6k2JPWpiIdoOOSsvyaGuUWJhwCdFtc8G45hj7QvRwAdO840zEPPBOA=
=ZAQg
-----END PGP SIGNATURE-----

--ynXok9RdLEYysjzt--