Received-SPF: pass (google.com: domain of linux-kernel+bounces-28265-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Tue, 16 Jan 2024 12:44:38 -0800
From: Dan Williams <dan.j.williams@intel.com>
To: Samuel Ortiz <sameo@rivosinc.com>, Dan Williams <dan.j.williams@intel.com>
CC: <linux-coco@lists.linux.dev>, <linux-kernel@vger.kernel.org>
Subject: RE: [RFC PATCH v1 0/4] tsm: Runtime measurement registers ABI
Message-ID: <65a6eab6ad920_37ad29424@dwillia2-xfh.jf.intel.com.notmuch>
References: <20240114223532.290550-1-sameo@rivosinc.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20240114223532.290550-1-sameo@rivosinc.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?iCZ60zhc5CqJ6pg2EDhaVMaNrN64WFeDYFw5Y69BTy6YInEZt68QUjmKfrtv?=
 =?us-ascii?Q?+6bPVetE7TyfG51XTu868Qboo4VuBbAkaEntwa2NPgTSDx7GBYH3chrfeexv?=
 =?us-ascii?Q?SJP2ttmf5UGP3RNBjK55jk94nL7lpe/NOQ2xpUZyjPR9e08ZNLeSL8qbh66x?=
 =?us-ascii?Q?LnYwtYTTSp9fK2HHeFsqdFtSdwdrerhzYvpNqxiKgLyvX803jaqNY90iEkTo?=
 =?us-ascii?Q?BftUbbXyRcLwQAoDcRA5TbB9zOFxZNaINKQMKYgzruGXZfpvSowyvrem80bO?=
 =?us-ascii?Q?0z7Djs3DVEhaNdoVGZacQBQTp4qOWC2Hb5NKmYVWj6Gn/BH+jcRt7yKi+Qmb?=
 =?us-ascii?Q?NQnqbpWcaqvsN06qWTsNEFvDMUiASBuUN/6eGN1Xtcwyr5iVaUf+EO8OWb5C?=
 =?us-ascii?Q?6zxucbiNBXHj4MuozTp0hRv+IpQyv3n/vGE9te78+iRdgHPgQnkQ5D5sns6D?=
 =?us-ascii?Q?RkGyi7arj+fqeBKkYYOoLV787itqzpg0tBun9BWuX1EMIFNG6iEyh66dCthX?=
 =?us-ascii?Q?f/YwxafT8vz6kD90crO2RHwzlvk/lx85Uk3JcnEjZxYC1foAmYEN17PoZPm4?=
 =?us-ascii?Q?N+iIYadq73fKhRdpx+mLOCsh5Vi6XqHK+/kPrrPQuueQ5Rt0iQQmIscZGhtP?=
 =?us-ascii?Q?5F5jnoRYFA1kzVmFFW4OBpGHQxLB5J8OXZQn6bnrVuYCfGDY4qVQKEZXQjwD?=
 =?us-ascii?Q?WZ97utPR51JBcjOo4ilK7NJkAAn8o1g0FN6orOPuYKv3tqSVEud+plLMfL4h?=
 =?us-ascii?Q?w44w6AlJAKvRNv8hVpU4O6GM/5KuxulkpbnlJdLstzDgMzZfEPNvdkIbXnMD?=
 =?us-ascii?Q?1i+QUy2fbb+WrAlY5GKJhN6pQupYdteSi3NugvxZvT/lpx0OvRYy2fzschGn?=
 =?us-ascii?Q?f0RqlAiQxTBDGCEFS07gacIKTF2aMWPAy1uwgc924BDkeyxYHmWmBzAQioV7?=
 =?us-ascii?Q?vL7zhfQFrEskJXjE5FEWUF1gRpKJWv03onyTPd1iKcg4wBsI+n0R2HUD1F7K?=
 =?us-ascii?Q?Rv1f/q8/VyHnbAs6cnTWUdmNmUXg8oBLz8l/PcyR2YxNgL30+s5On7Va686L?=
 =?us-ascii?Q?sIzAC18alXyD+SWuB+2nbLzqiaJ19dLQMpazGAAm61ckgcpopJecWeMPE/eh?=
 =?us-ascii?Q?haR+wbG1jliKdCisD9wfxa4oPQfrR3dJ2Cz63FvmenWdKoqEHvyn2uj+agto?=
 =?us-ascii?Q?kBORYwgfGaoGpVzBY7bY1FccUvtEK8J26aUAOLfCdlN02GV9NQNJFpduVDst?=
 =?us-ascii?Q?1uCsB9NqpLzse71vfv/XvTZGIopIADWF9rWRuh04da2rm7M/+9/JS+mQ6BYh?=
 =?us-ascii?Q?yVYzlPgcPTml710X9JHT+HNWWc8PAA/3F2AHxQ3UXrOhv6zU6Asr7mqb0jlW?=
 =?us-ascii?Q?QGDvRTHiZgg/wCzBsF5PbO1ttluJb70HBILZIUWIQwg7cDJLDNJ/Aw3vb/8S?=
 =?us-ascii?Q?XFXsULekDGPkN9L6v+7j3w4gMaTag7kwbxKJ4oEhpdNMAx+9JWDBAEipGQod?=
 =?us-ascii?Q?PF4RpQz6RKQ6x5kVh3RKw+lVcMejFj2Es69ulisU0KlKPAtb0n01ccFByvnq?=
 =?us-ascii?Q?VeaLu7zYPrCYg9EZtgm8lQO7uiUv+XHFhFguJZ5wLwgBx1Rtj0ijgBQWhUZV?=
 =?us-ascii?Q?Nw=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: f1cbd81b-f96d-46c8-ca45-08dc16d3f64c
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jan 2024 20:44:40.7131
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Ju1rh5FWAszlSJyGbwdVrSz4FmnwCDnKizqZxI8l+tWHJg0NxAW7Wdr6Enavj+5l2z8SyKmP0gxS8gGmnhDT0kMmxzP7YABwWviuaBoORac=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB5001
X-OriginatorOrg: intel.com

Samuel Ortiz wrote:
> Some confidential computing architectures (Intel TDX, ARM CCA, RISC-V
> CoVE) provide their guests with a set of measurements registers that can
> be extended at runtime, i.e. after the initial, host-initiated
> measurements of the TVM are finalized. Those runtime measurement
> registers (RTMR) are isolated from the host accessible ones but TSMs
> include them in their signed attestation reports.
> 
> All architectures supporting RTMRs expose a similar interface to their
> TVMs: An extension command/call that takes a measurement value and an
> RTMR index to extend it with, and a readback command for reading an RTMR
> value back (taking an RTMR index as an argument as well). This patch series
> builds an architecture agnostic, configfs-based ABI for userspace to extend
> and read RTMR values back. It extends the current TSM ops structure and
> each confidential computing architecture can implement this extension to
> provide RTMR support.

Hi Samuel, this looks like the right direction to me.

One of my goals at Plumbers was to explore the tension of the perception
of RTMR being a one-off (Intel-only) solution, and that the ecosystem is
otherwise best served by preserving TPM ABI momentum.

This submission clears that first concern, several vendors have an RTMR
concept. The second concern, after talking with others, is that a
soft-TPM (e.g. vtpm_proxy) backed by RTMR can support the TPM ecosystem.
Such a layer on top of this achieves TPM support for several
architectures at once which seems the right thing to do from an upstream
maintenance perspective.

I will likely have some questions about the details, but that basic
"should we do this" threshold in my view has been overcome.