Received-SPF: pass (google.com: domain of linux-kernel+bounces-28282-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: Eric Mackay <eric.mackay@oracle.com>
To: linux@armlinux.org.uk
Cc: Jonathan.Cameron@huawei.com, Matteo.Carlini@arm.com,
        Valentin.Schneider@arm.com, akpm@linux-foundation.org,
        anshuman.khandual@arm.com, catalin.marinas@arm.com, cl@linux.com,
        dave.kleikamp@oracle.com, eric.mackay@oracle.com,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux-mm@kvack.org, robin.murphy@arm.com,
        vanshikonda@os.amperecomputing.com, yang@os.amperecomputing.com
Subject: Re: [PATCH] ARM64: Dynamically allocate cpumasks and increase supported CPUs to 512
Date: Tue, 16 Jan 2024 13:06:44 -0800
Message-Id: <20240116210644.116421-1-eric.mackay@oracle.com>
In-Reply-To: <ZaZnYrv/QThRjW2Q@shell.armlinux.org.uk>
References: <ZaZnYrv/QThRjW2Q@shell.armlinux.org.uk>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?SDz4XUKTCO4JWzCEBxu5dKrCgKstchGn/PNPHfDpoUavz3bTkrm+MiloPEJL?=
 =?us-ascii?Q?GYoC7zr/53+C+vRYoh1t5pGUNrxXpesBTOtc0vaZ+y+g/D3HKmx7QMzdQRhr?=
 =?us-ascii?Q?+GH463MS0/CFZuUbGteKhbg0ZgYYw4QFZ3q0099yvvNrk0SfhNdS1KsamiSV?=
 =?us-ascii?Q?/b7CSbBeYpEwHXEq0GH1HR+xHsGHCarhsYsniWM5Ap+T/mmr2rC7ZZ50abvD?=
 =?us-ascii?Q?GWmlhxkt5M/Ah7DI3sSWm+ZiLUXZMcdG49LVVqk/zrTJPuDSAbUzen1Pnwst?=
 =?us-ascii?Q?XICz+ZC2Pz2WSx5N2fBsd6v5LaNZiiU4KXXpZwjFzz24DMjkeWj4ec+kwLf8?=
 =?us-ascii?Q?zF6yrjF1XNXiGXdnAWTLc6jXB8QcoCqDwYph59Z54gctI6j3OSGzV7VGoJYb?=
 =?us-ascii?Q?vtMaGFJT3N59cuaQRIYOIhVhtX8mP8efpYN5NfBDZ1YUT2nj9Msm9fnbrrHP?=
 =?us-ascii?Q?iBkUYcx/GGy4q3fYxHQYKtvrcnyiOHSe4fuwwe/oscj+6Kp47U5vFkq+jTSU?=
 =?us-ascii?Q?Me3f3aS/dWGdU1JijE6jD6/bQKdgkwGIz4DzGiHDTiSsaSllBapWhzRw4++R?=
 =?us-ascii?Q?kzXGthuNYZFLOgdGLpdUZX1rW9q++wQvE2LzntHV5diDRXZjajWdRUOSWnOo?=
 =?us-ascii?Q?pXAJNrb6SAnCXumxg0B9Ip07IsqiOtiJbJdL1MsYPkme6b5eXZpfQS4J+IXJ?=
 =?us-ascii?Q?acG/9jM4/uYdyWksF6fLNpYYOBP+2ejsArtLGA+7vhAlGxsLjAbEd4EZZktT?=
 =?us-ascii?Q?9PwvGTjqp4l4MGJvWcN+6qxORReMaF2AkMYkHrRwnUyBkqsv6nTGzPNHOaPX?=
 =?us-ascii?Q?F/+8pShzi8ocX3m/uVlxohKcBlrjyr8zflcY8ImBJv0nHE7fd56pgrvNgJfn?=
 =?us-ascii?Q?RhgYgN4zDfhMcN5RKT/r529QFgcSoH9R+0OUoyq54VY0tuALnhJxs7El97WM?=
 =?us-ascii?Q?by+ZqrhktdwH4sM4l2K5rTeM0IpGlyBCjV25zX6Iq7fJIgcHXcE3EJ4dK6xX?=
 =?us-ascii?Q?FSQPITHilv+YxVf4FUCYQuhvT/a4W4b6eosBFlOjsJCFkoC0CJvCuCKXG6ce?=
 =?us-ascii?Q?2/iTxwbhCgev6PCIiBansHQjWOfUeF4kwaflfHYc7ZadPMWhIkDX51sInM8I?=
 =?us-ascii?Q?mnGHfWqOAxeM5+OHHsx/yAlVwu+JyriXImffv8wkmvdSdzZUZokDrCFev9+B?=
 =?us-ascii?Q?QT3Z4IoRLola8ZtD1Lj6yuzmkN/HFjGgLxHvZaTQgqZWSexhflA8+NRjylLW?=
 =?us-ascii?Q?Wste4NYwMAI1l6ABH9C+eHCbn1kZ+HzQFc0A+0SY7BTB9I4O5CGiKJpTF3KY?=
 =?us-ascii?Q?y8EYVpgUfW821DPrI0ZFi8uHF2z2F3UXNrqycWgQjJd02x1dvwVc70mFq5ct?=
 =?us-ascii?Q?XJQL4HXX7rVton3YUrCyrlEQUWfWsfUaa5hxSjXX1wuj5YCfIMvYNm2xa+uk?=
 =?us-ascii?Q?MF0cGTMfU981I2SAjzgojBS4CBHRD5amIuFOpcfpe6jVJJJBTo38G6n4IsBr?=
 =?us-ascii?Q?HBVzU8Ko3h/bw3TZW9HZjDoW2Vllj6XAWke3QFpgK/l2mR1Mh+6heB8p9P3v?=
 =?us-ascii?Q?xauu5kTy9aLhOMFe8t/YmdhIY9WrMqjxQEj33geyqcnDyHxI73GCVJ8f6WrN?=
 =?us-ascii?Q?DQ=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	Yth/4jNOPZupLMHZBtAGSMOk+RLORMCBd5s4vgeiXLPKsIzxUAMBIhrFFQhlCyVul01mTILjjbGx9mIJCnbEFxuv2ZHXhpa/WfFggKivUGtMSG1uAbAaAsHIzwd+qdGDph5CjETLEWjBGGxNGcUy5xyRNzVoOIVUTlAxQMuIydJwpvXzt1CtJRAsZiv2K5/UpFbd4FCV7v/5EI8L/a51tQ42oBu42Zs4ARn7q8NV9hC5+ZeE09fanACzhty4K7hPBlSQ/LUPwESua4lvJ0cLYr5npwMH8+Gbf9RUcbUsHGaOMc02lwmWRcgRPue2M4wUVBu3KHsH3GmF7upL9RXsurpqvy+3Icsg5ZIqKQrgMTvaW63krZdmICQ2fOJJ0f1M8fKEQHrJypIGBYYirYtjRKYd1DBJHkONS6cLjjC+ENJ3NPYIF59p9yWhkxbjJD6um+K6dRae6KuzQqs4EBe8fZi+3OHTn1PCbKqWh85rlvNmjNWmDCoDIn3sgj4RUttUjZyV+ouMMbYJsm/sUNHk6giudsSRoEAcpV1gTfp+48/T9lafL9r2ZptXj/SCLeZ2Kn2BHP5u9lp8hx1PN1Z66Ahr0GYdJ95w7bA5Gkgk5W0=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f1e7d499-4d27-4258-08c5-08dc16d70d8d
X-MS-Exchange-CrossTenant-AuthSource: CO1PR10MB4418.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jan 2024 21:06:48.2261
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: IgoBuHh6hmRL+KHR2NE66XcmuxhCRa+n0GYszZzeJgSA5rds6zJh8DzqKbKknaaS0SdZzgwWVZZ8AQvtsBEkiA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR10MB7261
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-01-16_12,2024-01-16_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 suspectscore=0 bulkscore=0
 spamscore=0 mlxlogscore=999 phishscore=0 malwarescore=0 adultscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000
 definitions=main-2401160166
X-Proofpoint-GUID: LmQcmxhdkejQsFwrhWB57M6Tf-Omq4Ex
X-Proofpoint-ORIG-GUID: LmQcmxhdkejQsFwrhWB57M6Tf-Omq4Ex

On Tue, Jan 16, 2024 11:24:18PM +0000, Russell King (Oracle) wrote:
> On Mon, Jan 15, 2024 at 03:59:11PM -0800, Eric Mackay wrote:
> > Whitespace issues aside, I have applied the patch on top of kernel 6.1.55 and tested on both a dual-socket Ampere Altra machine with < 256 CPUs, and a dual-socket AmpereOne machine with > 256 CPUs. Works as expected, with all CPUs visible and functional.
> > 
> > >   config NR_CPUS
> > >   	int "Maximum number of CPUs (2-4096)"
> > >   	range 2 4096
> > > - 	default "256"
> > > + 	default 512
> > 
> > Nit: the new default value should be in quotation marks, if we want to be pedantic
> 
> I can't find anything that requires the quotes - and as "range" doesn't
> for consistency it seems that default shouldn't either. There's nothing
> in the documentation that indicates quotes should be used, and looking
> at the code, it's just treated as a string. The only thing that quotes
> seem to do is to ensure that whitespace will be included.
> 
> -- 
> RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
> FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!

Ack. I withdraw my nit.