Received-SPF: pass (google.com: domain of linux-kernel+bounces-28306-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Tue, 16 Jan 2024 16:31:22 -0500
From: Frank Li <Frank.li@nxp.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Conor Dooley <conor@kernel.org>,
	Conor Dooley <conor.dooley@microchip.com>, robh@kernel.org,
	alexandre.belloni@bootlin.com, conor.culhane@silvaco.com,
	gregkh@linuxfoundation.org, imx@lists.linux.dev,
	jirislaby@kernel.org, joe@perches.com,
	linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org,
	linux-serial@vger.kernel.org, miquel.raynal@bootlin.com,
	zbigniew.lukwinski@linux.intel.com, devicetree@vger.kernel.org,
	krzysztof.kozlowski+dt@linaro.org
Subject: Re: [PATCH v2 2/7] dt-bindings: i3c: svc: add compatible string i3c:
 silvaco,i3c-target-v1
Message-ID: <Zab1qj3+6daX8QH0@lizhi-Precision-Tower-5810>
References: <d45e31c4-914e-4cea-a145-9775b6f516ab@linaro.org>
 <20240116-bleach-herbicide-48d636967134@wendy>
 <3199c245-3d2d-49e8-951e-2b059de4d683@linaro.org>
 <20240116-achiness-thievish-10a12b3c08cd@wendy>
 <Zaa+cLGVVDSB5MYr@lizhi-Precision-Tower-5810>
 <20240116-retract-conclude-c47a7fc8cb21@spud>
 <ZabVSYgq1Mz3LPpC@lizhi-Precision-Tower-5810>
 <4a9ed1ca-cd13-4b61-af06-a3d7935aeeee@linaro.org>
 <ZabqxHD4wtiPn6ep@lizhi-Precision-Tower-5810>
 <c760b89c-efec-489e-8333-c60b38fb5a47@linaro.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <c760b89c-efec-489e-8333-c60b38fb5a47@linaro.org>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?mdzvnar0aNQ04yLrosFEvM9osILalEHahv7Mwp4xLaOJZ+s4IZSl7711yswl?=
 =?us-ascii?Q?RmqH3rh/ZaADyaVK1a/2reNkFUBPMnSX5QRZjcnWZ+eDOsW8wFP+HjOdmL4D?=
 =?us-ascii?Q?Sob/cFT7xiEpjk5EDU4ntjrWXeQ7u970Ni+Kfulv5q71WZDn3z5ybbrkEVsq?=
 =?us-ascii?Q?D26sM6uGEpXSUXXcOLw/UuTghrF0YUMbDJEUpxKAtfdGXeoLDCD7NHerWhKr?=
 =?us-ascii?Q?12Us7RaRuwqpx2aFhIFs1rM4KwjJEMsWXJUn7Jvvil0Z5pc4vIRvnVj497kK?=
 =?us-ascii?Q?xY1Z0VgioZfaCTZa3C18XcMzOEiCHHk7rD08q3bewtx3sqw0POaUv+82vGwa?=
 =?us-ascii?Q?2C0s6hVPoDp630WFXI1UqvhTB+JxERUe6pmq3b3YLFySOJo5dXJSfFaprowz?=
 =?us-ascii?Q?yk4b5uQ7BJw0uIj1ALUJHZMxm3cdhBhhz7ojcekHrlVuj2DINGRCLbTkqx4J?=
 =?us-ascii?Q?DstxqJdfaIbyz9Q40qcBEU3EjaurB4kYZmMeRMLZpdy06+3XPJa/znMrVPDh?=
 =?us-ascii?Q?ez9MH1t6u2Ujj+P0NB9+gicdVfCyolSNg8rAp+lvs0TrzcrFIF48KDY/rZ6h?=
 =?us-ascii?Q?qjP1dUFC4sltHF/IHFUW5vE9rq3n+l6I7stb7uEbAckANCeJp48slQ8mIqgP?=
 =?us-ascii?Q?K9cwsvGNbVIkm9SFyNaHy49omChxIgtuGp21Br9cugsTY3GCkjbhhGywp8J1?=
 =?us-ascii?Q?wS3XZJbovFXMjBLu0QjbUS0xbggXYMzYOQI0HabRg7im5rSpQabMw5o0ZtVF?=
 =?us-ascii?Q?DYdP7bcKIpBvKlqBTonGQoYIfCFCTh5mrHNyQKDCK2HrdWJZJdClNxUHlBBk?=
 =?us-ascii?Q?fbAUCA6Qr3+uh1A9ycqUaFlzFmqnPZExduYHh3GKkuS3IJQJ7f/G7hbNwKCc?=
 =?us-ascii?Q?J2v6stNtUBLCydbxF8QJrV9jMmsybdrY8PR8hWz7t2txem2j6wYoWSbn9x8j?=
 =?us-ascii?Q?D06wnKtMS00a49qvG0rrNHptWgYDsS5BaDXYcTsFoKCF0fnrpBV7IkHUELwq?=
 =?us-ascii?Q?Omas6ygLYyO8IRJlCVmM/pNCU6EMi69vLfOO//iuyrP3re2CZN6/F3ek8ho7?=
 =?us-ascii?Q?OhoP50js/1Ay5y54TE30z9c0BNAf3KhFafiHb/SwAwaZ195DibMmwtvU87K3?=
 =?us-ascii?Q?MPZlP0gYiiHlTD4zAyT9h7UERPO7Ga6s7onPNCtMcreoM745EzzV6oRabc3F?=
 =?us-ascii?Q?zfC2cJTe6X7wBc00q2pinA/YMIx3UOJcRfkO063DzjI9Ultk1Sm3XKQfFbJ1?=
 =?us-ascii?Q?fLdjbfZ4gpwkCgR8T1kQEyrMMC0bC5tdLqICSw7wYoqH7CHQu5TEWgXWBeHo?=
 =?us-ascii?Q?O/2ad/ZgAwBAtSlZaajhF+DfO2xp9vHgjef23eEpRNJ1iKeFSGVm1HBMOggQ?=
 =?us-ascii?Q?mLTKSrjjoozlkMP6xEoJh5RaSjzMVmhALAyhKiZdcG3AdbGaLswkH8IP3gq5?=
 =?us-ascii?Q?qWdCdoORRNgQu8V28ZPcMtu9l8EVN43lw3asUi1Q2HphjrNjdmZqh/6vRTA2?=
 =?us-ascii?Q?znjmvhUjTcRQXsdo+dh3U/eZ5qQh6LyVE+Ce4hDKw4i7LeiGp5mS6OM5siaD?=
 =?us-ascii?Q?fkVW7nq7vEMwOX4iHqs=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 82b99023-1c1d-48db-dd04-08dc16da819a
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jan 2024 21:31:31.4099
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bRL9gIuejYMhL17XZ08w1DOHoDFKLMjbGBUvNK0iLQLJd2khMpFMP0688U86ADD8FzFnU0vwQmPtj5OL4C1rEQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7347

On Tue, Jan 16, 2024 at 09:56:03PM +0100, Krzysztof Kozlowski wrote:
> On 16/01/2024 21:44, Frank Li wrote:
> > On Tue, Jan 16, 2024 at 09:30:24PM +0100, Krzysztof Kozlowski wrote:
> >> On 16/01/2024 20:13, Frank Li wrote:
> >>> On Tue, Jan 16, 2024 at 06:23:09PM +0000, Conor Dooley wrote:
> >>>> On Tue, Jan 16, 2024 at 12:35:44PM -0500, Frank Li wrote:
> >>>>> On Tue, Jan 16, 2024 at 09:48:08AM +0000, Conor Dooley wrote:
> >>>>>> On Tue, Jan 16, 2024 at 10:33:48AM +0100, Krzysztof Kozlowski wrote:
> >>>>>>> On 16/01/2024 10:30, Conor Dooley wrote:
> >>>>>>>> On Tue, Jan 16, 2024 at 08:24:20AM +0100, Krzysztof Kozlowski wrote:
> >>>>>>>>> On 16/01/2024 03:29, Frank Li wrote:
> >>>>>>>>>>>> 	Patches were accepted after discussion, what you ponit to. So I
> >>>>>>>>>>>> think everyone agree on the name 'silvaco,i3c-master-v1'.
> >>>>>>>>>>>> 	I plan send next version to fix auto build error. Any additional
> >>>>>>>>>>>> comments about this?
> >>>>>>>>>>>
> >>>>>>>>>>> I still do not see how did you address Rob's comment and his point is
> >>>>>>>>>>> valid. You just did not reply to it.
> >>>>>>>>>>
> >>>>>>>>>> See https://lore.kernel.org/imx/ZXCiaKfMYYShoiXK@lizhi-Precision-Tower-5810/
> >>>>>>>>>
> >>>>>>>>> First of all, that's not the answer to Rob's email, but some other
> >>>>>>>>> thread which is 99% ignored by Rob (unless he has filters for
> >>>>>>>>> "@Rob"...). Therefore no, it does not count as valid answer.
> >>>>>>>>>
> >>>>>>>>> Second, explanation does not make sense. There is no argument granting
> >>>>>>>>> you exception from SoC specific compatibles.
> >>>>>>>>
> >>>>>>>> The patch could have been applied two months ago had Frank done as
> >>>>>>>> was requested (multiple times). I don't understand the resistance
> >>>>>>>> towards doing so given the process has taken way way longer as a result.
> >>>>>>>
> >>>>>>> I think that Rob's comment was just skipped and original master binding
> >>>>>>> was merged without addressing it. I don't want to repeat the same
> >>>>>>> process for the "target". Indeed I could point this earlier... if I only
> >>>>>>> knew that Rob pointed out that issue.
> >>>>>>
> >>>>>> Oh I think I got confused here. The context for this mail led me to
> >>>>>> think that this was still trying to push the i3c-master-v1 stuff through
> >>>>>> and I was commenting on my frustration with the resistance to applying
> >>>>>> the feedback received. I didn't realise that this was for another
> >>>>>> patch adding a target.
> >>>>>>
> >>>>>> I think you already said it, but NAK to adding any more compatibles here
> >>>>>> until the soc-specific compatible that was asked for for the imx93 is
> >>>>>> added.
> >>>>>
> >>>>> Is it okay for 'silvaco,i3c-target-imx93'?
> >>
> >> No, because imx93 is product of NXP, not Silvaco.
> >>
> >> You need regular SoC-block compatibles, just like we have for all other
> >> snps, dwc and cdns.
> > 
> > "nxp,imx93-svc-i3c-target" ? 
> 
> Could be, now please point me to patch adding such code to DTS. I would
> like to see the real use case for it.

This part have not sent to review yet. basically in imx93evk.dts add

&i3c1 { 
	compatible = "silvaco,i3c-target-v1";
        pinctrl-names = "default", "sleep";                                
        pinctrl-0 = <&pinctrl_i3c1>;                                       
        pinctrl-1 = <&pinctrl_i3c1>;                                       
        status = "okay"
}

> 
> > Just little bit strange for binding file name
> > is silvaco,i3c-master.yaml.
> 
> Many other bindings do it. I don't see a problem in creating device
> specific schema sharing some parts, if you have some common pieces.
> 
> > 
> > look like "dwc,*" compatitble string's file name is "dwc,*".yaml.
> 
> ? I don't understand how is this related, but if this is what you want
> to discuss then look:
> Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
> 
> or many other examples. Please open dwc, snps and cdns bindings and look
> how it is done there.
> 
> Best regards,
> Krzysztof
>