Received-SPF: pass (google.com: domain of linux-kernel+bounces-28317-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <e8f54e2a-8524-7fde-e31b-8da9126ad292@amd.com>
Date: Tue, 16 Jan 2024 15:39:25 -0600
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Reply-To: babu.moger@amd.com
Subject: Re: [PATCH v5 2/2] x86/resctrl: Read supported bandwidth sources
 using CPUID command
Content-Language: en-US
To: Reinette Chatre <reinette.chatre@intel.com>,
 Babu Moger <babu.moger@amd.com>, corbet@lwn.net, fenghua.yu@intel.com,
 tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
 dave.hansen@linux.intel.com
Cc: x86@kernel.org, hpa@zytor.com, paulmck@kernel.org, rdunlap@infradead.org,
 tj@kernel.org, peterz@infradead.org, seanjc@google.com,
 kim.phillips@amd.com, jmattson@google.com, ilpo.jarvinen@linux.intel.com,
 jithu.joseph@intel.com, kan.liang@linux.intel.com, nikunj@amd.com,
 daniel.sneddon@linux.intel.com, pbonzini@redhat.com,
 rick.p.edgecombe@intel.com, rppt@kernel.org,
 maciej.wieczor-retman@intel.com, linux-doc@vger.kernel.org,
 linux-kernel@vger.kernel.org, eranian@google.com, peternewman@google.com,
 dhagiani@amd.com
References: <20231201005720.235639-1-babu.moger@amd.com>
 <669896fa512c7451319fa5ca2fdb6f7e015b5635.1705359148.git.babu.moger@amd.com>
 <e89278a8-cd40-4e73-ae39-800c29dae385@intel.com>
From: "Moger, Babu" <bmoger@amd.com>
In-Reply-To: <e89278a8-cd40-4e73-ae39-800c29dae385@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?K2phVU5DY0hzK2UxUjFuQm5McGNia0hWZkhNTHl1TTlMcnljaDdjNVh4eVRx?=
 =?utf-8?B?cUZ2TTFSMkd6T2hUcXFIdkxhd1Bvb2g5bmFVTUtQaGFMQVZZUmNuSlJaaEJu?=
 =?utf-8?B?UHNHbEhSU3lObXBtYUVBOUNZTld1OW1pQkVOTnlkMzAweHdBV0FvcDRrMkdG?=
 =?utf-8?B?QVRkQUVEdWROQWZkeVI0Rm0xK0phSHhnQURTL1pmUytYemFlTkZ1M01TUzJC?=
 =?utf-8?B?RjlqS2dsTHhBUlZJVXlPUDBKVkpSL1l4WXp6b0tlc3QvZDNHeStMN0ZYdW1S?=
 =?utf-8?B?RFp0VFhScTVLc0w3R2JQZ0hPQ1J2S0FuczlFM0IwR0RRTE9hcnBEejhMbkJv?=
 =?utf-8?B?d0FudWkxVks5S1NNaVhYTHR6WGdUVnkvWDl2WE5uYVI5T2l5cjBWLzdFTGlK?=
 =?utf-8?B?b3hKaG1vdWgvUmJsalIwQXBpeVFOTmN2MkRTMzBmbFc1aE05R3puSG15YTNv?=
 =?utf-8?B?SlJ2eVVzZHMvSXljNkNNeDJSbWh0ZDVXR2RHV05UcFJRZHdLUUpEM09VeTdI?=
 =?utf-8?B?elc0VjlldDdZaTlWVlZPbkJzckhLN2VVZzFMdnpvUmgvUTdLSVZkQ3YyZ0VL?=
 =?utf-8?B?a0VVQ1F0OEZuMHZ5RFdveXRDMWV2Nk5VcTJXZ1o3aXA5bTVrTEZtT3BjMkF5?=
 =?utf-8?B?d1ZrTnlpY0NNcjl2dlFNYlltL0YxQjFTVDZLR1lmSUZWN0xDaHNpRTk5Mmt1?=
 =?utf-8?B?cWc5enpvYWd2R2Z0elJFWTVHWXRvaklZbzIrRDJjR3AySHcrU1g2WllQT015?=
 =?utf-8?B?RmdGOXMyRUxoZ3hLNTJhN0NURFpMUWZWOStiSWZBUlUxOGVlMy9KZFFXUGxo?=
 =?utf-8?B?SVNMVmNlUHVmckZiaGhaSURqNzJFR3haVmVsbHROS1NvTFloSnEwV1hNekU4?=
 =?utf-8?B?WENwTTV4QXUrdHR4ZkVoVjRTOStCL25CSEJuQUF3U1g2WHpsT2VxN3l6TGts?=
 =?utf-8?B?c09RVHZEaGI4WDBzemJYYnVjVXZnNHR2SDgrMFdVZUREL0dpRWF5WEU4Y2oz?=
 =?utf-8?B?QnBZYU1jNjdlR0pzN0pvMXlxSy8wR25haktzT1pHVEVERiswR3BGWFV4bUZI?=
 =?utf-8?B?NHd4Z0lEMEc4UVBmNlhBL1krNmZySWFVdnNUUzlVRXNIL0d3Z0ZZQks1NHdu?=
 =?utf-8?B?azVyeWU5UmlSQ01kZzlXYTd6ZWxwWWZha1k2MzcrQjJSMzcvWGd0M29yWmhI?=
 =?utf-8?B?YXdVVWNpbHBHdVJkMHNXL0hlOUwrbXFlOFpNcFExNTRTc0syZ2I5ZkN0ZWFD?=
 =?utf-8?B?YUNoYUYyaW1CZzFMMFQ3dEhvdUFmR01yRnFvMXNRY0hpUVVIcXpMeUF3QktE?=
 =?utf-8?B?dnBSbEJUMkR0RTBlTlFnOHpCdHdEUUYrd1p3R2JEakJOMUdRbnphSjJGakE1?=
 =?utf-8?B?Z1p0ekt1ZVhxNW1Bd2dlcFNxYXM3emFWYjhEeElHSm9wWkJJVzVleTM3TVdQ?=
 =?utf-8?B?aWNLSk5BRHBSQ0ljcXpWODBYZHRTZHQ5cUtlUTNvajJNT2dubWpMNU8rbjlm?=
 =?utf-8?B?eFh5TkV3L2U0b3hRMmVNZlZkUWM4dXZhWTc0SkV3R0lKY3Jjcy9nSWRhOVBp?=
 =?utf-8?B?eFh6QlZJNUxrK2xMcTdsQnR6K3VpRlptd2czalBZcWI0MDM5ZjdiMkM2Wlls?=
 =?utf-8?B?bll6RHpJT2NERUxuN2ZidTljVHV3cW92WGtYMmJTeHcvU2pwOE1oZldVa0Rr?=
 =?utf-8?B?N0xtMEtuR0tRbFA5M1doYXQ3U004UkFEUG52Z0VwVy9DVlFkYkdMTkJYRVcy?=
 =?utf-8?B?SThpb25maGx2cCtUYVFvbDJwQzhNN2tpaWtIYk9QQksrK0p6MUt1YzlXTWwz?=
 =?utf-8?B?c1JJei94VkRIcjk3RkppWWROY3JEaEg1RG5scHNycEQ0eDFzUHVWcFFGenc4?=
 =?utf-8?B?L2RudEVPNGI0ajNUVnB0bW9sZmZ3ejBpZmxoSG5hZ0pRWXJPTG0vNGMvcnQw?=
 =?utf-8?B?WVBhaTR0MDdvT09VaDZaemRrQ20zV3VVSzRlMDh2QTFodVM1bkJZdnk1bEh3?=
 =?utf-8?B?ZVJ1ekVVejFKalFtZkNWY29ZTFN0VGNFNk13am5KeC9Yb3M1SDcyVUpJWGNa?=
 =?utf-8?B?a2NzRTdWMmx2STM1WHEydU03ZTlNakdwTEIxcU9UQ2MwVjZldWVRak85YzEw?=
 =?utf-8?Q?x/5GGvkhOHfTQmvFu9X0kje06?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6967c5ee-47d3-48dc-0b1f-08dc16db9f07
X-MS-Exchange-CrossTenant-AuthSource: MW3PR12MB4553.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jan 2024 21:39:30.3456
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: cM6UQTwE0gwpQqJYBu7ce7lzylbp+vDnjxpBkVeDFYBJFcAmOD5cN44Jagw6Cb4E
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB6997

Hi Reinette,

On 1/16/2024 1:44 PM, Reinette Chatre wrote:
> Hi Babu,
>
> On 1/15/2024 2:52 PM, Babu Moger wrote:
>> If the BMEC (Bandwidth Monitoring Event Configuration) feature is
>> supported, the bandwidth events can be configured. The maximum supported
>> bandwidth bitmask can be determined by following CPUID command.
>>
>> CPUID_Fn80000020_ECX_x03 [Platform QoS Monitoring Bandwidth Event
>> Configuration] Read-only. Reset: 0000_007Fh.
>> Bits    Description
>> 31:7    Reserved
>>   6:0    Identifies the bandwidth sources that can be tracked.
>>
>> The bandwidth sources can change with the processor generations.
>> Read the supported bandwidth sources using the CPUID command.
>>
>> While at it, move the mask checking to mon_config_write() before
>> iterating over all the domains. Also, print the valid bitmask when
>> the user tries to configure invalid event configuration value.
>>
>> The CPUID details are documented in the PPR listed below [1].
>> [1] Processor Programming Reference (PPR) Vol 1.1 for AMD Family 19h Model
>> 11h B1 - 55901 Rev 0.25.
>>
>> Fixes: dc2a3e857981 ("x86/resctrl: Add interface to read mbm_total_bytes_config")
>> Signed-off-by: Babu Moger <babu.moger@amd.com>
>> Link: https://bugzilla.kernel.org/show_bug.cgi?id=206537
>> ---
> Thank you.
>
> Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>


Thank you

Babu Moger