Received: by 2002:a05:7412:8d1c:b0:fa:4c10:6cad with SMTP id bj28csp46285rdb; Tue, 16 Jan 2024 14:33:37 -0800 (PST) X-Google-Smtp-Source: AGHT+IF/rR1BFsp2syX5TEYsGkpfJxNRycm6UuJro6gzaoAQiiy7vsm+APNdcLJrSHuKPCM28Ola X-Received: by 2002:a17:903:1cc:b0:1d4:d024:b5ca with SMTP id e12-20020a17090301cc00b001d4d024b5camr5257312plh.111.1705444417584; Tue, 16 Jan 2024 14:33:37 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1705444417; cv=pass; d=google.com; s=arc-20160816; b=PHh8H/BMU7UqMAOZG+0f4ni3/i7XKWGlDRkn7PfEoppLper34WlIuwbRXRMvDqhBYd tBqe5SaY6vV4Dk4nzFBsW9hr1o2SlOuLnwoV5CWh/b+HGk6uHISZR2sVGESQq4E2WE1G bN++t1okHMiawKC1oO11mUWBuL8OkivcxlgwFfAiUnoukX9rrbjQPx4AlyxQ7vaTT8Ov 6Hf67mtRun83WbrGyY4pkz9TZm1+y+2r6xu5ez/St+TI/e6zUI2U+wYKejYgh1FqBHbE Z+94oM/UFOLee4bGuDNsNpAdnvX7nF9T9PSoTRohsUfXroVcsGvBSlVlQzXm188eOMXZ Gt6w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=sqRPOFeNao0i7ZbF0Cd/T0E9SrjM9ty6IYml6ss+0UE=; fh=NP2HXdf1+4+vyXJ4T6uecRreLSISREykUB7bJqwN2iU=; b=wiqPqtBIrXzHzgeg2FsZzc9GgA0xEAilQgdix+pDyH4YIjgVKvGBVxYpa0nWJWliNA X61GIO7k54rOgGnfjEWBtyhvSMb7jn+7rkz7M1hsdn1GB3LNIMOEiL7QP1B8DQdc5r+V jRSmsTsaROZ68W/MAVDwItk/Zb9zbBTloKDwn+Wqoh4qbdJ5flrtsXcUP3w0GMc+epb3 s5H3+jjHb9plkOWjMKgNiUtk9mg9wEdRggY2Q+BCd3vPKuNAR6Ii/StI+UvMt6V1kQq4 4r99fDetxRCiMMsFXZmmft8ESWXvbmnGANHHhc13b6Arcu2ZURLToAx7u6gPndzYhOxT jpTQ== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=hLx02xLs; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-28312-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-28312-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id p24-20020a1709028a9800b001d5dbe44b89si3187125plo.504.2024.01.16.14.33.37 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jan 2024 14:33:37 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-28312-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=hLx02xLs; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-28312-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-28312-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id EDD102833CF for ; Tue, 16 Jan 2024 22:30:35 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E6F295FDC8; Tue, 16 Jan 2024 21:38:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hLx02xLs" Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CD2AC35F03; Tue, 16 Jan 2024 21:38:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705441085; cv=none; b=rELVKzj8r4HhwDWm0rWjrHg99OPufdyMI2j0DGDUs/KNc7WxRfo2nE2teax+NNxUpGFccjjiuje7zxl65Ad4T/r4okJJrdNDciU8nH3etoeO4OXdDz363UpylKOKRjeyyxrR62vg9yS+mqdiM9+NUm4SnqI+2xJrDSaEeNW7e0o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705441085; c=relaxed/simple; bh=Y/E4DSPhCGQwod2MxGfu/zAJG00FRP/drC0qA9lcfVU=; h=Received:DKIM-Signature:X-Google-DKIM-Signature: X-Gm-Message-State:X-Google-Smtp-Source:X-Received:Received: Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References: Content-Language:From:In-Reply-To:Content-Type: Content-Transfer-Encoding; b=MBZgIueAM8pu27F5a1i4hf66VRKCy0MS8Nsw5uxeRdofSZbe6iBZi9dWD834G/+LoU+V7O/6bB3MfJMQBxRDd0p/zkarrpmnro2XGJpdp9qfX3Twk+ONFnogwWFIgd8E6D5/sDBmGzM1kThCc364sD40yMsTn/NmCA1hkzu670k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hLx02xLs; arc=none smtp.client-ip=209.85.210.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-6d9b050e88cso5792766b3a.0; Tue, 16 Jan 2024 13:38:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705441083; x=1706045883; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=sqRPOFeNao0i7ZbF0Cd/T0E9SrjM9ty6IYml6ss+0UE=; b=hLx02xLsn0pw/dEqq5qsFoIivmOuh2HzYqZs87/CNueYMZ142ecK3GIKRz7AakRUpe VnMdqPh/45qwDPCN2N2JHaA3SkCMiRwWbfMmXz6Bwo3z9zCPwhlapCO0GtQGflut6N4H ing/s7AEk50Ap4psJpWvY9LzlzVTLb9CATRtVYJ7nr3RMf/riPVQTVVb3vioiO9SIXYz 3ELG6xmWdh0vQod84vSg/l+E6qicn2xWlyQNcHscwsdGckZ4fGjqShjO1i3CiXzWhGAy F2q4e7D2vBNzDPrn58o0+weZRBLmkIsozhBrmAl+5rZZTCYWhNl7Zwj7PEs8N0M8np5F HAnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705441083; x=1706045883; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=sqRPOFeNao0i7ZbF0Cd/T0E9SrjM9ty6IYml6ss+0UE=; b=sCs6dDnXS8Nu56DTZ9enPQ1jdwJsbPbripaG0xA6QfaO6NwjE7P+O+u7/ECfj5hBdT pmg54PmqcCm+BqDcfrAovNaCQ4vjXMbXaeC31Xp7Q7Nlma06i3D1mrOt8T8ZWtAjZ74z Vn8bd4NUpUf+QDKI7hsNb9DGUVVvXYtf7Jh/Rhlgzq1jkw0lOJ++eMzzc6iJA+7xeAn5 1aKlVsHNmdtpTmyYf5qVH160BRr49gweC0BtDkzBEH3bV+qP8pQFupjFc/TpZaiKd+ti 1BRCpNps+CMT4V+3arp3kTd8ovOSVpwEgy3EtQSS4Mo/eJBxYYifrJILSz2/n0vM1oCo JXRA== X-Gm-Message-State: AOJu0Yxax/22goTDD41RlGZXonpdaumOVYphhso7k3gJsb/lPnSc3nkm LfshR6vY2b1N1GStsMrYly5pCBMem9k= X-Received: by 2002:a05:6a20:94c9:b0:19b:4545:74c with SMTP id ht9-20020a056a2094c900b0019b4545074cmr1143672pzb.93.1705441083232; Tue, 16 Jan 2024 13:38:03 -0800 (PST) Received: from [192.168.0.228] (c-24-20-51-242.hsd1.or.comcast.net. [24.20.51.242]) by smtp.gmail.com with ESMTPSA id h13-20020aa79f4d000000b006d92f081d9fsm52031pfr.31.2024.01.16.13.38.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Jan 2024 13:38:03 -0800 (PST) Message-ID: Date: Tue, 16 Jan 2024 13:38:01 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 26/42] drivers/scsi/ibmvscsi_tgt: Convert snprintf to sysfs_emit To: Li Zhijian , linux-kernel@vger.kernel.org Cc: Michael Cyr , "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org, target-devel@vger.kernel.org References: <20240116041129.3937800-1-lizhijian@fujitsu.com> <20240116045151.3940401-1-lizhijian@fujitsu.com> <20240116045151.3940401-24-lizhijian@fujitsu.com> Content-Language: en-US From: Tyrel Datwyler In-Reply-To: <20240116045151.3940401-24-lizhijian@fujitsu.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 1/15/24 20:51, Li Zhijian wrote: > Per filesystems/sysfs.rst, show() should only use sysfs_emit() > or sysfs_emit_at() when formatting the value to be returned to user space. > > coccinelle complains that there are still a couple of functions that use > snprintf(). Convert them to sysfs_emit(). > >> ./drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c:3619:8-16: WARNING: please use sysfs_emit >> ./drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c:3625:8-16: WARNING: please use sysfs_emit >> ./drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c:3633:8-16: WARNING: please use sysfs_emit > > No functional change intended > > CC: Michael Cyr > CC: "James E.J. Bottomley" > CC: "Martin K. Petersen" > CC: linux-scsi@vger.kernel.org > CC: target-devel@vger.kernel.org > Signed-off-by: Li Zhijian > --- Acked-by: Tyrel Datwyler