Received: by 2002:a05:7412:8d1c:b0:fa:4c10:6cad with SMTP id bj28csp119718rdb; Tue, 16 Jan 2024 17:38:48 -0800 (PST) X-Google-Smtp-Source: AGHT+IHzCb19ospmxb26UAMa9L8ke0FStwEe7eyHW2pyU5HPB3tAoOUGPStj0KPtu6DaDUbqkhG3 X-Received: by 2002:a05:622a:1ba4:b0:429:f559:8e10 with SMTP id bp36-20020a05622a1ba400b00429f5598e10mr3117085qtb.112.1705455528337; Tue, 16 Jan 2024 17:38:48 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1705455528; cv=pass; d=google.com; s=arc-20160816; b=fLUTSnE0dKUDQeawN3jKbVNoWjS8Ds4y/LqK4FwvZIfX2NBEmwznbO7HmoP9RhVx0A 6CPsszOoyHM0YXZhJkTKIhkTVWxzc8yHqQSui5YwZpPygzE1XBOn6KjhfFb/7Wv2cJy6 Ei8bI69NMauMad7cByQ8wj/yAkEDGFgDKSu+p6y5CAmpZ+s8+WDfVxe6SKNBKoN5K53E I/vx1qIx6dfNerzTjebfGd7y1m8T1P4VSwdXk9HulAItnKcm6nwCnUuscTwmVW8t7uR2 rxI32PGipkxKl2q0JqJ2Z1x+wN98u9pSQveI3YUj3xveUFR3pqbUQt0kFk/ENpVlCu9m y7pg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=R5KLNcXBWSgYOjyxCaaoj7URUp994mkG/8fZlapNemI=; fh=3fceMOBGiE7Nb/QgkBNYW5jakM87U85TFckZSXek9vs=; b=0UI542TEfcEgnl3lUd9f1LXARJdTDMY0FJ7sA0qmacK5TpBnyOFXWIxObM5DUtjajj GSZFUMtPD8hCIefJg3hrNhA9iMKcK3ji/L3IKEIJcDVmvK45JwGjaxOWjGS/PI8Q2xHZ 6ib6y2Qzo8m0pss20SQ8sF4mfQt5+zKQbQe1o7AGrt8RuyRTwP2boYfR1f2CjCBauzeN wqBRcxp6aNvHhNnrNegmZxsI75Tj3iodOroyF5bTqMGchF5ECFKcd6R96ep/0j6w13ro UVy/2uq1bwGBNiNe9YDcVMzDvhRJcLN+C/MzE2V3kJg7QPdk1f435ZicHLyKnd+FSJ/6 Sh4w== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=onRdSnN9; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-28432-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-28432-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id vv19-20020a05620a563300b007830ac5d3f0si10745030qkn.438.2024.01.16.17.38.48 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jan 2024 17:38:48 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-28432-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=onRdSnN9; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-28432-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-28432-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 1C23A1C24462 for ; Wed, 17 Jan 2024 01:38:48 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 066423FDC; Wed, 17 Jan 2024 01:38:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="onRdSnN9" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2361410E9; Wed, 17 Jan 2024 01:38:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705455514; cv=none; b=IgJZlB5wGwoIWQpZcSdnGES3xfVML8LtS8Ks/Afapxm+V7+jSj6GMrg42E38iEiRMd4PDlaW0KbFZQG+MgrrkbdXMpLISNYv7wn9CmYC87qv8VMguQ1ChGuouWZMXNNbaaMb8JGWiXPrEVOGzpcLf3P4Snb9pAF3KDm/xY8PFTs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705455514; c=relaxed/simple; bh=R5KLNcXBWSgYOjyxCaaoj7URUp994mkG/8fZlapNemI=; h=Received:DKIM-Signature:Date:From:To:Cc:Subject:Message-ID: In-Reply-To:References:MIME-Version:Content-Type: Content-Transfer-Encoding; b=C/6IKA+KeCKEdrTl7KOUGTp99FtQ0Tl6vROgm0/1yPNsNprK+r/vimPY5NQiGu42Sd5hp4khjevf6BdmAr6IGekdARKDGq17l+QLjb5mOOnygxrdOZ/I0hlFS+kz2FGW9ySrrW8Tm1hPDa9x8eTvuUzdvDQLNP++Ns1VCAen+lM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=onRdSnN9; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 52E7AC433F1; Wed, 17 Jan 2024 01:38:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1705455514; bh=R5KLNcXBWSgYOjyxCaaoj7URUp994mkG/8fZlapNemI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=onRdSnN9OsfGnJe0rweSp0cvS5RyqDmMufdwe7EewvH5O5RPvYf1SIeuxjCa/mLh0 kEV+9KYadAKKRvOP0NVN4EGCTCJqtyDo0xnlYzHtChF0rxD54Anux1oPm7Aw5+f4VZ NJ38oDP51q0OYNtMRxYJsgkzOFuohvxu/bQvWk7rFwYnVvfolhGXoHdP7hpQwJF3gE FeJV1axPMBWYkNr4/UNhISQ6G/7cftLpaM68LGPnu/TanCh8GJz39GDSvvUeTqKEQN ISwnio8D9PQ7JsHEs6QXMJMnqPUPUbH9KRLRnjiSSZIUH7hHUqCD0apSACSDDvwrAd 3iid4VUwITXJA== Date: Tue, 16 Jan 2024 17:38:32 -0800 From: Jakub Kicinski To: Sasha Levin Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Igor Russkikh , epomozov@marvell.com, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, richardcochran@gmail.com, ast@kernel.org, daniel@iogearbox.net, hawk@kernel.org, john.fastabend@gmail.com, netdev@vger.kernel.org, bpf@vger.kernel.org Subject: Re: [PATCH AUTOSEL 6.7 076/108] net: atlantic: eliminate double free in error handling logic Message-ID: <20240116173832.5ee074c7@kernel.org> In-Reply-To: <20240116194225.250921-76-sashal@kernel.org> References: <20240116194225.250921-1-sashal@kernel.org> <20240116194225.250921-76-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 16 Jan 2024 14:39:42 -0500 Sasha Levin wrote: > Driver has a logic leak in ring data allocation/free, > where aq_ring_free could be called multiple times on same ring, > if system is under stress and got memory allocation error. This is a bit big, and the commit message is a leftover from previous version which mixed up the fix with the cleanup. The fix went in as 7bb26ea74aa86, I'd vote to drop the cleanup from stable, but it "looks correct" so no strong feelings.