Received-SPF: pass (google.com: domain of linux-kernel+bounces-28428-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <2414bcf0-d7d6-485e-ba68-8d13a28da8b5@amperemail.onmicrosoft.com>
Date: Wed, 17 Jan 2024 09:32:35 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] crash_core: export vmemmap when CONFIG_SPARSEMEM_VMEMMAP
 is enabled
To: Baoquan He <bhe@redhat.com>, Huang Shijie
 <shijie@os.amperecomputing.com>, akpm@linux-foundation.org
Cc: vgoyal@redhat.com, dyoung@redhat.com, kexec@lists.infradead.org,
 linux-kernel@vger.kernel.org, patches@amperecomputing.com
References: <20231127020727.25296-1-shijie@os.amperecomputing.com>
 <ZYO7MvpT9yWWfjO7@MiWiFi-R3L-srv>
From: Shijie Huang <shijie@amperemail.onmicrosoft.com>
In-Reply-To: <ZYO7MvpT9yWWfjO7@MiWiFi-R3L-srv>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?SnJmcTNXSEtwdW9SaFo1Nmkrbktud1RXakJiazBPL1dhTzdvT2ZULzZQZDdv?=
 =?utf-8?B?S0cxSkF0RVJVM1NjSVBNdzQyNDA0RGx6SjNWOHMrZ0V0TlZmWHRMT1loN2hR?=
 =?utf-8?B?aklzSEtLK0ZXNHdCT1JGV0xJS1RCblgrckR6dmpNYXVNeEQ1eE9jNm9vWFNt?=
 =?utf-8?B?THRiNTBlR1NoLzA0ek5keUt3U1VkZStsVitBdEpZUTF3dTI4TS9LRUg5REJK?=
 =?utf-8?B?THUyTHZINjNMRVllYWpIQVI2enlUdHYwblIvdUpaS1Fxbll1bVNkdTdXNGk1?=
 =?utf-8?B?NXFSRmszQ3Zna3MxMVZYUDk5YlBhZzNrSVMwN0RpVHRINTRSS1JJeDBLMUx5?=
 =?utf-8?B?THJLUUpFSHZ1VE8yOXhOTzVhR1ZqaENjZzI1dXduVDlFTWE3NWVVaUtIakd6?=
 =?utf-8?B?TVBYWVFoZzl3LzljZVl2WUZIZ3pTblJZMmh1aHJqaVR5RkNjc3FGRUd6STZ5?=
 =?utf-8?B?NnFMYlRJMmxlTTFsaVptMU5jYnEwaWlOcTYxdUsvUDlVY1MyYy9NWmtGdnNO?=
 =?utf-8?B?UmNvRzU3NCs5TGhYWGpOWnRrc2h1QnREZ3dxMHNQbkNOL0JYNVlMRWJqa0Iz?=
 =?utf-8?B?K0pISzVmNVUyVHkvRXdhZEVlNUlkNVkrN05CNUNmQUE5T1RZdy9HQzlHUlcv?=
 =?utf-8?B?VUQrVmFLSHBHVUZENGQvRTlxM25DWEFZN04vcFNKUmJVaXowa0dtN2Z5cW9v?=
 =?utf-8?B?VCtteXl6eTBoVXE2OGNpM3hYbXJvVVQvbU5hTzgrNWR6U1kzL29IZllNTFk5?=
 =?utf-8?B?OWNxRUZMTndwUi8vVCtxcDNhSlluUEt3Z0I3NFpuOWZJNlR6MEZiZ2sxYmpy?=
 =?utf-8?B?UFJQZVNFcyszKy9VRTNFOGR4WHdudFhrM216WjIxNERxek8vMms1VGhNQmhw?=
 =?utf-8?B?VHo3bmVJTGUyY3d4Vlk5NEJ3SVNtd3Azb0FzQXVCYmJBczRVcXR6NEpQTjk3?=
 =?utf-8?B?bTJxOWZzVy9JTjVJT2s1aG93WkZpL3dSN1FhQzh6YjErSU4xRGZFQmJjOE03?=
 =?utf-8?B?ZVNBS1pRODgvQ2swZWkwQUYxcEg3ZFlhUTh5NlhpK0t1bU5vdDR2czB2Y1R6?=
 =?utf-8?B?Y1B6NzlvbVdYbXJHblNXOU1iWUFkNWxITDByaDZBQmpVZzNDYkhJNTFLZkhw?=
 =?utf-8?B?UG1xQnZnWVRpaVV3d1d6RkVtQnlQL0llQ1JVcyt5Wm9Wbmw1VHlCcEVwZzFR?=
 =?utf-8?B?TWw5WC9jQk5FU0VLWmloYXNyRVZ3S2luWVdjUVFXc0x2ek5FOFViVUxlTDdF?=
 =?utf-8?B?eUJYa05Ka24zajc1cERsd0JDZzBtcCsxQVk2ckRaZGltOERvMEd6NTgzNlli?=
 =?utf-8?B?TVpsVjFzNmxGV0owTERVbXVzQUc0Q05ZMmNPR1Fqem1KN3NMUkl3WXBkb0JC?=
 =?utf-8?B?WXJ1WCtadzBUK0JOMldCc0xFVlR2YUZMNlJJSW5XdzR4WXU5bVlIek5wcTFZ?=
 =?utf-8?B?NVhTTFVjSmpsVzlQMlFzVXhGS3dVT0c4VUFYaEdmWUU5cE9WUFBTelc5b1hx?=
 =?utf-8?B?eG9XaG9ndTExREtPUk5HaWpqVm56Y3FOSFlBVjdQUDFEcUswWTc1eDBKVkNu?=
 =?utf-8?B?b2dXbldEYmhkVVVuZURENTdqNVEyd1V0ZGFVakptOW5vU01uTFpraG9lcW9Q?=
 =?utf-8?B?UDQ3UXJKWW1IQ2xHYUhuWXVwbUN5VzNxUXRWRzB0QTNrbEgwdS9yWnppaUQ4?=
 =?utf-8?B?YzFvU25xOGxUZzJBSmN1eFJrSVhWRlBPWUZMdFA2OFNPMCs2T3RqKzAyN0hO?=
 =?utf-8?B?WVYwRmg0dUN1TDVLdWdqMFduTGJHZ2IyNHhnTGJ3Q3pjcHFkZ2FjUnk4NkVY?=
 =?utf-8?B?K242N0Z2N2F4aWE4ZkFGMkhxQTQ0Wks3THdXUG5kOXZ3TVFRaCtOVjZGUThK?=
 =?utf-8?B?SHEzTFFUWi80M2tZZDhhSE9wV0lkd21wN0ozU1grVm9ldkx2ZTh2NUl1NjZY?=
 =?utf-8?B?VzlIMFNIbnl1ZGt0TEQzNGFZYk45NDZDUXd4S0YzVXBkOTZLVXpJR2ppa3Ja?=
 =?utf-8?B?eGJ2OTNjUG9CSUpGOFQwVVFxRXprZ3FEZXVKYmdOa01PblpYdGVPL2VPb09F?=
 =?utf-8?B?TUhmVFZVdGNPemlYRzUvYUhsZDlpaENya2lFa1ZzelZxTUQyVmxOeXlpaStB?=
 =?utf-8?B?UGVQK3JrOTNlVXpoTHlKbitVWlBZYzBqOTJRWkhGazFWVVZPQjcrN0wva01v?=
 =?utf-8?Q?zrlW/SX0qsbjbS6S9ViO1o0=3D?=
X-OriginatorOrg: amperemail.onmicrosoft.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a87b8ef0-84b1-4202-3c90-08dc16fc3497
X-MS-Exchange-CrossTenant-AuthSource: PH0PR01MB7975.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jan 2024 01:32:45.3653
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +0/ikr0z0PWK78m/QhaPpFOA0XrSCrO2DbDL5ne3pnkh0HGNKyZl+VnivdLyHeigZ7wCz0U/vizeZS+zyOYS0CpVUwAeNV2g3zkp+Ev9eY4apqca1k8PSmdRRHoXnbL0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR01MB8045

Hi Andrew,

在 2023/12/21 12:12, Baoquan He 写道:
> On 11/27/23 at 10:07am, Huang Shijie wrote:
>> In memory_model.h, if CONFIG_SPARSEMEM_VMEMMAP is configed,
>> kernel will use vmemmap to do the __pfn_to_page/page_to_pfn,
>> and kernel will not use the "classic sparse" to do the
>> __pfn_to_page/page_to_pfn.
>>
>> So export the vmemmap when CONFIG_SPARSEMEM_VMEMMAP is configed.
>> This makes the user applications (crash, etc) get faster
>> pfn_to_page/page_to_pfn operations too.
>>
>> Signed-off-by: Huang Shijie <shijie@os.amperecomputing.com>
>> ---
>>   kernel/crash_core.c | 3 +++
>>   1 file changed, 3 insertions(+)
> Ack this one as it's needed by crash utility patches.
>
> Acked-by: Baoquan He <bhe@redhat.com>

Could you please merge this patch?


Thanks

Huang Shijie