Received-SPF: pass (google.com: domain of linux-kernel+bounces-28443-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Tue, 16 Jan 2024 17:53:28 -0800
From: Jakub Kicinski <kuba@kernel.org>
To: Colin Ian King <colin.i.king@gmail.com>
Cc: "David S . Miller" <davem@davemloft.net>, Eric Dumazet
 <edumazet@google.com>, Paolo Abeni <pabeni@redhat.com>, Lars Povlsen
 <lars.povlsen@microchip.com>, Steen Hegelund
 <Steen.Hegelund@microchip.com>, UNGLinuxDriver@microchip.com,
 netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
 kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] net: microchip: sparx5: remove redundant store to
 variable clk_hz
Message-ID: <20240116175328.2d6902af@kernel.org>
In-Reply-To: <20240116161847.2317011-1-colin.i.king@gmail.com>
References: <20240116161847.2317011-1-colin.i.king@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Tue, 16 Jan 2024 16:18:47 +0000 Colin Ian King wrote:
> The store to clk_hz is redundant since clk_hz goes out of scope on the
> return. Fix this by replacing the *= operator with just * to remove
> the store back to clk_hz.
> 
> Cleans up clang scan build warning:
> warning: Although the value stored to 'clk_hz' is used in the enclosing
> expression, the value is never actually read from 'clk_hz'
> [deadcode.DeadStores]
> 
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>

For consistency - same story as:
https://lore.kernel.org/all/20240116193152.GD588419@kernel.org/
-- 
pw-bot: defer