Received-SPF: pass (google.com: domain of linux-kernel+bounces-28447-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <26258c1a-2908-4931-8d6f-fac6754ca2e8@intel.com>
Date: Wed, 17 Jan 2024 09:58:40 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v8 22/26] KVM: VMX: Set up interception for CET MSRs
Content-Language: en-US
From: "Yang, Weijiang" <weijiang.yang@intel.com>
To: Yuan Yao <yuan.yao@linux.intel.com>
CC: "seanjc@google.com" <seanjc@google.com>, "pbonzini@redhat.com"
	<pbonzini@redhat.com>, "Hansen, Dave" <dave.hansen@intel.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>, "peterz@infradead.org"
	<peterz@infradead.org>, "Gao, Chao" <chao.gao@intel.com>, "Edgecombe, Rick P"
	<rick.p.edgecombe@intel.com>, "mlevitsk@redhat.com" <mlevitsk@redhat.com>,
	"john.allen@amd.com" <john.allen@amd.com>
References: <20231221140239.4349-1-weijiang.yang@intel.com>
 <20231221140239.4349-23-weijiang.yang@intel.com>
 <20240115095854.s4smn4ppfjfa2q2z@yy-desk-7060>
 <ee2c5c91-68bd-4f78-aafc-c14093f05342@intel.com>
In-Reply-To: <ee2c5c91-68bd-4f78-aafc-c14093f05342@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WnNCNDdnZDgweloycHIzWHRiSVpTZlJ1NjI4TEVrOTJvOXVXTWdpcFFvQWFG?=
 =?utf-8?B?c1lxRnlNVFBGeDhPRkxRZkdnNitoZlN1YTVQR1pNeTNYbTBKRVU5QkNwcmNo?=
 =?utf-8?B?aktic1lXalJTR0o1c3R1eDFKSWVmdGFySk5kM0o5alBidUZkblM5SW5QTFFX?=
 =?utf-8?B?NHhBWEJoOGZ1WG9VMGRnOCtCNmFtMVNXYkxTOHpnMzh3OWt1Ly92NDJ4UlFL?=
 =?utf-8?B?Z2JmUlVmcHd1alNnZnRQZEVKaVZTaDBSalZjLy9zOU81ek9YYnNXUC8yWVV5?=
 =?utf-8?B?VTB0K3ZYcjhycFZzZFdHU3F0U3cxTkpoZ2pISStOUE11WWFiVXFxV2lnZzJD?=
 =?utf-8?B?UTRvdElSclJualc3QlRMa2VPUGo4Q25xTytkWE40QUxZYzlGUW9SL0liWFZQ?=
 =?utf-8?B?N2tZcFVPQklKN0VPN0Z5K1BNcG9OU3c2ZHh3bktmZGpMYzc1SmJaM0pWOWJx?=
 =?utf-8?B?S1dGTWRqZWY2dk9idnNZSCs0VkxNTDFQSEUzZUNKbWc5S0ozNjVhNi90SHhs?=
 =?utf-8?B?QzUwZm9tTzM1UU1UaXBseGJiRFNodytxeURjTi9SZjhReCtIK0NzN24vZ2t6?=
 =?utf-8?B?RTJUcXVQV3M3VGxBWEVCdnpReXV2OHQxcFRzdTFCVFNxZnRtVU5qQkNMUXJV?=
 =?utf-8?B?MkZNRUdCYWU2Yk1uVDBnZFl2QzZiNDNDa2ZpOGcwVjExWE5JSllnYTVFY1Y5?=
 =?utf-8?B?eHY0SGxtY0Nxb210aU93TWNucmprTUlpdzJoMDQybGtjY1BWcitiL2RxWGt2?=
 =?utf-8?B?TVlqMUtpV0tybzJ6WWVuT1hRMDZMOFNWaVhyNlZNc1A2SUdPRXpWaGRhTXdm?=
 =?utf-8?B?Q2dlWGxPYzhnRlFBdU5hd0M3U0s5empmcG85TjUzL3EveEtXU1Jva3c5WG5y?=
 =?utf-8?B?aWhnQVZ5bjdCSHB0QUF1MmJMMDJSeTUveEVSRUV0Y0FsdVFiQldFS1FEODBq?=
 =?utf-8?B?QWRPSlF2S0tZWkpUVlFyZmgvVENTOVNleCswQk1TZC8rK1NTVCtPbjNXV2Q2?=
 =?utf-8?B?UnJnRXdMZXEyVHJJSEYzZjBiaGFzL2M1b0RQT1hteG5MUjcvVGlub0RHVy85?=
 =?utf-8?B?VjZVczk0aEVOZUR5cDhZZU14aHJjTmlBR3pEaTVCTFVseXgvd1pQVWhGaEt3?=
 =?utf-8?B?Sk9kZkoxT3ZsYnROOTdWeHBLeHAvcEVZQUVJcmpKOVpHbi9iMHBWNlhNNDhu?=
 =?utf-8?B?VnhVaGhscjAxL3R4TEN0V01KS0llczJOeGY5YWlqZFh1VFEySG9kbEpkN2Rj?=
 =?utf-8?B?dElUVTZHUTBPcXUzdjNFUFVtQ1EvTFNDcTZqbkhJVmdrRmJGNjlNQ20zUWtm?=
 =?utf-8?B?aDZoLzRLK0IrdStRSGt6UU9PTkNKRlRBQWZSM1NNU09kMnJpc3FSQ2hYSEhO?=
 =?utf-8?B?YXFqM1g1cEpWc0trZy9SNXJqT3JSQ1RMRzVDMFdrSFhmNzZrQnpnd20yVm4z?=
 =?utf-8?B?dERIektJM1RIZEwyTjNKcnB3UzlCMkkzMzRlU0hvL0twWWpZQVIzSjdSa0RG?=
 =?utf-8?B?TlZVZ2VOSUdrUlVESkJLUjhncndmcUJ0VSt5T2wzT0ZpMVFWQktpYmxMMTF0?=
 =?utf-8?B?K3NQMmtYd1RHM25JNFJ6Y1BNWWQ5eWhqeDhnWVVZcXh0S1puUjZpOEFSRkxK?=
 =?utf-8?B?bVAzd1V1TzhlYWtRNHJqajRFTHRsOWIrSzRuTVhJSnBSSE92RExvNkZuV2NP?=
 =?utf-8?B?b0VCR3Zqd1o4R3FqelBWS01JcnRrdFlFbEQxTTJGSEJ3bFJsUWFydlp6L2hS?=
 =?utf-8?B?U3laY1dJQS9FakFqZjdEY0I0Tkw5SFo3RTZPTEhqVVp0UmZzR1E1UStaMnVj?=
 =?utf-8?B?TE1tbUZTMExSck1sNDd4bWhsRXlpVU1CVlVSTzIwZUJTN3J5TG1BaTlSWC9a?=
 =?utf-8?B?SmxOQ2RxYlgrRWphR3I2MS9qaTVDU1NUbUNhL3RZa1BpaGFEa1lHd2V0clNO?=
 =?utf-8?B?V3l3M2k3OHB1YXBtS0FxRUNGQ1M4UVluWXpScytZem96ZXdKOUFUQytENE1y?=
 =?utf-8?B?RnZPRkY2djlmTVhVY2piRHJYSmxjSkhKclRZSmtYOXYxZUlVdTUvUnpDZ3ZG?=
 =?utf-8?B?YWxBQkppQTREL3VKcnNXelp6dXFzaEsvakREbk00aERmR0ZLeDFaajRYa3RH?=
 =?utf-8?B?OWhrK0wvcnZ2V0ZkeFpxNCtrNFR2aFBNYlo3akhvU2tvZ1QvS3pva1lOL1R0?=
 =?utf-8?B?cGc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 6867fb8d-5ef8-42dd-5885-08dc16ffda25
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB4965.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jan 2024 01:58:51.4880
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: UMGAK3mvfA5INUvduQzW63pv0qJZjSNgJOm/M5ZV+xe2ADkLhgsy5vzglCUNuW3GmNHLjcBGXLDLFNHrTOC6vg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4537
X-OriginatorOrg: intel.com

On 1/17/2024 9:41 AM, Yang, Weijiang wrote:
> On 1/15/2024 5:58 PM, Yuan Yao wrote:
>> On Thu, Dec 21, 2023 at 09:02:35AM -0500, Yang Weijiang wrote:
[...]
>> Looks this leading to MSR_IA32_INT_SSP_TAB not intercepted
>> after below steps:
>>
>> Step 1. User space set cpuid w/  X86_FEATURE_LM, w/  SHSTK.
>> Step 2. User space set cpuid w/o X86_FEATURE_LM, w/o SHSTK.
>>
>> Then MSR_IA32_INT_SSP_TAB won't be intercepted even w/o SHSTK
>> on guest cpuid, will this lead to inconsistency when do
>> rdmsr(MSR_IA32_INT_SSP_TAB) from guest in this scenario ?
> Yes, theoretically it's possible, how about changing it as below?
>
> vmx_set_intercept_for_msr(vcpu, MSR_IA32_INT_SSP_TAB,
> 			  MSR_TYPE_RW,
> 			  incpt | !guest_cpuid_has(vcpu, X86_FEATURE_LM));
>
Oops, should be : incpt || !guest_cpuid_has(vcpu, X86_FEATURE_LM)