Received-SPF: pass (google.com: domain of linux-kernel+bounces-28459-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Wed, 17 Jan 2024 02:22:40 +0000
From: Wei Liu <wei.liu@kernel.org>
To: Dave Hansen <dave.hansen@intel.com>
Cc: Dexuan Cui <decui@microsoft.com>, ak@linux.intel.com, arnd@arndb.de,
	bp@alien8.de, brijesh.singh@amd.com, dan.j.williams@intel.com,
	dave.hansen@linux.intel.com, haiyangz@microsoft.com, hpa@zytor.com,
	jane.chu@oracle.com, kirill.shutemov@linux.intel.com,
	kys@microsoft.com, linux-hyperv@vger.kernel.org, luto@kernel.org,
	mingo@redhat.com, peterz@infradead.org, rostedt@goodmis.org,
	sathyanarayanan.kuppuswamy@linux.intel.com, seanjc@google.com,
	tglx@linutronix.de, tony.luck@intel.com, wei.liu@kernel.org,
	Jason@zx2c4.com, nik.borisov@suse.com, mikelley@microsoft.com,
	x86@kernel.org, linux-kernel@vger.kernel.org,
	linux-arch@vger.kernel.org, Tianyu.Lan@microsoft.com,
	rick.p.edgecombe@intel.com, andavis@redhat.com, mheslin@redhat.com,
	vkuznets@redhat.com, xiaoyao.li@intel.com
Subject: Re: [PATCH v3 08/10] x86/hyperv: Use TDX GHCI to access some MSRs in
 a TDX VM with the paravisor
Message-ID: <Zac58P0MgEQ_ITOf@liuwe-devbox-debian-v2>
References: <20230824080712.30327-1-decui@microsoft.com>
 <20230824080712.30327-9-decui@microsoft.com>
 <f488fede-5c28-4840-af3c-3faa9a31caa0@intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <f488fede-5c28-4840-af3c-3faa9a31caa0@intel.com>

Hi Dave

I was away and only saw your email now. Sorry for the late reply.

On Mon, Dec 04, 2023 at 07:10:29AM -0800, Dave Hansen wrote:
> On 8/24/23 01:07, Dexuan Cui wrote:
> > +#ifdef CONFIG_INTEL_TDX_GUEST
> > +static void hv_tdx_msr_write(u64 msr, u64 val)
> > +{
> > +	struct tdx_hypercall_args args = {
> > +		.r10 = TDX_HYPERCALL_STANDARD,
> > +		.r11 = EXIT_REASON_MSR_WRITE,
> > +		.r12 = msr,
> > +		.r13 = val,
> > +	};
> > +
> > +	u64 ret = __tdx_hypercall(&args);
> > +
> > +	WARN_ONCE(ret, "Failed to emulate MSR write: %lld\n", ret);
> > +}
> 
> First of all, I'd really appreciate if you could seek out explicit acks
> for this kind of stuff before merging it.  This surprised me.
> 

I eyeballed the code and thought it only touched only the Hyper-V files,
so I merged this series without waiting.

> Can you please merge these generic things back into the main TDX code?
> There's nothing Hyper-V specific about any of this code.  Basically, you
> can make a hv_tdx_whatever() variant, but make _that_ in the generic TDX
> code and then export only _that_.

The code is still there. Dexuan, can you send a patch to do the
refactoring?

Wei.