Received-SPF: pass (google.com: domain of linux-kernel+bounces-28481-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <44ab50c4-c63b-436c-af46-9b4543181446@quicinc.com>
Date: Wed, 17 Jan 2024 11:02:34 +0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v5] arm64: dts: qcom: qcm6490-idp: Add definition for
 three LEDs
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Dmitry Baryshkov
	<dmitry.baryshkov@linaro.org>
CC: Andy Gross <agross@kernel.org>, Bjorn Andersson <andersson@kernel.org>,
        Konrad Dybcio <konrad.dybcio@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley
	<conor+dt@kernel.org>, <linux-arm-msm@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <quic_fenglinw@quicinc.com>
References: <20240115-lpg-v5-1-3c56f77f9cec@quicinc.com>
 <CAA8EJpoemnXTmshWrArVOCm0GRSkWZ5tH557nbAjRL1Tgg-Dig@mail.gmail.com>
 <e16f5ff1-9b12-4f90-89d5-f95cbfb859e7@quicinc.com>
 <6c29ce72-e303-406a-bb75-5b36b0cd8ee4@linaro.org>
From: hui liu <quic_huliu@quicinc.com>
In-Reply-To: <6c29ce72-e303-406a-bb75-5b36b0cd8ee4@linaro.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit


On 1/15/2024 6:26 PM, Krzysztof Kozlowski wrote:
> On 15/01/2024 11:18, hui liu wrote:
>>
>>
>> On 1/15/2024 5:56 PM, Dmitry Baryshkov wrote:
>>> On Mon, 15 Jan 2024 at 11:48, Hui Liu via B4 Relay
>>> <devnull+quic_huliu.quicinc.com@kernel.org> wrote:
>>>>
>>>> From: Hui Liu <quic_huliu@quicinc.com>
>>>>
>>>> Add definition for three LEDs to make sure they can
>>>> be enabled base on QCOM LPG LED driver.
>>>
>>> The "function" property is still placed incorrectly. Posting the next
>>> iteration before concluding the discussion on the previous one is not
>>> the best idea.
>> Do you mean I should update it as below? Seems there is no consumer to
>> use the function config, do we need to add now?
> 
> Paste the output of dtbs_check for your board (or CHECK_DTBS=y for your
> Makefile target).
I checked the dt-binding file of LPG LED, I will update the dts as 
below, if you think it's correct, I will push v6.

+&pm8350c_pwm {
+       #address-cells = <1>;
+       #size-cells = <0>;
+       status = "okay";
+
+       led@1 {
+               reg = <1>;
+               color = <LED_COLOR_ID_RED>;
+		function = LED_FUNCTION_STATUS;
+       };
+
+       led@2 {
+               reg = <2>;
+               color = <LED_COLOR_ID_GREEN>;
+		function = LED_FUNCTION_STATUS;
+       };
+
+       led@3 {
+               reg = <3>;
+               color = <LED_COLOR_ID_BLUE>;
+		function = LED_FUNCTION_STATUS;
+       };
+};
+

Thanks,
Hui
> 
> Best regards,
> Krzysztof
>