Received: by 2002:a05:7412:8d1c:b0:fa:4c10:6cad with SMTP id bj28csp151820rdb; Tue, 16 Jan 2024 19:13:41 -0800 (PST) X-Google-Smtp-Source: AGHT+IFtJZn/Gt+CsYP/ctY/3QUlJkS/yzQ2vW5hv7oTI8yQQUPmpZgBLW0+5u1/Zc1aydZO0AfO X-Received: by 2002:a05:600c:2e87:b0:40e:6688:300d with SMTP id p7-20020a05600c2e8700b0040e6688300dmr2016243wmn.26.1705461221054; Tue, 16 Jan 2024 19:13:41 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1705461221; cv=pass; d=google.com; s=arc-20160816; b=nEsyYiJPZ/LvxjHswkLCUVDc7IDUU5P/+Df7xfzl1hT5pN+EwHn7HdRuCvB1kjfGRY +w29d1fS8Tu6Np7FiaRjV2tyywKlgHmJWwPhSDRqJYnMMxqnb0coGJMlI0cGcNAeH6ih tEqLvUHwGx45+ypuAVeGiUIanUD9eAX0mel/vI8HKcWk5kygzGPhs0A4B6aEIYvIOvcu 9Wrv0oT9m6PogxDeopbBR9XlkqChiYqzpxINsZebEWD4MFROoZQif2RjBfqS8ZfYO0Zt 56u3/8PHyFZLCDVCFfxgDqe1EYWBAR+FSljHJmufR6CeWXC0FHDI3eGGVmkF4cdSXcSJ Vf/g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=dWLq4aGpb7f9s5ZfnYqz3MCWQjdIg4mIg649H1i2jNs=; fh=sJOLYzHxlJrDS/9zY+EwtMBOqMU0IT8Y81SnoKDUN9E=; b=oMe6Tnf6IKIsNJ6Ze9b4p1ZbGa5s1II4pLZQFBUbPw3jUSuzOe9YExBn4RXb0KSqJY +VTluPOQVuPdzvm7E1NMGuJDZSEkcew6lanigH0V8wefVGQwcU607GWhiSUOYXcbpgfy YX4sHaT2V1sDPNHpQAiXklvDF/b+ZvRxSVyPIh+TRUHXCCkjEC8kAHrf2uqIBY+80SZV AFtf2QAfXGu/j2HV1TDxote+FvxrQO6j977nrZi57WsApAHqEDiY0Pg5TE1Sph0HPCVr kn9sqqA92E4KEmR2JCMGHOS37UmyxoQNtYE42HBC4ottT5dfZ3OUPFV+1z+71tCXEK9u KHZg== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=gF7jexBT; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-28495-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-28495-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id w16-20020a50d790000000b00559199f4626si3098464edi.92.2024.01.16.19.13.41 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jan 2024 19:13:41 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-28495-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=gF7jexBT; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-28495-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-28495-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id CAC731F26924 for ; Wed, 17 Jan 2024 03:13:40 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id EC43BCA47; Wed, 17 Jan 2024 03:12:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gF7jexBT" Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA74BB642 for ; Wed, 17 Jan 2024 03:12:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705461148; cv=none; b=WbQNAtYiP7HbX5i7E8n2Cy0motHButDFKCzxUVQ4o7xN6u1prBp7LMWRmb/VTC7poeyOtkYRv8qeln7J92VJOhg4/FIeeCy4NcxuZcQyUpGX8LRppaXJc4+6Yujgpm8h9aXWwBYrGJeEGcsz664jEI/I3MCgigtJvYZ6cWjKMbc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705461148; c=relaxed/simple; bh=VICQkZ3AboV52RhoDU3TsfC68unKvLe48saOLuiFWlU=; h=Received:DKIM-Signature:X-Google-DKIM-Signature: X-Gm-Message-State:X-Google-Smtp-Source:X-Received:Received:From: To:Cc:Subject:Date:Message-ID:X-Mailer:In-Reply-To:References: MIME-Version:Content-Transfer-Encoding; b=H6ysNtAKZNkGiWQo6zUxmWoK9jCw6PNYsFzc8Nna4ombPzfwo9/d8lrG56tMhCPlrLJ8cX138G06//UGyneqD9k6GBSmG7CqmWjaEgkkiyhP6DSZCfxggQD10oKic6v7vZ96m0rPJh9CojOV1/l+rSdOTT5F8UxPn/99GWpWS9Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gF7jexBT; arc=none smtp.client-ip=209.85.208.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ed1-f54.google.com with SMTP id 4fb4d7f45d1cf-553ba2f0c8fso11768134a12.1 for ; Tue, 16 Jan 2024 19:12:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705461145; x=1706065945; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=dWLq4aGpb7f9s5ZfnYqz3MCWQjdIg4mIg649H1i2jNs=; b=gF7jexBTUpVDiPV+yb7ONDuy8Bz0FkyEN8dpB1bD+yJ5WHucfzI/TDoC44qr9zZDGd 6nzdHTbJoav+jYd2k4MhnOo4GnkNsySypOwkCY+dmgynoI174Z53JGxpKKkkCvdF87vU QQrWeqW1KaG5IcAnOqB1Mk2etFuhmXL8krrh4TE7JuAXYLiq/k0Of1lFBWwHtfpQ/p40 AbSob4e1L/qJh7peEHYC98AThbgrU58Y9wDGNON26CVnACv1qfQr/IYvzZC/O6RVU0wQ r0fynkY6lwSNE5yOBEwzrqvJ663vwx01ITm7dB97gFKiQGgW2cqw78yxsj2QHzeKDrbk dulA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705461145; x=1706065945; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dWLq4aGpb7f9s5ZfnYqz3MCWQjdIg4mIg649H1i2jNs=; b=OScY9+9WjEU5/bmpldM+rZHuqtV1/ISAwlQW8PRv6/HX3F9kHoruxsYUsTw3X104pE bLSlkMiI5s4u2ZepvhVHVWtCzQcKma1ZXX5Jvr1wzcXCI1BDpB1lSAqAxWrfv6gcXd4y bvqnSDFnNx2rnJGETT2rK3lumwIRfS6zVNx7wNHrtrgBQDdtE37F0YtjueFnIT+T3CkJ ENz9JQ0v/8VTDHMPRPB3HJeBFT8na2SyX4RSq4Fe1NY/ztspfXZjBXwpXmu93S7scUG4 Wbv8MdJp1zw4YpOuw6PKfnAQb9LtloZW+/BcdvTQwdIy6pAHJMxiKW/QqPLB1CDmEZgS Xueg== X-Gm-Message-State: AOJu0YyAKzBWbgUdO/VELq5PWhjOGmgCyZ1LQQwy5D5IcEK+pRCg6AFf +YRoLnsYD/DUwuSG/rvfqpY= X-Received: by 2002:a05:6402:74e:b0:559:b3fe:5cbf with SMTP id p14-20020a056402074e00b00559b3fe5cbfmr433485edy.7.1705461145176; Tue, 16 Jan 2024 19:12:25 -0800 (PST) Received: from mosaic.enunes.eu (ip-78-45-66-209.bb.vodafone.cz. [78.45.66.209]) by smtp.gmail.com with ESMTPSA id n13-20020a05640204cd00b0055971af7a23sm2258418edw.95.2024.01.16.19.12.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jan 2024 19:12:24 -0800 (PST) From: Erico Nunes To: Qiang Yu , dri-devel@lists.freedesktop.org, lima@lists.freedesktop.org Cc: anarsoul@gmail.com, Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Sumit Semwal , christian.koenig@amd.com, linux-kernel@vger.kernel.org, Erico Nunes Subject: [PATCH v1 6/6] drm/lima: improve some pp debug messages Date: Wed, 17 Jan 2024 04:12:12 +0100 Message-ID: <20240117031212.1104034-7-nunes.erico@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240117031212.1104034-1-nunes.erico@gmail.com> References: <20240117031212.1104034-1-nunes.erico@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Make the messages more consistent by showing the pp name. Signed-off-by: Erico Nunes --- drivers/gpu/drm/lima/lima_pp.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/lima/lima_pp.c b/drivers/gpu/drm/lima/lima_pp.c index ac097dd75072..d9e178d6645d 100644 --- a/drivers/gpu/drm/lima/lima_pp.c +++ b/drivers/gpu/drm/lima/lima_pp.c @@ -197,7 +197,7 @@ static int lima_pp_hard_reset(struct lima_ip *ip) pp_write(LIMA_PP_CTRL, LIMA_PP_CTRL_FORCE_RESET); ret = lima_poll_timeout(ip, lima_pp_hard_reset_poll, 10, 100); if (ret) { - dev_err(dev->dev, "pp hard reset timeout\n"); + dev_err(dev->dev, "pp %s hard reset timeout\n", lima_ip_name(ip)); return ret; } @@ -423,8 +423,8 @@ static void lima_pp_task_error(struct lima_sched_pipe *pipe) for (i = 0; i < pipe->num_processor; i++) { struct lima_ip *ip = pipe->processor[i]; - dev_err(ip->dev->dev, "pp task error %d int_state=%x status=%x\n", - i, pp_read(LIMA_PP_INT_STATUS), pp_read(LIMA_PP_STATUS)); + dev_err(ip->dev->dev, "pp %s task error int_state=%x status=%x\n", + lima_ip_name(ip), pp_read(LIMA_PP_INT_STATUS), pp_read(LIMA_PP_STATUS)); lima_pp_hard_reset(ip); } -- 2.43.0