Received-SPF: pass (google.com: domain of linux-kernel+bounces-28509-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Precedence: bulk
MIME-Version: 1.0
References: <20240116161929.232885-1-juri.lelli@redhat.com> <20240116161929.232885-5-juri.lelli@redhat.com>
In-Reply-To: <20240116161929.232885-5-juri.lelli@redhat.com>
From: Lai Jiangshan <jiangshanlai@gmail.com>
Date: Wed, 17 Jan 2024 11:56:44 +0800
Message-ID: <CAJhGHyBuf02mh=ezoua33UNu5QTpwP=qf-WP_C2qVyx_HEtMDg@mail.gmail.com>
Subject: Re: [RFC PATCH 4/4] kernel/workqueue: Let rescuers follow unbound wq
 cpumask changes
To: Juri Lelli <juri.lelli@redhat.com>
Cc: Tejun Heo <tj@kernel.org>, Aaron Tomlin <atomlin@atomlin.com>, 
	Valentin Schneider <vschneid@redhat.com>, Waiman Long <longman@redhat.com>, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hello, Juri

On Wed, Jan 17, 2024 at 12:20=E2=80=AFAM Juri Lelli <juri.lelli@redhat.com>=
 wrote:

> +       /* rescuer needs to respect wq cpumask changes */
> +       if (ctx->wq->rescuer) {
> +               set_cpus_allowed_ptr(ctx->wq->rescuer->task, ctx->attrs->=
cpumask);
> +               wake_up_process(ctx->wq->rescuer->task);
> +       }
> +

What's the reason to wake up the rescuer?

I support this patch except for the wakeup:
Reviewed-by: Lai Jiangshan <jiangshanlai@gmail.com>

Thanks

Lai