Received-SPF: pass (google.com: domain of linux-kernel+bounces-28544-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: <Divya.Koppera@microchip.com>
To: <Horatiu.Vultur@microchip.com>, <andrew@lunn.ch>, <hkallweit1@gmail.com>,
	<linux@armlinux.org.uk>, <davem@davemloft.net>, <edumazet@google.com>,
	<kuba@kernel.org>, <pabeni@redhat.com>, <richardcochran@gmail.com>
CC: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<UNGLinuxDriver@microchip.com>
Subject: RE: [PATCH net 2/2] net: micrel: Fix set/get PHC time for lan8814
Thread-Topic: [PATCH net 2/2] net: micrel: Fix set/get PHC time for lan8814
Thread-Index: AQHaRiLWUn+Omc/2d02iIkxM2gzv/rDdgzAw
Date: Wed, 17 Jan 2024 05:42:23 +0000
Message-ID: <PH0PR11MB4773E467B2A3A76673E2E828E2722@PH0PR11MB4773.namprd11.prod.outlook.com>
References: <20240113131521.1051921-1-horatiu.vultur@microchip.com>
 <20240113131521.1051921-3-horatiu.vultur@microchip.com>
In-Reply-To: <20240113131521.1051921-3-horatiu.vultur@microchip.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?sOq8EMlb5VedNB+L8tGZmLbuxUS1eiddFzCBW4MqT4LTzVzWrAFXZkkXEf6e?=
 =?us-ascii?Q?g5dj2S9HdzXWqdkJsD3Ux+TJDa1c9LYwOk95rj5c0kqMHGCsDE2U34a+HLBR?=
 =?us-ascii?Q?vgjTs35DPqZ1Urp0QE7k3omZmL21aGfWPJWzXcL5eUIT6ge74wt4wXvanirT?=
 =?us-ascii?Q?DLTrz8kcPuMPNR3J81RAgr5RwWLfcnKty2M4nY1330lSsAqUqoZ+uNWmCQ6u?=
 =?us-ascii?Q?qXKbAKNmkOuMkbJkT9fbLGbSh0wQUPzvmySd3a1QcNwUO+TwhBHtL+CCWEVT?=
 =?us-ascii?Q?pkZg6JCpsYYOXEqaVoYp41A8Yy7VoUN2/DH391DAxwTtDLBf6f1mc/40iMBp?=
 =?us-ascii?Q?B4xohwGvXu4TF3xS4JXHn22WExBvqR5HSeyNG7/r13Mb131bcH+TWkKSgemP?=
 =?us-ascii?Q?8UbIxQ1QgxWZ96lprb1sqXTNAmst5ia9WRHM0eyYrlOvlfpnTndR5gMG6yL6?=
 =?us-ascii?Q?sHuD3FTG6gWRS9dJwbtWDsF0NdDMbiCG7nJjCjPKITrll//uC9Y5TwHlRqFX?=
 =?us-ascii?Q?zjgsF+flNzxUp9WEkf50looprnRiQaFZOb0cIdTmDjQwtlF5tfpdhIlSAUCp?=
 =?us-ascii?Q?BVgswEqNjBHcnf0ydy6b5kzdEmWB31u5Ovz/k5tojTkPtT97bFkbvtS/yOT2?=
 =?us-ascii?Q?4XPa+Op/kmi6OsLPE8qcGZNmqGYn4VFEMgGwjvUuXD+MfPKQm3V9OdVxq6NT?=
 =?us-ascii?Q?Cq5sZRrFn/Gtnevs5qUPlrkFsD19TS+6NT+jIrYYX7euYsxhJGtni9WXe9Fm?=
 =?us-ascii?Q?gx+5jsR4WClBaadlPCuMLDw2vNT+CJarlwBqJ0xZTM8k+yRDsyypKOCwnDEH?=
 =?us-ascii?Q?q+268jCpkLKG5pcggmwKSgSrKQyPa9VxqMDl2SaTJSx1JiXxluBNlqPwJwRp?=
 =?us-ascii?Q?UXVWcu6DBseNPTtV6+Umcd4MIN825f7kSCPZqesCn0pC3iOflsoCJ8my5xnC?=
 =?us-ascii?Q?jhPfYf2Afk/aCI27xwl4EEfQB8Z6FLI89SGFmCi/7+KPkESb4FfB/oTLMYUd?=
 =?us-ascii?Q?OjuMq2I4XC7ib6GJbD1zJmc3rvIDlG1fEyFmMU/wI1fruGYWFO0yX8iVNjHc?=
 =?us-ascii?Q?2m3F+zI8wsdgpQkLruyJfpr5+FobX6XeAOv0wTEpoCOMyB3Wb7jmINU4VJ14?=
 =?us-ascii?Q?eYmYapLGBsDeNjV5wmO6hstS980QKg3aQzV8ed8JKe/U2UOx9crfNDR0QOAU?=
 =?us-ascii?Q?epzNBDOAo0F/Mo5Js21nAy3eSWZjOXEZbJCsLGLB4iFeuVz9ZOsdjlUWhL5q?=
 =?us-ascii?Q?amceauQjx8s8d/6lE0AUmBQQSIc776QzikGAW+I+phVi2RcKWPE1nAg3iMRK?=
 =?us-ascii?Q?oi+dPmwjU8X2y+WWvqGurD+HvlplSo8Bq/ZDrRwK4cMKx7z7ibV/ofgOCPpf?=
 =?us-ascii?Q?FsoWZ8uM1gnpWAt1f226wpkuDOLZgdPEzt/7iu0oZz7b+aBiEcpHxypB9kpU?=
 =?us-ascii?Q?K1oTYXQxxtFJvoXpP7YA9dYQfEPgGTCWtqn+ha+2q27P7lQ5F0X6gfs2VIBm?=
 =?us-ascii?Q?H6WKzcWDz11Yq52+BNxYm77qmMWVlD3l0aE4HWhs29W5rJ0Iatv428Ij/NF0?=
 =?us-ascii?Q?4lqRJdP3iIfU/nlwFHE3omJT/qLrtRkuLtzvd+4Q44az2tfX9tMv88JE/j3R?=
 =?us-ascii?Q?Kw=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB4773.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: aeec6bcb-a1b9-4637-2943-08dc171f14b2
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Jan 2024 05:42:23.8150
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: a0w3luQeRclZ/LeGmoebtGxjqSlkqBCH0vsLh9KMZ1d4uK/pu9F2oNgwk+oFJOXsx4wyFrlVaWY+TeJOeI/JCRzePHHfUSsFbCt0krlXswo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5133

> When setting or getting PHC time, the higher bits of the second time (>32
> bits) they were ignored. Meaning that setting some time in the future lik=
e year
> 2150, it was failing to set this.
>=20
> The issue can be reproduced like this:
>=20
>  # phc_ctl /dev/ptp1 set 10000000000
>  phc_ctl[118.619]: set clock time to 4294967295.000000000 or Sun Feb  7
> 06:28:15 2106
>=20
>  # phc_ctl /dev/ptp1 get
>  phc_ctl[120.858]: clock time is 1.238620924 or Thu Jan  1 00:00:01 1970
>=20
> Fixes: ece19502834d ("net: phy: micrel: 1588 support for LAN8814 phy")
> Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>

Changes looks fine to me.

Reviewed-by: Divya Koppera <divya.koppera@microchip.com>