Received-SPF: pass (google.com: domain of linux-kernel+bounces-28551-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <ce4f98a3-7683-490b-a717-0eeb035cbd86@gmail.com>
Date: Wed, 17 Jan 2024 14:11:46 +0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] block: fix length of strscpy()
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
 stable@vger.kernel.org
References: <20240101175051.38479-2-pugokushin@gmail.com>
 <cb12eefa-9588-4244-a1de-b1ea62f6096d@kernel.dk>
Content-Language: en-US
From: Guoxin Pu <pugokushin@gmail.com>
In-Reply-To: <cb12eefa-9588-4244-a1de-b1ea62f6096d@kernel.dk>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 02/01/2024 05:26, Jens Axboe wrote:
> On 1/1/24 10:50 AM, Guoxin Pu wrote:
>> In commit 146afeb235ccec10c17ad8ea26327c0c79dbd968 ("block: use strscpy()
>> to instead of strncpy()") , the length that should now represent the length
>> of the string with the terminating NULL was not updated alongside the
>> change.
>>
>> This has caused blkdevparts= definition on kernel cmdline to be not
>> correctly recognized and partitions not correctly initialized, breaking any
>> device relying on such partitions to boot, on stable releases since 6.6
>>
>> This patch fixes the lengths to contain the terminating NULL.
> This needs a Fixes line.
>
Sorry for the late reply.

Thank you for the review. The Fixes line was added and I've sent the new 
patch as "[PATCH v2] block: fix length of strscpy()" earlier on Jan, 2nd.

And since 6.7 is out, do I need to rework the v2 patch and add cc stable 
6.7.x?