Received: by 2002:a05:7412:8d1c:b0:fa:4c10:6cad with SMTP id bj28csp229792rdb; Tue, 16 Jan 2024 23:18:36 -0800 (PST) X-Google-Smtp-Source: AGHT+IHK7SkgS6k4DP103W47UpPEdPlSWaRq9qUsUjKWgfy7oHQN2RFEt4xGiqPzltoaHwVF8RzU X-Received: by 2002:a05:6214:4114:b0:681:6623:dbf5 with SMTP id kc20-20020a056214411400b006816623dbf5mr4058664qvb.111.1705475915846; Tue, 16 Jan 2024 23:18:35 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1705475915; cv=pass; d=google.com; s=arc-20160816; b=NSH/SxybtGVc9MOaqIvrzGlL9ZPyrMCShuXcg9AVTklQ/DJXcw1uB8ZbhgFGIjivk5 5YN1nV+Utd1HTNQShdJtLSOwcyDS+LKU5nq7r7WaYhSW8W+MMFj3qtipTgO+nD/XcWa+ 4NtrMZaphaqH1K8bS+oQ+7wYjTocRETBrk9RhViHsVaAqGiaMPAnKuMXxN65ZiCukT3G 8akISbiSSgGwFKrMD5oVCTbwCAQfTY2DOf1Hbi1RLbPFQb6FaPKDRA9WOHT6njYfIS1j esrG5kDvoWBSV1d6mSsz75TxfirSBqBJfxL0JJX+WH+rJgTlGYdVeZ5f+Gr65Kl0k/9p PfIQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :dkim-signature; bh=3EQRRw7jZs+7rhvm0pp3ec3+dkHb+ZBu+iZ5gNOr0Ic=; fh=pCEnymo6pFVff0d4iZKkeucwZfGlHpk0lLTPn57F2VU=; b=n09xnsdhiqTAsp5sCK+5FjpZ9lw8eEKTWn84GFcLRjRQrw2ENgRefgACGjkt19NDCo 6/MLsin/U3KkFRg0Kmirv6FXJXZTsOo/+AF0lD5FcVc/PtCd3UxTd9uqBCYvrSIpd4Cq YAEqrr2c4zSglwzz/l6xuUeSXS+ehUsm0cNvzfFT7YQOivcHPEBnDVa7xO1qOTxNOZA4 M45on6xXwFAcISK/a5MXMiRLTQU+QvtPaAOvS+qzwDt60Rhi+Od9N5Me/OZPhD+DMmYT 43IxNFtPefW7OFOOCMi5foY6tqAOR5CSLL9U8wXJ43KVvxMB+tUWHt66SgiyE3GfPLuC LGnA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=T3wGXtpC; arc=pass (i=1 spf=pass spfdomain=google.com dkim=pass dkdomain=google.com dmarc=pass fromdomain=google.com); spf=pass (google.com: domain of linux-kernel+bounces-28590-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-28590-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id m5-20020a0cac45000000b0067f1b8febe2si11161835qvb.98.2024.01.16.23.18.35 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jan 2024 23:18:35 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-28590-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=T3wGXtpC; arc=pass (i=1 spf=pass spfdomain=google.com dkim=pass dkdomain=google.com dmarc=pass fromdomain=google.com); spf=pass (google.com: domain of linux-kernel+bounces-28590-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-28590-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 9A11F1C22061 for ; Wed, 17 Jan 2024 07:18:35 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 90F20B677; Wed, 17 Jan 2024 07:18:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="T3wGXtpC" Received: from mail-qt1-f172.google.com (mail-qt1-f172.google.com [209.85.160.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C7EB8F47 for ; Wed, 17 Jan 2024 07:18:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705475905; cv=none; b=sop8MT5pJ6iy/rJo/9kIgjlTM0IL9QAiRrQvV4/B4PBXSK6pTfLsZvaZSj5qPofss1dwOzwDVRoiKQtjPyKAJrLSKlacz/MRWMRh6EokEEKF0zOnKo2w8T09BRCGhi+Dk6f09HOHp0edDXnAKmq3Qi3+2w/aHN8AigqdFQ9QN48= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705475905; c=relaxed/simple; bh=C7GeLNiGP5bRjIx6Fc77DzlLph77+xnFMKo5ep5RaK8=; h=Received:DKIM-Signature:X-Google-DKIM-Signature: X-Gm-Message-State:X-Google-Smtp-Source:X-Received:MIME-Version: References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc: Content-Type; b=mWs0iM+62JWHTMaERkKG4rnka7c01W6cbPQWSBpWBpfn+u+KQR7Y1kynf9GwFJQSkmKWOqnQXn88NqPxcxjH1WgNpemydfRTooN2sHkVNhKTqXlobmRLx9AGgV9szTnsUWM01CBoQfSOuAdHlX8uCsOmW7Z3DpARmeHL3po0GDE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=T3wGXtpC; arc=none smtp.client-ip=209.85.160.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Received: by mail-qt1-f172.google.com with SMTP id d75a77b69052e-428405a0205so98711cf.1 for ; Tue, 16 Jan 2024 23:18:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1705475903; x=1706080703; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=3EQRRw7jZs+7rhvm0pp3ec3+dkHb+ZBu+iZ5gNOr0Ic=; b=T3wGXtpCGfOVD18PsxQ0gk2eF85fKmp+c0MSpCMlWUkC4j/pR4mili5lzfmtEOJ0NU v+ryiAM2RNshko4x0LABuVCSOYezRiA7bS64PtNe38BkHk45Mh0XbqJOVunPmKzr/Np+ k3U7JuYvDMY9dBV2+3EV5hzkrUKiAXnn0xbHOkc+jCtlAPWGeON9OXshEEDf0a4bP/xH XycK0sTLb67DPCrQt3dyiN1+kHmySpa2H47D00/EkqL5uz3qJ0mHaaTijTYOUNV9hep/ lWKbWwtfmWswqeRBSIMVyQ0LOHxWDUAo/NXygaXFfL+9jX+jqA2XCQMkDflYi38Cp/uR 7xNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705475903; x=1706080703; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3EQRRw7jZs+7rhvm0pp3ec3+dkHb+ZBu+iZ5gNOr0Ic=; b=fDbV8b2wyuzpnq4LUjDUoalovJoGWmfc6dKigswGP9HLUjjENR4ZmaPPqZXEB6A+o4 31xJAYz9zGaK87Qjn1A8zQHAgUQ9uenRV1yYjVIAKJOPNRjXrnJyAXImPN5pRmBlhNUP BIeEJ/kvIZW9lU2Nb3Vna388mch6PXffwjsllN4s8WTDpXWwynM/isVuJIk5PT3w08JB hA9UEvQc9/zQN408Deo+1k6LvTRdC9wp8ayHLNU50wNGCBGmnAmL6TXK/cFwTuY/B8dc EbFN1t4Mgze0VFw6nqvTVehSSz2ieLO0MaojnqPVKrYrU7mD6txP710lVufu9EYSMKQU 3k6A== X-Gm-Message-State: AOJu0YwsS+j28h5E8ql4JTWBXRv0XVPNRly4C6maWMtRYUlpTIA71F4p VyWCHJYcQgpxRFo0nvE0Ahh3skQ2ieE5BZXNEwGXl8COQYgxlik2UIbSzsSSdck1lk1M7qqQDf4 mVY/NOUmfwDc0Hmmymk7L6HLpcb3AHZUy4Ko5 X-Received: by 2002:ac8:6f11:0:b0:42a:220:82f3 with SMTP id bs17-20020ac86f11000000b0042a022082f3mr87321qtb.21.1705475903265; Tue, 16 Jan 2024 23:18:23 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240110095532.4776-1-quic_uaggarwa@quicinc.com> In-Reply-To: <20240110095532.4776-1-quic_uaggarwa@quicinc.com> From: Kuen-Han Tsai Date: Wed, 17 Jan 2024 15:17:55 +0800 Message-ID: Subject: Re: [RFC PATCH] usb: dwc3: gadget: Fix NULL pointer dereference in dwc3_gadget_suspend To: Uttkarsh Aggarwal Cc: Thinh Nguyen , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Content-Type: text/plain; charset="UTF-8" > ret = dwc3_gadget_soft_disconnect(dwc); > if (ret) > goto err; For improved readability, we can remove the goto statement and move the error handling logic here. Thanks, Kuen-Han