To: "David P. Reed" <dpreed@reed.com>
Cc: Thomas Gleixner <tglx@linutronix.de>, linux-kernel@vger.kernel.org,
       Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
       Rene Herman <rene.herman@keyaccess.nl>, Pavel Machek <pavel@ucw.cz>
Subject: Re: [PATCH] x86_64: fix problems due to use of "outb" to port 80 on some AMD64x2 laptops, etc.
From: Andi Kleen <andi@firstfloor.org>
References: <466F0941.9060201@reed.com> <1181682498.8176.224.camel@chaos>
	<469578CD.3080609@reed.com> <1184216528.12353.203.camel@chaos>
	<1184218962.12353.209.camel@chaos> <46964352.7040301@reed.com>
	<1184253339.12353.223.camel@chaos> <469697C6.50903@reed.com>
	<1184274754.12353.254.camel@chaos> <4761F193.7090400@reed.com>
Date: Fri, 14 Dec 2007 11:51:24 +0100
In-Reply-To: <4761F193.7090400@reed.com> (David P. Reed's message of "Thu\, 13 Dec 2007 21\:59\:31 -0500")
Message-ID: <p73prx9ft1v.fsf@bingen.suse.de>
User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 805
Lines: 22

"David P. Reed" <dpreed@reed.com> writes:
>
> i386 family fixes (completely parallel) were not included, considering
> that such machines might involve more risk of problems on legacy machines.

They're needed because lots of people fomr some reason still boot 32bit kernels
on 64bit machines.
> +#define __OUT(s, s1, x) \

> +__OUT1(s, x) __OUT2(s, s1, "w") } \
> + __OUT1(s##_p, x) __OUT2(s, s1, "w") udelay(_IOPORT_PAUSE_DELAY); } \

With the additional call this should be completely out of line now to save 
code size. Similar for the in variant.

-Andi

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/