Received-SPF: pass (google.com: domain of linux-kernel+bounces-28626-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <c9f5b6b7-7e01-5b99-c2a9-1bbfd50ebb27@windriver.com>
Date: Wed, 17 Jan 2024 15:56:26 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH] ARM: dts: tps65217: add power regulator & backlight
 drivers support
Content-Language: en-US
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20240117043323.2008454-1-xulin.sun@windriver.com>
 <70d52400-13b8-4f2f-81e3-0753e77e129f@linaro.org>
From: Xulin Sun <xulin.sun@windriver.com>
In-Reply-To: <70d52400-13b8-4f2f-81e3-0753e77e129f@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?QmtoeTJlSG1tcUx6VTRWeEk3K0p1amhxR0xKQ1UwWDhQZC9PcE9TTEEyTk5T?=
 =?utf-8?B?a1FyQ1BvUUF2MTNTUGE2QTlJaHdWSEVqV255L2JScFhtWldnNVpaaytiSWli?=
 =?utf-8?B?TGNhNXlXd3JMdzQ0OHZFdCtWRjhxR1p6dUEvOHhJajViN0FDQmtTVjAwQkFG?=
 =?utf-8?B?ZlJzUXlrUzA0Z053SUpMMzdwT3BYOVNKV3hNRjh1dHY5bi9aTFQ1R1VEWTNZ?=
 =?utf-8?B?NTNxdTRram91QVpRUS8yK2tVM3lmRDg5VERwY1FRM0plbnEzREFYVU81RXNW?=
 =?utf-8?B?UWFZMS9kN2FqbCs3bExXck5RQXVGVFFaZ05adldlc1N1QlRudVo1ODA3Q0FC?=
 =?utf-8?B?bkxzZ2hielh6ZUQzcHo5UmRZNUY1MWIxZVZpbHpGcDBTS3NEcnc0ek13Q1Fl?=
 =?utf-8?B?ZjIvNWUxM2E1ekV6cDZKVUpwQlAwdnFTNDZOYUNlMk02aWIxMzdndlVRSHVQ?=
 =?utf-8?B?TUpBaUdwR1YvdkNkWXF6SVNTeEdPMnBKdzBXdjYwS3RVTDh1MUFvUEJsWWtx?=
 =?utf-8?B?dHpTNklXLzVZZ0w1YTBjWnZMVXVkcTRjN25XQVp3bkFPdUVUWHNoelZVOHhy?=
 =?utf-8?B?VlQ4c0pmNDlSeUdUdmJoSHRWaXBRdUk2cnU1eEF0bXpML1A4cDVaQXVsTXZt?=
 =?utf-8?B?NjREbnlkTzRvSUVPbW1vQlkyUk1CbFE3RDhIbjF2S2Q0OTNPdk5zV3EvMnl5?=
 =?utf-8?B?TDBZT2tLWlhEaWszNytic0lVTEdVOTE1STR3alNPelVMeEs0SEFjNmlSbk4z?=
 =?utf-8?B?VzVta3ArMFlpdjJHUEpNcWhWdnlnZlVoS3YzbDV2NFVReWdJNjhpWXdWTVox?=
 =?utf-8?B?M0dnL2lGM2JUcXRVT05IbWZFaStJMXF5RjhJdmVuZVlOOUpOVm85ZS9wRlZW?=
 =?utf-8?B?TzYzKzQxdXFHc3JvZGhDZUxMQk5DZzRtTlJUMEd4RElSeU5VbkdvUHlCZ1Jx?=
 =?utf-8?B?NXdaekdWSUt1bFRuZitTbENjeUNoSG9Oc09uMnE5ajl1Nk9lK3RSbEpyTW5a?=
 =?utf-8?B?NXp2VkRQcXB0M0lEME9leTdHVWlscDR4QzJFOVJmaUsrNlBLZCtTMG5zaEVX?=
 =?utf-8?B?QXBoOHB5ZzRvQjJBblBBRVlUZTFaTzJLZ2pQdVV4YjRzY0ZWdjBHZVRjZTdV?=
 =?utf-8?B?YjczQWVaSFg1aklXOTVqT0kxdmJqU21qTkRkbTlnYWxqNVU0eDdFUldiQ1ZC?=
 =?utf-8?B?OWJNSjNLc0VUaFd5QjRBZzZPend2akxIR2hweldBUmorZ0tvUGFYSi9MOHYy?=
 =?utf-8?B?dW9qYzdGcDk5NjZZZVcxNHY5VE9MNFZHZEhvUXpNZE84bmpVb1V3WmsrNURC?=
 =?utf-8?B?LzlUdFdWN1E4R3JpcTBVcUo2RnVDUXNKOXdyZjMvTm1KRlhSdmFTQ29ZTjEz?=
 =?utf-8?B?d3R5N3p3UXJ4bFJMN2tIYmpyZStBSmxDS2h2cWZNdlVVZnhHOHZkUERDY1Nz?=
 =?utf-8?B?L05yTnV4ejhwSXhHN2x3dFlTQjlib084VXFXbEE4MHEzOWtYMWhDelFkN1Y2?=
 =?utf-8?B?dGJWZ2xlL0hLNHFBaDdWNzFLOHlnWC9sNVJoN3hZUDFvVGNqdTQrT1FmVmpi?=
 =?utf-8?B?bjZTZVJ2UVNRYktpWkNURHFNRWpIVi8rdDJaQlhHZ2VLKzVRYU83eDZqWmpw?=
 =?utf-8?B?SlpZM1JvaFI1VUVOZEV4Q3Nwc2krOGZFUDU1SkZobXBrNFJLRmNTSE9oT2dm?=
 =?utf-8?B?amRoM1VCK1E3UHlWOWxYVkRXcUFSTFViSTJIOTArZWxUR0dzTUhISlc1amRV?=
 =?utf-8?B?ejBhQmVzWDlJNkhMMUpOb3l5a3k2dUswZEVzRlhSdFVCeDFaSUUxQ2tWWDh5?=
 =?utf-8?B?V05hRFYrK1lpRGZ4VUxvV3RlaXFxckc3b3NGVlNFZFBqUmU3a1NIRUtyUEps?=
 =?utf-8?B?aitqWjVqNXJ1T0ZodCtSdDlBYm4xNzZucHdENGd3QkNNL2RucHZYYnlIZDBQ?=
 =?utf-8?B?emY3emxydUJZcVVkTXpkUXdDVnJ6REwyUWVFM3FYa3RuQWZpQWduRjFHUk0w?=
 =?utf-8?B?WGcvcGRydnlNQlUzYWlPSzc0bnJNQy8wSHFtWHh1aTZFN3FIRDdrdDBzZW9t?=
 =?utf-8?B?c1I5bnJMTmZhbi9qc1d0eFA4NHZkaFZMMmZ2QlJNTFVFc0w5ajhXTzRsYStq?=
 =?utf-8?B?dFpsSTNrd3R5TXRQVFRNUjBNdnJwdFRXS1BXV0ljaHhkUU5HR3VhRG1HV0JJ?=
 =?utf-8?B?RWc9PQ==?=
X-OriginatorOrg: windriver.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5d1cf4be-24e0-48cd-4357-08dc1731d161
X-MS-Exchange-CrossTenant-AuthSource: SA2PR11MB5193.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jan 2024 07:56:31.5638
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ddb2873-a1ad-4a18-ae4e-4644631433be
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: dkIkcaN/goiUsaxHGTQaJbENhCVknwVxY5JRZ1ky6JPLzf8iqWYIfs0VB10JfTXwmoy0z9+dhzQPo46meA/2jg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7681
X-Proofpoint-ORIG-GUID: TzQr1pBgcJdj-rmpVOy-jaEHt2VrLByr
X-Proofpoint-GUID: TzQr1pBgcJdj-rmpVOy-jaEHt2VrLByr
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-01-17_04,2024-01-16_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 adultscore=0
 mlxlogscore=494 suspectscore=0 phishscore=0 lowpriorityscore=0 spamscore=0
 clxscore=1011 malwarescore=0 priorityscore=1501 impostorscore=0 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2311290000
 definitions=main-2401170053

On 1/17/24 15:24, Krzysztof Kozlowski wrote:
> On 17/01/2024 05:33, Xulin Sun wrote:
>> Support TPS65217 voltage regulator driver and TPS65217 Backlight driver.
>> And enable them by default. This will avoid below booting failed
>> information:
>> tps65217-pmic: Failed to locate of_node [id: -1]
>> tps65217-bl: Failed to locate of_node [id: -1]
>>
>> Signed-off-by: Xulin Sun <xulin.sun@windriver.com>
>> ---
>>   arch/arm/boot/dts/tps65217.dtsi | 10 ++++++++++
>>   1 file changed, 10 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/tps65217.dtsi b/arch/arm/boot/dts/tps65217.dtsi
>> index 0d463de5650f..f412e7476660 100644
>> --- a/arch/arm/boot/dts/tps65217.dtsi
>> +++ b/arch/arm/boot/dts/tps65217.dtsi
>> @@ -13,6 +13,16 @@ &tps {
>>   	interrupt-controller;
>>   	#interrupt-cells = <1>;
>>   
>> +	pmic {
>> +		compatible = "ti,tps65217-pmic";
>> +		status = "okay";
> Why do you need status here?


It corresponds to the drvier: drivers/regulator/tps65217-regulator.c, 
and regulator is one of the main function of TPS65217.

I think it should be enabled by default, so set status to "okay" here.


Thanks

Xulin

>
> Best regards,
> Krzysztof
>