Received-SPF: pass (google.com: domain of linux-kernel+bounces-28661-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240103081042.1549189-1-alexs@kernel.org> <xhsmhy1d5ids9.mognet@vschneid-thinkpadt14sgen2i.remote.csb>
 <CAJy-AmnLR-Gw1zbRC_W1aCG5Ouy8VRunW2++mYFBGeJ7Po5viw@mail.gmail.com>
In-Reply-To: <CAJy-AmnLR-Gw1zbRC_W1aCG5Ouy8VRunW2++mYFBGeJ7Po5viw@mail.gmail.com>
From: Alex Shi <seakeel@gmail.com>
Date: Wed, 17 Jan 2024 16:48:14 +0800
Message-ID: <CAJy-Ammg6Cj18f76bEd9Ht3=pijgXxkeKs=1X6ju1M0HvsCwhw@mail.gmail.com>
Subject: Re: [PATCH v2] sched/stat: correct the task blocking state
To: Valentin Schneider <vschneid@redhat.com>
Cc: alexs@kernel.org, Ingo Molnar <mingo@redhat.com>, 
	Peter Zijlstra <peterz@infradead.org>, Juri Lelli <juri.lelli@redhat.com>, 
	Vincent Guittot <vincent.guittot@linaro.org>, Dietmar Eggemann <dietmar.eggemann@arm.com>, 
	Steven Rostedt <rostedt@goodmis.org>, Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>, 
	Daniel Bristot de Oliveira <bristot@redhat.com>, linux-kernel@vger.kernel.org, curuwang@tencent.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Alex Shi <seakeel@gmail.com> =E4=BA=8E2024=E5=B9=B41=E6=9C=884=E6=97=A5=E5=
=91=A8=E5=9B=9B 19:29=E5=86=99=E9=81=93=EF=BC=9A
>
> On Thu, Jan 4, 2024 at 6:38=E2=80=AFPM Valentin Schneider <vschneid@redha=
t.com> wrote:
> >
> > On 03/01/24 16:10, alexs@kernel.org wrote:
> > > From: Alex Shi <alexs@kernel.org>
> > >
> > > The commit 80ed87c8a9ca ("sched/wait: Introduce TASK_NOLOAD and TASK_=
IDLE")
> > > stopped the idle kthreads from contributing to the load average. Howe=
ver,
> > > the idle state time still contributes to the blocked state time inste=
ad of
> > > the sleep time. As a result, we cannot determine if a task is stopped=
 due
> > > to some reasons or if it is idle by its own initiative.
> > >
> > > Distinguishing between these two states would make the system state c=
learer
> > > and provide us with an opportunity to use the 'D' state of a task as =
an
> > > indicator of latency issues.
> > >
> >
> > get_task_state() already reports TASK_IDLE as 'I', which should be what
> > userspace sees (e.g. via /proc/$pid/stat). This is also the case for th=
e
> > sched_switch and sched_wakeup trace events.
> >
> > I assume what you mean here is you first turn to schedstats to check
> > whether there is any abnormal amount of blocking, and then if there is =
any
> > you turn to tracing, in which case you'd like the schedstats to not mak=
e
> > things look worse than they really are?
>
> Yes, switch/wakeup or others could help to figure out real blocked
> time, but with this change, schedstats could give a neat and elegant
> way.

For all of the shortages I can imagine, we can't treat blocked and
sleep states as before,  and that may force some scripts to change on
these things, but giving 2 states the correct way is better way, and
make sleep/block state more meaningful and helpful in normal usage.
Are there any concerns on this?

Thanks
Alex