Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932182AbXLNLDe (ORCPT ); Fri, 14 Dec 2007 06:03:34 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1761617AbXLNLDZ (ORCPT ); Fri, 14 Dec 2007 06:03:25 -0500 Received: from www.tglx.de ([62.245.132.106]:55580 "EHLO www.tglx.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760954AbXLNLDY (ORCPT ); Fri, 14 Dec 2007 06:03:24 -0500 Date: Fri, 14 Dec 2007 12:03:12 +0100 (CET) From: Thomas Gleixner To: Miao Xie cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] time: add an offline-cpu check in add_timer_on() In-Reply-To: <47625B94.50105@cn.fujitsu.com> Message-ID: References: <47625B94.50105@cn.fujitsu.com> User-Agent: Alpine 0.99999 (LFD 796 2007-11-08) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 598 Lines: 21 On Fri, 14 Dec 2007, Miao Xie wrote: > Hi everyone, > I think we need a check in the function add_timer_on() to avoid adding a > timer into the timer list of an offline cpu. > > This patch fixes this problem in add_timer_on(). No, the patch is not fixing the problem. It crashes the machine. Where did you run into this problem ? Thanks, tglx -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/