Received: by 2002:a05:7412:8d1c:b0:fa:4c10:6cad with SMTP id bj28csp268201rdb; Wed, 17 Jan 2024 00:57:58 -0800 (PST) X-Google-Smtp-Source: AGHT+IEMkyXIC3NTgvI+/T9klo+Q8pN7wk0s9M6DWroFo9g96uDOmf0JXYsNyheGg1kabhZ1uBmZ X-Received: by 2002:a05:622a:1b1c:b0:42a:10df:726e with SMTP id bb28-20020a05622a1b1c00b0042a10df726emr312209qtb.20.1705481878358; Wed, 17 Jan 2024 00:57:58 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1705481878; cv=pass; d=google.com; s=arc-20160816; b=hH7qjuou3quFUHux6w0vctY6swo0Q3oz0RcXr93ufO6rxUxQ+RWtlWH8DO1nvv34xc iEpBCeoUg6N3aRV0s15viqerK2btmq17dRzAxFJ7kGQ34heP+u73bgpaI7FXHu+Y/HTN CmbCE89uXIfbS+kBhVxnPSRHXodH26/67O+Z7MvYxZSP81lp00oqbOv6OnIZGMqkDbbT pEvqtch3d3p//4W9Pyq6hLgnVxqHjfBR/axdEdYzOIn93dI/WHW+x+vut3j+1ww1rPxI OpMj0DIcxM7wGe1fdhb2BViYZIP9rgIBmAElzJOhnTdLmr5Le5J9IXrCi6nYGBlDQh9u 658g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=8rKJxw+V9JYvW4wnJNhpRgzFKkJmMiRwDOgeYAGlV2Q=; fh=2ooNcWiF1wbXc4MOpItQ0J3HmpaFWSgX1s64XQR6nBA=; b=VG+1uDOT0Yk5OtCmMG0Ig2RuGAA67jbJYS4rG0pZOZz/HGKlIFuK2AVPjKrIfxF17U r8JefANUFwQI6acUa2IrZm4o+X961mmngj7i/kgPLsXzdBMoYI9J7xLm9mlamO5sIAJA OIT3epTZGrnkZasHi47mCCLBYU8xVHjp18wZ1ADJxxfies4zZ/mZuW2a8S1lwclKq519 8dfaizIPEcyN+d2SICSnpWri9qR8qO5VGBBtUNxhwlQ1KbTIhnPWjK/TyW/ox72qouIx thiz0Ne0SslFP2UHB1bEWqGmnxhMhOf/nqWZ+oyzl5llNLp3hXsO4Ki8aGSpjdxwEX7O 0uQA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=DQPro8+A; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-28674-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-28674-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id d15-20020a05622a100f00b0042a1115649dsi297166qte.211.2024.01.17.00.57.58 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Jan 2024 00:57:58 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-28674-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=DQPro8+A; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-28674-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-28674-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 208AE1C248B5 for ; Wed, 17 Jan 2024 08:57:58 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A018E1DFC8; Wed, 17 Jan 2024 08:56:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="DQPro8+A" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CD1D31DDF8 for ; Wed, 17 Jan 2024 08:56:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705481764; cv=none; b=gvcwi45TSDf8Ny7TrwsjpygYoSX5g28CEl9WcfnWxhF3pnEdggEJyWQM+IZIW3o6d2DhKd2nRbj1sZYFx8FoxCWvpivg+nXoqxffmQmDKzMmukwTiynGPvTr+Q4wQGJVdYjIBjdTUIk/ifuAbUKGR4Zhf2pwiVB9hRdsKyq5FCQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705481764; c=relaxed/simple; bh=BpcqVNZ8ffNdT1y7g2xcioG/6BH0/8tEnBf+zOJis+8=; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID: X-Mailer:In-Reply-To:References:MIME-Version: Content-Transfer-Encoding; b=B8E7sQbBSedzYdkcI7Wn10F/wE/8ImPJgF6TdzIK2cmVK772XxhQSU8pySyfuPg2l2FQ+z+dLhCegjwUyC9bg0DF4KjdhucRTo8A9PLQRX5QP0u/Dut2Km13qaIRy+tRRTsKW39wpgnQ4j+iZJlwjKj1+lr7UoPwqD9nBipbmY4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=DQPro8+A; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id A0592C433F1; Wed, 17 Jan 2024 08:56:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1705481764; bh=BpcqVNZ8ffNdT1y7g2xcioG/6BH0/8tEnBf+zOJis+8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=DQPro8+AjYJWrqOdEO26JABPCXwg16DvQHdwmltEa6jJBIPVOdIeT+LwdRMd6odez BaX8yFA7cjBL28uQn0JIi5szxOAF0kL86Pqsm7/NgKajVvXZdtZ8hUGxU29TU5jSd0 GNcVpEyi5ZY6j1H+wj9LVjw9tRphXGgx51LOcf5gOQylT+PaaTMCjqm70EQOBW2Vwe J6ytRN/f9u8HPMvLL6vgQoHWHF+WLzbNsshcm/FET950r4Fem/AdhGcZq00m63vslG vWDT7+GUAfdWg3CL/1qjxDo+TyWn65tM4QepS28vldl+AHBuIFzam790YyDhW/EUE2 vDwAWvyzvjIUQ== From: alexs@kernel.org To: Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Daniel Bristot de Oliveira , Valentin Schneider , linux-kernel@vger.kernel.org Cc: Alex Shi Subject: [PATCH 3/5] sched/fair: cleanup sched_use_asym_prio Date: Wed, 17 Jan 2024 16:57:13 +0800 Message-ID: <20240117085715.2614671-3-alexs@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240117085715.2614671-1-alexs@kernel.org> References: <20240117085715.2614671-1-alexs@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Alex Shi And simplify the one line code. No function change. Signed-off-by: Alex Shi To: Valentin Schneider To: Vincent Guittot To: Peter Zijlstra To: Ingo Molnar --- kernel/sched/fair.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 8d70417f5125..ebd659af2d78 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -9741,10 +9741,8 @@ group_type group_classify(unsigned int imbalance_pct, */ static bool sched_use_asym_prio(struct sched_domain *sd, int cpu) { - if (!sched_smt_active()) - return true; - - return sd->flags & SD_SHARE_CPUCAPACITY || is_core_idle(cpu); + return (!sched_smt_active()) || + (sd->flags & SD_SHARE_CPUCAPACITY) || is_core_idle(cpu); } /** -- 2.43.0