Received-SPF: pass (google.com: domain of linux-kernel+bounces-28811-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Wed, 17 Jan 2024 11:09:27 +0100
From: Maciej =?utf-8?Q?Wiecz=C3=B3r-Retman?= <maciej.wieczor-retman@intel.com>
To: Reinette Chatre <reinette.chatre@intel.com>
CC: Fenghua Yu <fenghua.yu@intel.com>, Shuah Khan <shuah@kernel.org>,
	<ilpo.jarvinen@linux.intel.com>, <linux-kernel@vger.kernel.org>,
	<linux-kselftest@vger.kernel.org>
Subject: Re: [PATCH v2 1/4] selftests/resctrl: Add test groups and name L3
 CAT test L3_CAT
Message-ID: <bhqwsfql6zsjydavi2n7fqc2gd5xg6bssgkom6dabg5hzg46z6@aah7fdfsoynj>
References: <cover.1702392177.git.maciej.wieczor-retman@intel.com>
 <de2ea86256f0026989e6836f9e731be3667c7afe.1702392177.git.maciej.wieczor-retman@intel.com>
 <65e7aab3-ac50-442e-b559-00f2345c8a29@intel.com>
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <65e7aab3-ac50-442e-b559-00f2345c8a29@intel.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?RxzQEhRb01UpOogcY5FdvOgSMIK0rHwYDGYa9/ARPz5eQPp0f4DayZtOYo?=
 =?iso-8859-1?Q?Rm/xTre4fukCEQUkk+/8949ij+qm0v+NRPqkNOhshlTGBSPuuT4At98a+g?=
 =?iso-8859-1?Q?p0C2FRgB9KZr92jKUEb8TMzJuJ5viXalLjGGCCnKLF/5wX+StUzEn31I3w?=
 =?iso-8859-1?Q?9SfKyWdyA3E9tBjw+tbVqrSnj8tutvCL3cM8SGQKP+2gtyrhVKqCvmRtdG?=
 =?iso-8859-1?Q?LJyRF4jjWyh63cCOvl9XFlmRNiOjE0SpAW+ZbsAhzk8NHyl9r+QQjg+vVn?=
 =?iso-8859-1?Q?kslRwfPaXm853QLvb4I+eD7gt9/jEigdINtV+WsVd3edDZgK6anmp0m9Q2?=
 =?iso-8859-1?Q?jnxJgHgn9BZfI32cUxvUxiP6CAyQQqCutYzAVYQ/r6D12TGE1rAQqmBicd?=
 =?iso-8859-1?Q?7kqJKirl/iSlvuffIbg6g2Lts+1TrfiSatBtkPi4Qhoaxjgk9EHvg8ypYU?=
 =?iso-8859-1?Q?misD3tXkphNMKVNbIBLsydIm4dTBdses913sV4r2og4pmZ8oQXImPZEfb2?=
 =?iso-8859-1?Q?H5uXxV9F3Daumcqnw9TmZZVPao59QbNVms0zgJpgyfAEtFC09J96d1g+2N?=
 =?iso-8859-1?Q?oOMCoT9tlnvA65XfghuozmQjOo5GT5xUJT7GwVElqqR6zUrYK79aJeWfrF?=
 =?iso-8859-1?Q?7F9/gRSKQtetWSmROU/8ilX+J03QiyQyW6hznCN4dy9S1E9uB4rGI4p48e?=
 =?iso-8859-1?Q?9dL9JA9YvmWOy7hbn4zrkiPEN+S6HGpl20jlgtdW6vL4X6BJH11EsEL73s?=
 =?iso-8859-1?Q?I6epFLxD10uzArpT685Dnuot1zFSVLnPJL6rvAizDGHsToQIX+T7/6r8r9?=
 =?iso-8859-1?Q?k7RnyebsVDdgenKR1qeG9neuRp1GK37Oc5WMgi38lHpv3/2Ylsb2DDUUE0?=
 =?iso-8859-1?Q?OrFVDQCzHSZsRVZZcT4v8JtJ4GXw0+6blJPiA+ZqDxBsktcNie9MtaJ4vh?=
 =?iso-8859-1?Q?fhfVu13ETCDR8F2HybO51YNToLaupMNe27nQEDZmzBkOivYlacZNHTcfJo?=
 =?iso-8859-1?Q?y/8F7peSp1sSG6j0em9X3M+h10khBbu7CdwC/paCbAdVJvpSRof7oKMiUa?=
 =?iso-8859-1?Q?92Gzrv5MkM7Gb4k6BMzYkljM8jr97t9iF3t5kqLu1Fqt+c2TABoAa6vFha?=
 =?iso-8859-1?Q?qB7oITemLhAjBeSNyD9emohMIeAtBrtez1pOd93LddhuUTSXuAUEbIvx8O?=
 =?iso-8859-1?Q?hqoFR5HXaRs0zF5JLZ7wPbg3yV75vnxV03kVPfz+hUgSs/Y/dLFwa6sWMp?=
 =?iso-8859-1?Q?XApQqtDdWXf9K1H//mL6pmf+o1z/kKsKuZgWYWSDhVtVzmeqTINAZvS80H?=
 =?iso-8859-1?Q?SYdXvR9CbjCfnEVgsQaPF+OzUZananN6YJ5ZKVgkvpkyRSGU+XEdyOKfKo?=
 =?iso-8859-1?Q?jWG8zoyFNTKFLSi8Z5XpkCmM4gAcUBBBhyYYuzhTbNUSqBXjcEb++tmy3K?=
 =?iso-8859-1?Q?H1odLUDOSHTs1jgJYs547ngB1KkRdfFdjJP/xTv/hZum4d5KJ1SwlYGW7R?=
 =?iso-8859-1?Q?XP68skdScwkXJ7Ve+pVYG3qXENQx2sdcf0qLl/Tr8umDtW76kNOzG4YDlP?=
 =?iso-8859-1?Q?TeiVf5Vj992GRG/122HS0x6l/NmJabaaS9yxzUmCWofy7QLf1wmQ9fNyuG?=
 =?iso-8859-1?Q?bzVMc9aMmMdOJO+K0p5B3BqnmxUlUYC9A6Axwvysq/ZzAEGUF8uIX82X+x?=
 =?iso-8859-1?Q?IUtHyK22IoZDYMPOcAU=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: b5c13e91-45b0-42c0-89bc-08dc174467c4
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6231.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jan 2024 10:09:34.8094
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: cllBDbjG2j+mcTImWxvkjEJ+FUX0wAdjCSTBVKewab6vO4Om+cMhMQj+FTYcdmFT2vJ1z3EThudE/ioI1Hcn6F8BLE0zbfwhKvFBC0SsjOU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR11MB5585
X-OriginatorOrg: intel.com

Hi,

On 2024-01-08 at 14:31:50 -0800, Reinette Chatre wrote:
>Hi Maciej,
>
>On 12/12/2023 6:52 AM, Maciej Wieczor-Retman wrote:
>> From: Ilpo J?rvinen <ilpo.jarvinen@linux.intel.com>
>> 
>> To select test to run -t parameter can be used. However, -t cat
>> currently maps to L3 CAT test which is confusing after more CAT related
>> tests are added.
>> 
>> Allow selecting tests as groups and call L3 CAT test "L3_CAT", "CAT"
>> group will enable all CAT related tests.
>> 
>> Signed-off-by: Ilpo J?rvinen <ilpo.jarvinen@linux.intel.com>
>> Signed-off-by: Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>
>> ---
>> Changelog v2:
>> - Move this patch from Ilpo's series here (Ilpo).
>> 
>>  tools/testing/selftests/resctrl/cat_test.c      |  3 ++-
>>  tools/testing/selftests/resctrl/resctrl.h       |  2 ++
>>  tools/testing/selftests/resctrl/resctrl_tests.c | 16 +++++++++++-----
>>  3 files changed, 15 insertions(+), 6 deletions(-)
>> 
>> diff --git a/tools/testing/selftests/resctrl/cat_test.c b/tools/testing/selftests/resctrl/cat_test.c
>> index 24af8310288a..39fc9303b8e8 100644
>> --- a/tools/testing/selftests/resctrl/cat_test.c
>> +++ b/tools/testing/selftests/resctrl/cat_test.c
>> @@ -295,7 +295,8 @@ static int cat_run_test(const struct resctrl_test *test, const struct user_param
>>  }
>>  
>>  struct resctrl_test l3_cat_test = {
>> -	.name = "CAT",
>> +	.name = "L3_CAT",
>> +	.group = "CAT",
>>  	.resource = "L3",
>>  	.feature_check = test_resource_feature_check,
>>  	.run_test = cat_run_test,
>> diff --git a/tools/testing/selftests/resctrl/resctrl.h b/tools/testing/selftests/resctrl/resctrl.h
>> index c54efcf1412a..739e16d08a7b 100644
>> --- a/tools/testing/selftests/resctrl/resctrl.h
>> +++ b/tools/testing/selftests/resctrl/resctrl.h
>> @@ -65,6 +65,7 @@ struct user_params {
>>  /*
>>   * resctrl_test:	resctrl test definition
>>   * @name:		Test name
>> + * @group:		Test group (e.g., L2 and L3 CAT test belong to CAT group), can be NULL
>
>Could you please remove references to L2 CAT test that is not available yet? A
>detailed description of what a test group is will be helpful.

Sure, thanks for catching this!

>Reinette
>

-- 
Kind regards
Maciej Wiecz?r-Retman